bvandeusen/minstrel
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 39 Wiki Activity

fix(android): drop provideLibraryApi @Provides — repos construct from Retrofit

Browse Source 
The "ModuleProcessingStep was unable to process NetworkModule because
LibraryApi could not be resolved" failure under KSP2 + Hilt 2.59.2
turns out to be specific to @Provides returning a hand-written Kotlin
interface that carries no KSP-processed annotations. Hilt's
ModuleProcessingStep resolves the return type through KSP2's API and
gets an ERROR type for source-only interfaces in some configurations
(google/dagger#4303 cluster).

Two source-of-truth interfaces I tested side-by-side:
  - AuthSessionDao (@Dao, Room-processed) — @Provides works
  - LibraryApi (only @GET Retrofit annotations, no KSP processor) — fails

Workaround that's actually a better pattern: feature repositories
construct their Retrofit interface from the Hilt-injected shared
Retrofit instance. Fewer bindings in the Hilt graph; one Retrofit
interface lives next to its sole consumer.

LibraryApi.kt + wire types remain; LibraryRepository (Phase 5.2) will
hold the `retrofit.create<LibraryApi>()` call.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Van Deusen
2026-05-22 21:05:53 -04:00
parent fe878a392c
commit 02175b193b
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/app/src/main/java/com/fabledsword/minstrel/api/NetworkModule.kt
+13 -5
View File
@@ -1,7 +1,6 @@
package com.fabledsword.minstrel.api package com.fabledsword.minstrel.api
import com.fabledsword.minstrel.BuildConfig import com.fabledsword.minstrel.BuildConfig
import com.fabledsword.minstrel.api.endpoints.LibraryApi
import com.fabledsword.minstrel.auth.AuthStore import com.fabledsword.minstrel.auth.AuthStore
import com.jakewharton.retrofit2.converter.kotlinx.serialization.asConverterFactory import com.jakewharton.retrofit2.converter.kotlinx.serialization.asConverterFactory
import dagger.Module import dagger.Module
@@ -13,7 +12,6 @@ import okhttp3.MediaType.Companion.toMediaType
import okhttp3.OkHttpClient import okhttp3.OkHttpClient
import okhttp3.logging.HttpLoggingInterceptor import okhttp3.logging.HttpLoggingInterceptor
import retrofit2.Retrofit import retrofit2.Retrofit
import retrofit2.create
import java.util.concurrent.TimeUnit import java.util.concurrent.TimeUnit
import javax.inject.Singleton import javax.inject.Singleton
@@ -72,9 +70,19 @@ object NetworkModule {
.addConverterFactory(json.asConverterFactory("application/json".toMediaType())) .addConverterFactory(json.asConverterFactory("application/json".toMediaType()))
.build() .build()
@Provides // Per-endpoint Retrofit interface @Provides intentionally NOT here.
@Singleton // Feature repositories construct their interface via the shared
fun provideLibraryApi(retrofit: Retrofit): LibraryApi = retrofit.create() // Retrofit (Hilt-injected), e.g.:
//
// class LibraryRepository @Inject constructor(retrofit: Retrofit) {
// private val api = retrofit.create<LibraryApi>()
// ...
// }
//
// Fewer Hilt bindings + no KSP2 type-resolution sharp edges from
// Hilt processing a `@Provides` return type that's a hand-written
// Kotlin interface (Hilt's ModuleProcessingStep "could not be
// resolved" failure mode under KSP2 — google/dagger#4303).
private const val CONNECT_TIMEOUT_SECONDS = 10L private const val CONNECT_TIMEOUT_SECONDS = 10L
private const val READ_TIMEOUT_SECONDS = 30L private const val READ_TIMEOUT_SECONDS = 30L