bvandeusen
bc22f8e249
CI & Build / Build now, or wait for Android? (push) Successful in 2s
CI & Build / Python lint (push) Successful in 3s
CI & Build / TypeScript typecheck (push) Failing after 6s
CI & Build / Build & push image (push) Skipped
CI & Build / Python tests (push) Successful in 8s
Desktop (Tauri) / Tauri desktop (Linux) (push) Failing after 31s
Desktop (Tauri) / Windows installer (cross-compiled) (push) Failing after 37s
Desktop (Tauri) / Update manifest (push) Skipped
Android / Kotlin + Rust (APK) (push) Failing after 1m56s
Operator, 2026-08-22 (note 2897): ThoughtSync is an intermediary surface. You
write here because it's easy — a notebook in your pocket — and later you recall
the thing and go finish it somewhere else. Recall is the product; organization
is secondary. A linking system is organization, and it isn't what this is for.
So: `[[wiki-links]]`, backlinks, the `[[` autocomplete, the note_links table,
`/api/notes/link-search`, `/api/notes/<id>/backlinks`, the whole graph blueprint
and GraphView. Rust core loses `extract_links`, `backlinks`, `link_search` and
`create_titled`; the desktop loses the three Tauri commands that exposed them.
This subsumes 982d24c rather than reverting it. That commit bound links to a
note id so a rename would stop rewriting other notes' bodies — real infra, but
infra for a feature that is now gone, and nothing it added survives. Alembic
0023 stays in the chain anyway: it shipped in an image and may already be
applied, and deleting an applied revision strands a database's version pointer.
0024 drops the table and takes the column with it. The history stays honest
about the fact that it existed for a day.
Two things deliberately kept, because they were serving recall and only
incidentally serving links:
- `/api/notes/titles` and the titles store. The command palette lists them so
you can jump to a note by name. `resolve()` — the name→note lookup that only
linking needed — is gone.
- `display_title`. Every note still has a name for search results and export
filenames. What that name is FOR changed; that it exists did not.
`notes/links.py` is now `notes/tags.py`, holding the #tag→label reconciliation
it always also owned. A file called links.py with no links in it would have been
exactly the drift this removal is meant to end.
Also swept out on the way: `_escape_like`, whose only caller was link-search,
and the `graph` icon. Nothing lost that a person typed — note_links was always
derived, and the `[[text]]` is still sitting in every body it was written in.
76 lines
2.4 KiB
Rust
76 lines
2.4 KiB
Rust
//! Deriving `#tags` from a note's body — the local mirror of what the server computes
|
|
//! on save. Pure string scanning (no regex dependency), kept in lockstep with the
|
|
//! frontend's inline rules (see frontend notes/markdown.ts):
|
|
//!
|
|
//! - `#tag`: `#` at a word boundary followed by tag characters (letter first).
|
|
//! On save these become labels attached with `via_tag = true`.
|
|
//!
|
|
//! Dedupes case-insensitively, preserving first-seen order.
|
|
//!
|
|
//! Also derived `[[wiki-links]]` until they were removed (note 2897) — this is a
|
|
//! capture-and-recall surface, and a linking system is organization.
|
|
|
|
/// Extract every `#tag` name (without the leading `#`) from `body`.
|
|
pub fn extract_tags(body: &str) -> Vec<String> {
|
|
let chars: Vec<char> = body.chars().collect();
|
|
let mut out: Vec<String> = Vec::new();
|
|
let mut i = 0;
|
|
while i < chars.len() {
|
|
if chars[i] == '#' {
|
|
let boundary = i == 0 || (!is_tag_char(chars[i - 1]) && chars[i - 1] != '#');
|
|
// A tag must start with a letter (so "#1" or a bare "#" is not a tag).
|
|
if boundary && i + 1 < chars.len() && chars[i + 1].is_alphabetic() {
|
|
let mut j = i + 1;
|
|
while j < chars.len() && is_tag_char(chars[j]) {
|
|
j += 1;
|
|
}
|
|
let tag: String = chars[i + 1..j].iter().collect();
|
|
push_unique(&mut out, &tag);
|
|
i = j;
|
|
continue;
|
|
}
|
|
}
|
|
i += 1;
|
|
}
|
|
out
|
|
}
|
|
|
|
fn is_tag_char(c: char) -> bool {
|
|
c.is_alphanumeric() || c == '_' || c == '-'
|
|
}
|
|
|
|
fn push_unique(out: &mut Vec<String>, candidate: &str) {
|
|
if !out.iter().any(|x| x.eq_ignore_ascii_case(candidate)) {
|
|
out.push(candidate.to_string());
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn tags_basic() {
|
|
assert_eq!(
|
|
extract_tags("a #todo and #Work-item_2 here"),
|
|
vec!["todo", "Work-item_2"]
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn tags_require_letter_start_and_boundary() {
|
|
// "#1" (digit) and an in-word "#" (email-ish) are not tags.
|
|
assert_eq!(extract_tags("#1 nope a#b no but #Yes"), vec!["Yes"]);
|
|
}
|
|
|
|
#[test]
|
|
fn tags_dedupe_case_insensitive() {
|
|
assert_eq!(extract_tags("#Home #home #HOME"), vec!["Home"]);
|
|
}
|
|
|
|
#[test]
|
|
fn empty_body() {
|
|
assert!(extract_tags("").is_empty());
|
|
}
|
|
}
|