bvandeusenandClaude Opus 5.5
a51a563fe7
CI & Build / Python lint (push) Successful in 2s
CI & Build / Build now, or wait for Android? (push) Successful in 2s
Android / Build, or is the channel already serving this? (push) Successful in 3s
Android / Core and FFI clippy and tests (push) Skipped
Android / Kotlin + Rust (APK) (push) Skipped
Desktop (Tauri) / Build, or is the channel already serving this? (push) Successful in 2s
CI & Build / Web typecheck and unit tests (push) Successful in 9s
CI & Build / Python tests (push) Successful in 13s
Android / Build the server image (push) Skipped
Desktop (Tauri) / Web tests, clippy, Rust tests and rustfmt (push) Skipped
Desktop (Tauri) / Tauri desktop (Linux) (push) Skipped
Desktop (Tauri) / Windows installer (cross-compiled) (push) Skipped
Desktop (Tauri) / Update manifest (push) Skipped
CI & Build / integration (push) Successful in 1m30s
CI & Build / Build & push image (push) Successful in 32s
Rule 32 "Comments describe the product to a stranger" sweep over src/, alembic/ and tests/. Comments and docstrings now say what the code does and the reason as a present-tense constraint, briefly. Removed: - issue, task, note, rule, milestone and family-idea references - "used to" / before-and-after narration - quotes of decisions and incident stories from the deploying instance - paragraph-length arguments, where a line or two carries the fact Kept every hazard as a present-tense fact, e.g. timing oracles, the proxy hop direction, and migrations that must stay frozen. Also: - Three test names lose "still"/"used to"/"pre_m304" phrasing. - pyproject's description drops "FabledSword family". The history these comments carried stays in Scribe and in git log. A comment-stripping diff (Scribe snippet #6226 "codeonly.py — prove a diff changed only comments") shows no code changed apart from the renamed tests and the description string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
65 lines
2.1 KiB
Python
65 lines
2.1 KiB
Python
"""note_links.target_id — resolve [[links]] to a note, not to a string
|
|
|
|
Revision ID: 0023
|
|
Revises: 0022
|
|
Create Date: 2026-08-22
|
|
|
|
A wiki-link stored only as normalized text makes a note's name the edge, so renaming
|
|
the note breaks every inbound link. Resolving to an id survives a rename.
|
|
|
|
`target_norm` stays: it is what an UNRESOLVED link carries, since linking to a note
|
|
that doesn't exist yet is a supported way to create one.
|
|
|
|
The backfill is safe to run bluntly because note_links is DERIVED data — every row
|
|
is recomputed from the source body on the next save regardless.
|
|
"""
|
|
from alembic import op
|
|
import sqlalchemy as sa
|
|
from sqlalchemy.dialects import postgresql
|
|
|
|
revision = "0023"
|
|
down_revision = "0022"
|
|
branch_labels = None
|
|
depends_on = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.add_column(
|
|
"note_links",
|
|
sa.Column("target_id", postgresql.UUID(as_uuid=True), nullable=True),
|
|
)
|
|
op.create_foreign_key(
|
|
"fk_note_links_target",
|
|
"note_links",
|
|
"notes",
|
|
["target_id"],
|
|
["id"],
|
|
# A deleted target un-resolves its inbound links rather than deleting them:
|
|
# the link text is still in the source's body, and it should read as pointing
|
|
# at something that isn't there — which is also what lets it re-resolve if a
|
|
# note of that name appears again.
|
|
ondelete="SET NULL",
|
|
)
|
|
op.create_index("ix_note_links_target_id", "note_links", ["target_id"])
|
|
|
|
# Resolve what can be resolved right now, scoped to the source's owner so a link
|
|
# can never bind to another user's note.
|
|
op.execute(
|
|
"""
|
|
UPDATE note_links AS nl
|
|
SET target_id = t.id
|
|
FROM notes AS src, notes AS t
|
|
WHERE nl.source_id = src.id
|
|
AND t.owner_id = src.owner_id
|
|
AND t.deleted_at IS NULL
|
|
AND lower(btrim(t.display_title)) = nl.target_norm
|
|
AND t.id <> src.id
|
|
"""
|
|
)
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.drop_index("ix_note_links_target_id", table_name="note_links")
|
|
op.drop_constraint("fk_note_links_target", "note_links", type_="foreignkey")
|
|
op.drop_column("note_links", "target_id")
|