bvandeusenandClaude Opus 5.5
a51a563fe7
CI & Build / Python lint (push) Successful in 2s
CI & Build / Build now, or wait for Android? (push) Successful in 2s
Android / Build, or is the channel already serving this? (push) Successful in 3s
Android / Core and FFI clippy and tests (push) Skipped
Android / Kotlin + Rust (APK) (push) Skipped
Desktop (Tauri) / Build, or is the channel already serving this? (push) Successful in 2s
CI & Build / Web typecheck and unit tests (push) Successful in 9s
CI & Build / Python tests (push) Successful in 13s
Android / Build the server image (push) Skipped
Desktop (Tauri) / Web tests, clippy, Rust tests and rustfmt (push) Skipped
Desktop (Tauri) / Tauri desktop (Linux) (push) Skipped
Desktop (Tauri) / Windows installer (cross-compiled) (push) Skipped
Desktop (Tauri) / Update manifest (push) Skipped
CI & Build / integration (push) Successful in 1m30s
CI & Build / Build & push image (push) Successful in 32s
Rule 32 "Comments describe the product to a stranger" sweep over src/, alembic/ and tests/. Comments and docstrings now say what the code does and the reason as a present-tense constraint, briefly. Removed: - issue, task, note, rule, milestone and family-idea references - "used to" / before-and-after narration - quotes of decisions and incident stories from the deploying instance - paragraph-length arguments, where a line or two carries the fact Kept every hazard as a present-tense fact, e.g. timing oracles, the proxy hop direction, and migrations that must stay frozen. Also: - Three test names lose "still"/"used to"/"pre_m304" phrasing. - pyproject's description drops "FabledSword family". The history these comments carried stays in Scribe and in git log. A comment-stripping diff (Scribe snippet #6226 "codeonly.py — prove a diff changed only comments") shows no code changed apart from the renamed tests and the description string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
50 lines
1.6 KiB
Python
50 lines
1.6 KiB
Python
"""shares: one grant per note and person, and only the permissions the app knows
|
|
|
|
Revision ID: 0034
|
|
Revises: 0033
|
|
Create Date: 2026-10-07
|
|
|
|
For the Share dialog:
|
|
- A unique index on (resource_type, resource_id, shared_with_user_id) where a user is
|
|
the target, so sharing a note with someone twice updates the one grant rather than
|
|
stacking two (the same for a group).
|
|
- A check that `permission` is `view` or `edit`.
|
|
- An index on `shared_with_user_id` for "Shared with me".
|
|
|
|
## Downgrade
|
|
|
|
Drops the indexes and the check. The rows stay.
|
|
"""
|
|
from alembic import op
|
|
|
|
revision = "0034"
|
|
down_revision = "0033"
|
|
branch_labels = None
|
|
depends_on = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.create_index(
|
|
"uq_shares_resource_user",
|
|
"shares",
|
|
["resource_type", "resource_id", "shared_with_user_id"],
|
|
unique=True,
|
|
postgresql_where="shared_with_user_id IS NOT NULL",
|
|
)
|
|
op.create_index(
|
|
"uq_shares_resource_group",
|
|
"shares",
|
|
["resource_type", "resource_id", "shared_with_group_id"],
|
|
unique=True,
|
|
postgresql_where="shared_with_group_id IS NOT NULL",
|
|
)
|
|
op.create_index("ix_shares_user", "shares", ["shared_with_user_id"])
|
|
op.create_check_constraint("ck_shares_permission", "shares", "permission IN ('view', 'edit')")
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.drop_constraint("ck_shares_permission", "shares", type_="check")
|
|
op.drop_index("ix_shares_user", table_name="shares")
|
|
op.drop_index("uq_shares_resource_group", table_name="shares")
|
|
op.drop_index("uq_shares_resource_user", table_name="shares")
|