bvandeusenandClaude Opus 5.5
a51a563fe7
CI & Build / Python lint (push) Successful in 2s
CI & Build / Build now, or wait for Android? (push) Successful in 2s
Android / Build, or is the channel already serving this? (push) Successful in 3s
Android / Core and FFI clippy and tests (push) Skipped
Android / Kotlin + Rust (APK) (push) Skipped
Desktop (Tauri) / Build, or is the channel already serving this? (push) Successful in 2s
CI & Build / Web typecheck and unit tests (push) Successful in 9s
CI & Build / Python tests (push) Successful in 13s
Android / Build the server image (push) Skipped
Desktop (Tauri) / Web tests, clippy, Rust tests and rustfmt (push) Skipped
Desktop (Tauri) / Tauri desktop (Linux) (push) Skipped
Desktop (Tauri) / Windows installer (cross-compiled) (push) Skipped
Desktop (Tauri) / Update manifest (push) Skipped
CI & Build / integration (push) Successful in 1m30s
CI & Build / Build & push image (push) Successful in 32s
Rule 32 "Comments describe the product to a stranger" sweep over src/, alembic/ and tests/. Comments and docstrings now say what the code does and the reason as a present-tense constraint, briefly. Removed: - issue, task, note, rule, milestone and family-idea references - "used to" / before-and-after narration - quotes of decisions and incident stories from the deploying instance - paragraph-length arguments, where a line or two carries the fact Kept every hazard as a present-tense fact, e.g. timing oracles, the proxy hop direction, and migrations that must stay frozen. Also: - Three test names lose "still"/"used to"/"pre_m304" phrasing. - pyproject's description drops "FabledSword family". The history these comments carried stays in Scribe and in git log. A comment-stripping diff (Scribe snippet #6226 "codeonly.py — prove a diff changed only comments") shows no code changed apart from the renamed tests and the description string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
64 lines
2.3 KiB
Python
64 lines
2.3 KiB
Python
"""drop notes.title and note_revisions.title — a note's name is its first line
|
|
|
|
Revision ID: 0026
|
|
Revises: 0025
|
|
Create Date: 2026-08-22
|
|
|
|
A note's name is its first non-empty body line, carried by `display_title`.
|
|
|
|
`notes.search_vector` is a stored generated column over `title` (0005, weight A), and
|
|
Postgres won't drop a column a generated one depends on. So it is recreated over
|
|
`display_title`, keeping the name ranked above the body. That recomputes every row
|
|
and rebuilds the GIN index, which takes a while on a large table.
|
|
|
|
`display_title` was already derived from the title, so every note keeps its name.
|
|
"""
|
|
from alembic import op
|
|
import sqlalchemy as sa
|
|
|
|
revision = "0026"
|
|
down_revision = "0025"
|
|
branch_labels = None
|
|
depends_on = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
# Order matters: the generated column depends on `title`, so it goes first.
|
|
op.execute("DROP INDEX IF EXISTS ix_notes_search")
|
|
op.execute("ALTER TABLE notes DROP COLUMN IF EXISTS search_vector")
|
|
|
|
op.drop_column("notes", "title")
|
|
op.drop_column("note_revisions", "title")
|
|
|
|
op.execute(
|
|
"""
|
|
ALTER TABLE notes ADD COLUMN search_vector tsvector
|
|
GENERATED ALWAYS AS (
|
|
setweight(to_tsvector('english', coalesce(display_title, '')), 'A') ||
|
|
setweight(to_tsvector('english', coalesce(body, '')), 'B')
|
|
) STORED
|
|
"""
|
|
)
|
|
op.execute("CREATE INDEX ix_notes_search ON notes USING GIN (search_vector)")
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.execute("DROP INDEX IF EXISTS ix_notes_search")
|
|
op.execute("ALTER TABLE notes DROP COLUMN IF EXISTS search_vector")
|
|
|
|
# Comes back empty. The text is not gone — it is the first line of every body —
|
|
# but which notes once had an explicit title is not recorded anywhere.
|
|
op.add_column("notes", sa.Column("title", sa.Text(), nullable=True))
|
|
op.add_column("note_revisions", sa.Column("title", sa.Text(), nullable=True))
|
|
|
|
op.execute(
|
|
"""
|
|
ALTER TABLE notes ADD COLUMN search_vector tsvector
|
|
GENERATED ALWAYS AS (
|
|
setweight(to_tsvector('english', coalesce(title, '')), 'A') ||
|
|
setweight(to_tsvector('english', coalesce(body, '')), 'B')
|
|
) STORED
|
|
"""
|
|
)
|
|
op.execute("CREATE INDEX ix_notes_search ON notes USING GIN (search_vector)")
|