bvandeusenandClaude Opus 5.5
a51a563fe7
CI & Build / Python lint (push) Successful in 2s
CI & Build / Build now, or wait for Android? (push) Successful in 2s
Android / Build, or is the channel already serving this? (push) Successful in 3s
Android / Core and FFI clippy and tests (push) Skipped
Android / Kotlin + Rust (APK) (push) Skipped
Desktop (Tauri) / Build, or is the channel already serving this? (push) Successful in 2s
CI & Build / Web typecheck and unit tests (push) Successful in 9s
CI & Build / Python tests (push) Successful in 13s
Android / Build the server image (push) Skipped
Desktop (Tauri) / Web tests, clippy, Rust tests and rustfmt (push) Skipped
Desktop (Tauri) / Tauri desktop (Linux) (push) Skipped
Desktop (Tauri) / Windows installer (cross-compiled) (push) Skipped
Desktop (Tauri) / Update manifest (push) Skipped
CI & Build / integration (push) Successful in 1m30s
CI & Build / Build & push image (push) Successful in 32s
Rule 32 "Comments describe the product to a stranger" sweep over src/, alembic/ and tests/. Comments and docstrings now say what the code does and the reason as a present-tense constraint, briefly. Removed: - issue, task, note, rule, milestone and family-idea references - "used to" / before-and-after narration - quotes of decisions and incident stories from the deploying instance - paragraph-length arguments, where a line or two carries the fact Kept every hazard as a present-tense fact, e.g. timing oracles, the proxy hop direction, and migrations that must stay frozen. Also: - Three test names lose "still"/"used to"/"pre_m304" phrasing. - pyproject's description drops "FabledSword family". The history these comments carried stays in Scribe and in git log. A comment-stripping diff (Scribe snippet #6226 "codeonly.py — prove a diff changed only comments") shows no code changed apart from the renamed tests and the description string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
54 lines
2.2 KiB
Python
54 lines
2.2 KiB
Python
"""note_user_state: a recipient's own pin, archive and place for a shared note
|
|
|
|
Revision ID: 0036
|
|
Revises: 0035
|
|
Create Date: 2026-10-07
|
|
|
|
Pin, archive and board order are personal. The owner's are columns on `notes`; this
|
|
table holds everyone else's, one row per (note, person it is shared with) who has
|
|
pinned, archived or moved it. A recipient with no row sees the note unpinned,
|
|
unarchived, in the owner's order.
|
|
|
|
`sync_revision` is stamped by the same `ts_set_sync_revision()` trigger the notes
|
|
and labels use (0015), so a recipient's change reaches their own devices on the one
|
|
cursor they already page by, and never moves the note on anyone else's.
|
|
|
|
## Downgrade
|
|
|
|
Drops the table. Recipients lose their own pins and archives; the notes are
|
|
untouched.
|
|
"""
|
|
import sqlalchemy as sa
|
|
from alembic import op
|
|
from sqlalchemy.dialects.postgresql import UUID
|
|
|
|
revision = "0036"
|
|
down_revision = "0035"
|
|
branch_labels = None
|
|
depends_on = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.create_table(
|
|
"note_user_state",
|
|
sa.Column("note_id", UUID(as_uuid=True), sa.ForeignKey("notes.id", ondelete="CASCADE"), nullable=False),
|
|
sa.Column("user_id", UUID(as_uuid=True), sa.ForeignKey("users.id", ondelete="CASCADE"), nullable=False),
|
|
sa.Column("pinned", sa.Boolean(), nullable=False, server_default=sa.false()),
|
|
sa.Column("archived", sa.Boolean(), nullable=False, server_default=sa.false()),
|
|
sa.Column("position", sa.Integer(), nullable=True),
|
|
sa.Column("updated_at", sa.DateTime(timezone=True), nullable=False, server_default=sa.func.now()),
|
|
sa.Column("sync_revision", sa.BigInteger(), nullable=True),
|
|
sa.PrimaryKeyConstraint("note_id", "user_id"),
|
|
)
|
|
op.create_index("ix_note_user_state_user_revision", "note_user_state", ["user_id", "sync_revision"])
|
|
op.execute(
|
|
"CREATE TRIGGER trg_note_user_state_sync_revision BEFORE INSERT OR UPDATE ON note_user_state "
|
|
"FOR EACH ROW EXECUTE PROCEDURE ts_set_sync_revision()"
|
|
)
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.execute("DROP TRIGGER IF EXISTS trg_note_user_state_sync_revision ON note_user_state")
|
|
op.drop_index("ix_note_user_state_user_revision", table_name="note_user_state")
|
|
op.drop_table("note_user_state")
|