bvandeusenandClaude Opus 5.5
a51a563fe7
CI & Build / Python lint (push) Successful in 2s
CI & Build / Build now, or wait for Android? (push) Successful in 2s
Android / Build, or is the channel already serving this? (push) Successful in 3s
Android / Core and FFI clippy and tests (push) Skipped
Android / Kotlin + Rust (APK) (push) Skipped
Desktop (Tauri) / Build, or is the channel already serving this? (push) Successful in 2s
CI & Build / Web typecheck and unit tests (push) Successful in 9s
CI & Build / Python tests (push) Successful in 13s
Android / Build the server image (push) Skipped
Desktop (Tauri) / Web tests, clippy, Rust tests and rustfmt (push) Skipped
Desktop (Tauri) / Tauri desktop (Linux) (push) Skipped
Desktop (Tauri) / Windows installer (cross-compiled) (push) Skipped
Desktop (Tauri) / Update manifest (push) Skipped
CI & Build / integration (push) Successful in 1m30s
CI & Build / Build & push image (push) Successful in 32s
Rule 32 "Comments describe the product to a stranger" sweep over src/, alembic/ and tests/. Comments and docstrings now say what the code does and the reason as a present-tense constraint, briefly. Removed: - issue, task, note, rule, milestone and family-idea references - "used to" / before-and-after narration - quotes of decisions and incident stories from the deploying instance - paragraph-length arguments, where a line or two carries the fact Kept every hazard as a present-tense fact, e.g. timing oracles, the proxy hop direction, and migrations that must stay frozen. Also: - Three test names lose "still"/"used to"/"pre_m304" phrasing. - pyproject's description drops "FabledSword family". The history these comments carried stays in Scribe and in git log. A comment-stripping diff (Scribe snippet #6226 "codeonly.py — prove a diff changed only comments") shows no code changed apart from the renamed tests and the description string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
40 lines
1.1 KiB
Python
40 lines
1.1 KiB
Python
"""labels: a tag's name is unique among LIVE tags only
|
|
|
|
Revision ID: 0040
|
|
Revises: 0039
|
|
Create Date: 2026-10-08
|
|
|
|
Deleting a tag leaves a tombstone row (`purged_at` set) so the change feed tells
|
|
linked devices. A tombstone must not hold its name, so `(owner_id, name)` is unique
|
|
only where `purged_at IS NULL`.
|
|
|
|
## Downgrade
|
|
|
|
Restores the plain unique constraint. Tombstones are deleted first, since one may
|
|
share its name with a live tag; devices that have not pulled since keep the tag.
|
|
"""
|
|
import sqlalchemy as sa
|
|
from alembic import op
|
|
|
|
revision = "0040"
|
|
down_revision = "0039"
|
|
branch_labels = None
|
|
depends_on = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.drop_constraint("uq_labels_owner_name", "labels", type_="unique")
|
|
op.create_index(
|
|
"uq_labels_owner_name_live",
|
|
"labels",
|
|
["owner_id", "name"],
|
|
unique=True,
|
|
postgresql_where=sa.text("purged_at IS NULL"),
|
|
)
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.drop_index("uq_labels_owner_name_live", table_name="labels")
|
|
op.execute("DELETE FROM labels WHERE purged_at IS NOT NULL")
|
|
op.create_unique_constraint("uq_labels_owner_name", "labels", ["owner_id", "name"])
|