bvandeusenandClaude Opus 5.5
a51a563fe7
CI & Build / Python lint (push) Successful in 2s
CI & Build / Build now, or wait for Android? (push) Successful in 2s
Android / Build, or is the channel already serving this? (push) Successful in 3s
Android / Core and FFI clippy and tests (push) Skipped
Android / Kotlin + Rust (APK) (push) Skipped
Desktop (Tauri) / Build, or is the channel already serving this? (push) Successful in 2s
CI & Build / Web typecheck and unit tests (push) Successful in 9s
CI & Build / Python tests (push) Successful in 13s
Android / Build the server image (push) Skipped
Desktop (Tauri) / Web tests, clippy, Rust tests and rustfmt (push) Skipped
Desktop (Tauri) / Tauri desktop (Linux) (push) Skipped
Desktop (Tauri) / Windows installer (cross-compiled) (push) Skipped
Desktop (Tauri) / Update manifest (push) Skipped
CI & Build / integration (push) Successful in 1m30s
CI & Build / Build & push image (push) Successful in 32s
Rule 32 "Comments describe the product to a stranger" sweep over src/, alembic/ and tests/. Comments and docstrings now say what the code does and the reason as a present-tense constraint, briefly. Removed: - issue, task, note, rule, milestone and family-idea references - "used to" / before-and-after narration - quotes of decisions and incident stories from the deploying instance - paragraph-length arguments, where a line or two carries the fact Kept every hazard as a present-tense fact, e.g. timing oracles, the proxy hop direction, and migrations that must stay frozen. Also: - Three test names lose "still"/"used to"/"pre_m304" phrasing. - pyproject's description drops "FabledSword family". The history these comments carried stays in Scribe and in git log. A comment-stripping diff (Scribe snippet #6226 "codeonly.py — prove a diff changed only comments") shows no code changed apart from the renamed tests and the description string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
51 lines
1.9 KiB
Python
51 lines
1.9 KiB
Python
"""share_revocations: telling a recipient's devices a shared note has left them
|
|
|
|
Revision ID: 0035
|
|
Revises: 0034
|
|
Create Date: 2026-10-07
|
|
|
|
The change feed carries every note a person can see, including notes shared with
|
|
them. When a share ends, the note stops being visible, so it simply stops
|
|
appearing in the feed. A device that already holds a copy would keep it forever. A
|
|
revocation is that missing signal: one row per (note, person) who lost the note,
|
|
stamped from the same `sync_revision_seq` the notes and labels draw from, so it sits
|
|
on the one cursor every client already pages by.
|
|
|
|
Sharing the note with that person again deletes the row, so a device that never
|
|
heard of the revocation never gets told to delete a note it is meant to have.
|
|
|
|
## Downgrade
|
|
|
|
Drops the table. Devices that missed a revocation keep their copy.
|
|
"""
|
|
import sqlalchemy as sa
|
|
from alembic import op
|
|
from sqlalchemy.dialects.postgresql import UUID
|
|
|
|
revision = "0035"
|
|
down_revision = "0034"
|
|
branch_labels = None
|
|
depends_on = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.create_table(
|
|
"share_revocations",
|
|
sa.Column("note_id", UUID(as_uuid=True), sa.ForeignKey("notes.id", ondelete="CASCADE"), nullable=False),
|
|
sa.Column("user_id", UUID(as_uuid=True), sa.ForeignKey("users.id", ondelete="CASCADE"), nullable=False),
|
|
sa.Column(
|
|
"sync_revision",
|
|
sa.BigInteger(),
|
|
nullable=False,
|
|
server_default=sa.text("nextval('sync_revision_seq')"),
|
|
),
|
|
sa.Column("created_at", sa.DateTime(timezone=True), nullable=False, server_default=sa.func.now()),
|
|
sa.PrimaryKeyConstraint("note_id", "user_id"),
|
|
)
|
|
op.create_index("ix_share_revocations_user_revision", "share_revocations", ["user_id", "sync_revision"])
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.drop_index("ix_share_revocations_user_revision", table_name="share_revocations")
|
|
op.drop_table("share_revocations")
|