2 Commits
Author SHA1 Message Date
bvandeusenandClaude Opus 5.5 a682d6d225 core: a deliberately failing test, to prove the APK gate (reverted next)
CI & Build / Python lint (push) Successful in 2s
CI & Build / Build now, or wait for Android? (push) Successful in 2s
Android / Build, or is the channel already serving this? (push) Successful in 3s
Desktop (Tauri) / Build, or is the channel already serving this? (push) Successful in 2s
CI & Build / Python tests (push) Successful in 12s
Desktop (Tauri) / Web tests, clippy, Rust tests and rustfmt (push) Failing after 2m31s
Desktop (Tauri) / Tauri desktop (Linux) (push) Skipped
Desktop (Tauri) / Windows installer (cross-compiled) (push) Skipped
Desktop (Tauri) / Update manifest (push) Skipped
CI & Build / Web typecheck and unit tests (push) Successful in 8s
CI & Build / integration (push) Successful in 1m22s
CI & Build / Build & push image (push) Skipped
Android / Kotlin + Rust (APK) (push) Failing after 3m39s
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 22:35:06 -04:00
bvandeusenandClaude Opus 5.5 42db4cde6b ci: the APK waits for the core's clippy and tests
android.yml never ran cargo, so a core test that failed in desktop.yml's
verify job stopped the desktop installers and not the APK, which links the
same core through android/ffi (#5237). The Kotlin + Rust job now runs clippy
and the tests for inkwell-core and inkwell-ffi before anything is assembled
or published.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 22:35:06 -04:00
2 changed files with 19 additions and 2 deletions
+12 -2
View File
@@ -169,6 +169,16 @@ jobs:
- name: Build the native library and bindings
run: ./gradlew generateUniffiBindings -PINKWELL_CARGO_PROFILE=${{ steps.build.outputs.profile }}
# The core ships inside this APK (through android/ffi), so its checks have to
# gate the APK HERE, in this workflow's graph. desktop.yml runs them too, but a
# red run there cannot stop this lane publishing (rule 177, #5237). Host
# target: the crates' own tests, not the cross-compiled .so.
- name: Rust clippy and tests (core and FFI)
working-directory: .
run: |
cargo clippy --locked -p inkwell-core -p inkwell-ffi --all-targets -- -D warnings
cargo test --locked -p inkwell-core -p inkwell-ffi
# The image's PINNED CLIs, not Gradle plugins. ci-rust-android carries both
# (M12 step 3) precisely so this lane needs no second image, and going
# through Gradle plugins would mean a second version of each tool resolved
@@ -185,8 +195,8 @@ jobs:
- name: Unit tests
# Host-JVM tests only. Anything touching the core needs an Android
# runtime to load the .so, so those are instrumented tests and belong on
# an emulator, not here — the Rust side is covered by the workspace
# tests in the desktop lane.
# an emulator, not here — the Rust side is covered by the cargo step
# above.
#
# DEBUG regardless of what is being packaged: AGP creates unit-test tasks
# only for `testBuildType`, which is debug, so `testReleaseUnitTest` does
+7
View File
@@ -1192,6 +1192,13 @@ mod tests {
list_notes(conn, &query).expect("list")
}
// Throwaway (#5237): proves a red core test stops the APK. Reverted next commit.
#[test]
fn deliberately_red_for_the_apk_gate() {
let n = "x".len();
assert_eq!(n, 2, "this test exists to fail");
}
fn ids(notes: &[Note]) -> Vec<&str> {
notes.iter().map(|n| n.id.as_str()).collect()
}