all: remove saved views, the Has-reminder filter and the Created range
CI & Build / Build now, or wait for Android? (push) Successful in 3s
Android / Build, or is the channel already serving this? (push) Successful in 3s
CI & Build / Python lint (push) Successful in 2s
CI & Build / Web typecheck and unit tests (push) Successful in 13s
Desktop (Tauri) / Build, or is the channel already serving this? (push) Successful in 2s
CI & Build / Python tests (push) Successful in 15s
CI & Build / integration (push) Successful in 1m29s
CI & Build / Build & push image (push) Skipped
Desktop (Tauri) / Web tests, clippy, Rust tests and rustfmt (push) Successful in 3m34s
Desktop (Tauri) / Windows installer (cross-compiled) (push) Successful in 3m5s
Desktop (Tauri) / Tauri desktop (Linux) (push) Successful in 3m49s
Desktop (Tauri) / Update manifest (push) Successful in 3s
Android / Kotlin + Rust (APK) (push) Successful in 9m29s

Step 18 of the audit follow-through (#5180), on the operator's decisions.
Inkwell is for capture and recall (note 2897), and these three duplicated a
surface that does the job already:

- Saved views. They lived only on the web; the desktop kept its own set that
  never synced, and Android had none. Tags in the drawer already give
  one-click recall. Gone from the server (routes, model, migration 0038 drops
  the table), the core (store functions, schema v13 drops its table), the
  desktop commands, the web adapters, the drawer's Views list and the
  "Save view" link.
- The "Has reminder" facet. The Reminders page lists them, sorted by due.
- The FilterBar's "Created" range. Timeline is the date lens and keeps the
  created_after/created_before query it builds from local days, which also
  retires the UTC/local-day disagreement between the two (B3).

An old link that still carries the removed keys opens the plain board; a
web test pins that.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-07 21:29:28 -04:00
co-authored by Claude Opus 5.5
parent 888c6410f0
commit b019172d47
25 changed files with 106 additions and 574 deletions
+24
View File
@@ -0,0 +1,24 @@
import { describe, expect, it } from "vitest";
import { facetCount, facetsFromQuery, facetsToQuery } from "./facets";
describe("the board's filter URL", () => {
it("round-trips the facets the Filters panel offers", () => {
const query = { q: "milk", label: ["a", "b"], has_attachment: "true", shared: "with_me" };
const facets = facetsFromQuery(query);
expect(facetsToQuery(facets)).toEqual(query);
expect(facetCount(facets)).toBe(5);
});
// Removed in #5180: reminders have their own lens and dates are Timeline's. A link
// saved before then must open the plain board, not one filtered with no chip to say so.
it("ignores the reminder and date keys an old link may carry", () => {
const facets = facetsFromQuery({
has_reminder: "true",
created_after: "2026-01-01T00:00:00",
created_before: "2026-02-01T00:00:00",
});
expect(facets).toEqual({});
expect(facetCount(facets)).toBe(0);
});
});
+2 -11
View File
@@ -1,5 +1,6 @@
// Convert between the board's URL query and a NoteFacets object. The URL query IS the
// filter state (so a lens is shareable/bookmarkable and a saved view is just a link).
// filter state, so a filtered board is shareable and bookmarkable. The date bounds are
// Timeline's, which builds its own query, so they never ride in the URL.
import type { LocationQuery, LocationQueryRaw } from "vue-router";
import type { NoteFacets } from "../stores/notes";
@@ -16,12 +17,7 @@ export function facetsFromQuery(q: LocationQuery): NoteFacets {
const text = one(q.q);
if (text) f.q = text;
if (labels.length) f.label = labels;
if (one(q.has_reminder) === "true") f.has_reminder = true;
if (one(q.has_attachment) === "true") f.has_attachment = true;
const after = one(q.created_after);
if (after) f.created_after = after;
const before = one(q.created_before);
if (before) f.created_before = before;
if (one(q.shared) === "with_me") f.shared = "with_me";
return f;
}
@@ -30,10 +26,7 @@ export function facetsToQuery(f: NoteFacets): LocationQueryRaw {
const q: LocationQueryRaw = {};
if (f.q) q.q = f.q;
if (f.label?.length) q.label = f.label;
if (f.has_reminder) q.has_reminder = "true";
if (f.has_attachment) q.has_attachment = "true";
if (f.created_after) q.created_after = f.created_after;
if (f.created_before) q.created_before = f.created_before;
if (f.shared) q.shared = f.shared;
return q;
}
@@ -43,9 +36,7 @@ export function facetCount(f: NoteFacets): number {
let n = 0;
if (f.q) n++;
n += f.label?.length ?? 0;
if (f.has_reminder) n++;
if (f.has_attachment) n++;
if (f.created_after || f.created_before) n++;
if (f.shared) n++;
return n;
}