android: bring BoardScreen and NoteCard back under detekt's complexity limit

Run 8693's detekt failed both on CyclomaticComplexMethod (17 and 15 against
15) after the filters and drag-to-reorder landed.

- BoardState now carries `filterable` and `reorderable`, so the board's
  rules for when the filter row shows and when a card can be carried live
  with the state they read instead of as boolean chains in the screen.
- NoteCard's contents (tags, body, links, attachments, reminder, sharing)
  move to their own CardContents composable, leaving NoteCard the gestures,
  the frame and the menu.

No behaviour change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

android/app/src/main/java/com/fabledsword/inkwell/ui/BoardScreen.kt

@@ -195,10 +195,7 @@ fun BoardScreen(
                     onMenu = { scope.launch { drawerState.open() } },
                 )
 
-                // The main board only, and not while searching, as on the web: a
+                if (state.filterable) {
-                // search spans everything, so a filter row over its hits would be a
-                // control that does nothing.
-                if (state.destination == Destination.Notes && !state.searching) {
                     FilterRow(
                         filters = state.filters,
                         onOpen = { filtering = true },
@@ -257,13 +254,7 @@ fun BoardScreen(
                                 onToggleItem = onToggleItem,
                                 onNoteAction = onCardAction,
                                 onConfirmDelete = { confirmingDelete = it },
-                                // The whole board in one order, as on the web: not a
+                                reorderable = state.reorderable,
-                                // search, another view, or a filtered subset, whose
-                                // order would be renumbered against notes it can't see.
-                                reorderable =
-                                    state.destination == Destination.Notes &&
-                                        !state.searching &&
-                                        state.filters.count == 0,
                                 onReorder = onReorder,
                             )
                     }

android/app/src/main/java/com/fabledsword/inkwell/ui/BoardViewModel.kt

@@ -85,6 +85,18 @@ data class BoardState(
 ) {
     /** Search overrides the destination while there is a query to run. */
     val searching: Boolean get() = query.isNotBlank()
+
+    /**
+     * The main board only, and not while searching, as on the web: a search spans
+     * everything, so a filter over its hits would be a control that does nothing.
+     */
+    val filterable: Boolean get() = destination == Destination.Notes && !searching
+
+    /**
+     * The whole board in one order, as on the web: not a search, another view, or a
+     * filtered subset, whose order would be renumbered against notes it can't see.
+     */
+    val reorderable: Boolean get() = filterable && filters.count == 0
 }
 
 /**

android/app/src/main/java/com/fabledsword/inkwell/ui/NoteCard.kt

@@ -107,6 +107,25 @@ fun NoteCard(
                     .background(noteCardSurface(dark))
                     .border(1.dp, if (dark) CARD_EDGE_DARK else CARD_EDGE_LIGHT, RoundedCornerShape(CARD_RADIUS))
                     .padding(12.dp),
+        ) {
+            CardContents(note = note, onToggleItem = onToggleItem)
+        }
+
+        NoteMenu(
+            note = note,
+            expanded = menuOpen,
+            onDismiss = { menuOpen = false },
+            onAction = onAction,
+            onConfirmDelete = onConfirmDelete,
+        )
+    }
+}
+
+/** What a card shows, top to bottom: tags, body, links, attachments, reminder, sharing. */
+@Composable
+private fun CardContents(
+    note: Note,
+    onToggleItem: (Int, Boolean) -> Unit,
 ) {
     // TAGS FIRST, on a row of their own above the body: a board is scanned, and
     // what a note is about should be the first thing the eye lands on. Not beside
@@ -179,16 +198,6 @@ fun NoteCard(
     SharedChip(note)
 }
 
-        NoteMenu(
-            note = note,
-            expanded = menuOpen,
-            onDismiss = { menuOpen = false },
-            onAction = onAction,
-            onConfirmDelete = onConfirmDelete,
-        )
-    }
-}
-
 /**
  * What you can do to a note without opening it, on a long press.
  *