From c9fce48a39fb0fba8c201786b2a546f5369d168d Mon Sep 17 00:00:00 2001
From: Bryan Van Deusen <bryan.vandeusen@fabledsword.com>
Date: Wed, 22 Apr 2026 16:16:38 -0400
Subject: [PATCH] refactor(js): use display_name from API instead of
 client-side split

Every user-facing tag rendering now reads tag.display_name from the
server JSON. The client-side split-on-colon fallback is removed.
Series-info link switches from ?tag=<name> to ?tag_id=<int>.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 app/static/js/tag-editor.js |  5 ++---
 app/static/js/view-modal.js | 11 +++--------
 2 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/app/static/js/tag-editor.js b/app/static/js/tag-editor.js
index a0824f7..fa55de1 100644
--- a/app/static/js/tag-editor.js
+++ b/app/static/js/tag-editor.js
@@ -52,9 +52,8 @@ document.addEventListener('DOMContentLoaded', () => {
     }
 
     fandomAutocomplete.innerHTML = tags.map((t, i) => {
-      const displayName = t.name.includes(':') ? t.name.split(':')[1] : t.name;
-      return `<div class="tag-autocomplete-item" data-index="${i}" data-id="${t.id}" data-name="${displayName}">
-        <span class="tag-autocomplete-name">🎭 ${displayName}</span>
+      return `<div class="tag-autocomplete-item" data-index="${i}" data-id="${t.id}" data-name="${t.display_name}">
+        <span class="tag-autocomplete-name">🎭 ${t.display_name}</span>
       </div>`;
     }).join('');
 
diff --git a/app/static/js/view-modal.js b/app/static/js/view-modal.js
index 0de47c7..ed4447f 100644
--- a/app/static/js/view-modal.js
+++ b/app/static/js/view-modal.js
@@ -457,8 +457,7 @@ document.addEventListener('DOMContentLoaded', () => {
       seriesTags.forEach(tag => {
         const opt = document.createElement('option');
         opt.value = tag.id;
-        // Display name without prefix
-        opt.textContent = tag.name.includes(':') ? tag.name.split(':', 2)[1] : tag.name;
+        opt.textContent = tag.display_name;
         seriesSelect.appendChild(opt);
       });
 
@@ -514,13 +513,9 @@ document.addEventListener('DOMContentLoaded', () => {
     if (!seriesInfoEl || !seriesPage) return;
     currentSeriesPageId = seriesPage.id;
 
-    // Display series name (strip prefix)
-    const displayName = seriesPage.series_name.includes(':')
-      ? seriesPage.series_name.split(':', 2)[1]
-      : seriesPage.series_name;
     if (seriesNameEl) {
-      seriesNameEl.textContent = displayName;
-      seriesNameEl.href = `/gallery?tag=${encodeURIComponent(seriesPage.series_name)}`;
+      seriesNameEl.textContent = seriesPage.series_name;
+      seriesNameEl.href = `/gallery?tag_id=${encodeURIComponent(seriesPage.series_tag_id)}`;
     }
 
     // Display page number