bvandeusenandClaude Opus 5.5
210a35c956
Step 1 of milestone 514 "Updates and reboots on a cadence, carried out by each host's agent…": #5765 "The agent reports pending updates and whether a reboot is required". - Agent 1.16.0: an hourly background check (apt-check, apt list, or dnf -C with updateinfo and needs-restarting), each command bounded at 120 s, no root and no network. Debian's reboot-required marker and its packages are read every sample. - Ingest records updates_pending, updates_security and reboot_required for rules, and keeps the newest on the registration (host_agent_005_updates). - The Agent card leads with "Reboot required since …", then the updates waiting or "Up to date", with when the check ran. list_agents carries them too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
93 lines
3.4 KiB
Python
93 lines
3.4 KiB
Python
# tests/plugins/host_agent/test_agent_updates.py
|
|
"""#5765: the agent says what the package manager has waiting and whether the
|
|
host needs a reboot, without root, without the network, and without a slow
|
|
apt ever holding up a sample."""
|
|
import os
|
|
import subprocess
|
|
import threading
|
|
import time
|
|
|
|
from plugins.host_agent import agent as a
|
|
|
|
|
|
def test_apt_check_counts_are_read_from_its_stderr():
|
|
assert a.parse_apt_check("12;3") == (12, 3)
|
|
assert a.parse_apt_check("") is None
|
|
|
|
|
|
def test_apt_list_counts_security_updates_by_their_suite():
|
|
out = ("Listing...\n"
|
|
"libc6/noble-updates,noble-security 2.39-0ubuntu8.4 amd64 [upgradable from: 2.39-0ubuntu8.3]\n"
|
|
"curl/noble-updates 8.5.0-2ubuntu10.5 amd64 [upgradable from: 8.5.0-2ubuntu10.4]\n")
|
|
assert a.parse_apt_list(out) == (2, 1)
|
|
|
|
|
|
def test_dnf_check_update_counts_packages_and_stops_at_obsoletes():
|
|
out = ("\nkernel.x86_64 5.14.0-503 baseos\nopenssl.x86_64 3.2.2-6 baseos\n"
|
|
"Obsoleting Packages\ngrub2.x86_64 2.06 baseos\n")
|
|
assert a.parse_dnf_check_update(out) == 2
|
|
|
|
|
|
def test_apt_hosts_are_checked_with_apt_check(monkeypatch):
|
|
calls = []
|
|
|
|
def fake_run(cmd, deadline=a.UPDATES_DEADLINE_SECONDS):
|
|
calls.append(cmd[0])
|
|
return (0, "", "7;2") if cmd[0].endswith("apt-check") else None
|
|
|
|
monkeypatch.setattr(a, "_run", fake_run)
|
|
got = a.collect_updates()
|
|
assert (got["manager"], got["pending"], got["security"]) == ("apt", 7, 2)
|
|
assert calls == ["/usr/lib/update-notifier/apt-check"]
|
|
|
|
|
|
def test_a_package_manager_that_hangs_is_an_error_not_a_stall(monkeypatch):
|
|
def hang(cmd, deadline=a.UPDATES_DEADLINE_SECONDS):
|
|
raise subprocess.TimeoutExpired(cmd, deadline)
|
|
|
|
monkeypatch.setattr(a, "_run", hang)
|
|
assert "didn't answer" in a.collect_updates()["error"]
|
|
|
|
|
|
def test_the_check_runs_in_the_background_once_an_hour(monkeypatch):
|
|
started, release = threading.Event(), threading.Event()
|
|
|
|
def slow():
|
|
started.set()
|
|
release.wait(5)
|
|
return {"manager": "apt", "pending": 1, "security": 0, "checked_at": "x"}
|
|
|
|
monkeypatch.setattr(a, "collect_updates", slow)
|
|
state: dict = {}
|
|
a.refresh_updates(state, now_mono=1000.0)
|
|
assert started.wait(2)
|
|
a.refresh_updates(state, now_mono=1001.0) # still running: not started twice
|
|
release.set()
|
|
for _ in range(50):
|
|
if not state.get("updates_running"):
|
|
break
|
|
time.sleep(0.02)
|
|
assert state["updates"]["pending"] == 1
|
|
|
|
monkeypatch.setattr(a, "collect_updates", lambda: {"pending": 2})
|
|
a.refresh_updates(state, now_mono=1000.0 + 600) # inside the hour: no new check
|
|
assert state["updates"]["pending"] == 1
|
|
state["updates_due"] = True # asked for now: checked now
|
|
a.refresh_updates(state, now_mono=1000.0 + 601)
|
|
for _ in range(50):
|
|
if state["updates"].get("pending") == 2:
|
|
break
|
|
time.sleep(0.02)
|
|
assert state["updates"]["pending"] == 2
|
|
|
|
|
|
def test_a_reboot_is_required_when_debian_says_so(tmp_path):
|
|
marker = tmp_path / "reboot-required"
|
|
marker.write_text("*** System restart required ***\n")
|
|
(tmp_path / "reboot-required.pkgs").write_text("linux-image-6.8.0-146-generic\nlibc6\nlibc6\n")
|
|
os.utime(marker, (1792000000, 1792000000))
|
|
got = a.collect_reboot(str(marker))
|
|
assert got["required"] is True
|
|
assert got["packages"] == ["libc6", "linux-image-6.8.0-146-generic"]
|
|
assert got["since"].startswith("2026-10-14")
|