bvandeusenandClaude Opus 5.5
eea29123f9
The UniFi password sat in plugin.unifi in plain text: SECRET_KEYS covers whole settings, and a plugin's settings are one dict. Saving the plugin's settings page also wiped it, since the password box is never filled back in and its blank value was stored. - A plugin field whose name holds password, secret or token is a credential (is_plugin_secret). set_setting seals it inside the dict, every read opens it, startup seals any plaintext left from before, and the undecryptable-secrets banner names it as plugin.<name>.<field>. - The settings page uses the same test for its password boxes, and a blank box keeps the saved value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
128 lines
6.8 KiB
HTML
128 lines
6.8 KiB
HTML
{# steward/templates/settings/plugin_detail.html #}
|
|
{% extends "base.html" %}
|
|
{% from "_macros.html" import crumbs %}
|
|
{% block title %}{{ plugin.get('name', plugin._dir) }} Settings — Steward{% endblock %}
|
|
{% from "settings/_tabs.html" import settings_tabs %}
|
|
{% block section_tabs %}{{ settings_tabs("plugins") }}{% endblock %}
|
|
{% block breadcrumb %}{{ crumbs([("Settings", "/settings/"), ("Plugins", "/settings/plugins/"), (plugin.get('name', plugin._dir), "")]) }}{% endblock %}
|
|
{% block content %}
|
|
|
|
<div style="display:flex;align-items:center;gap:1rem;margin-bottom:1.5rem;">
|
|
<h1 class="page-title" style="margin-bottom:0;">{{ plugin.get('name', plugin._dir) }}</h1>
|
|
<span style="color:var(--text-muted);font-size:0.82rem;">v{{ plugin.get('version', '?') }}</span>
|
|
{% if fail_reason %}
|
|
<span style="font-size:0.75rem;padding:0.15em 0.55em;border-radius:3px;
|
|
background:color-mix(in srgb,var(--red) 15%,var(--bg));color:var(--red);">Error</span>
|
|
{% elif is_loaded %}
|
|
<span style="font-size:0.75rem;padding:0.15em 0.55em;border-radius:3px;
|
|
background:color-mix(in srgb,var(--green) 12%,var(--bg));color:var(--green);">Loaded</span>
|
|
{% elif plugin._enabled %}
|
|
<span style="font-size:0.75rem;padding:0.15em 0.55em;border-radius:3px;
|
|
background:var(--bg-elevated);color:var(--text-muted);">Enabled, not loaded</span>
|
|
{% else %}
|
|
<span style="font-size:0.75rem;padding:0.15em 0.55em;border-radius:3px;
|
|
background:var(--bg-elevated);color:var(--text-muted);">Disabled</span>
|
|
{% endif %}
|
|
</div>
|
|
|
|
{% if fail_reason %}
|
|
<div style="display:flex;align-items:flex-start;gap:0.5rem;padding:0.6rem 0.9rem;margin-bottom:1rem;
|
|
background:color-mix(in srgb,var(--red) 10%,var(--bg));
|
|
border:1px solid color-mix(in srgb,var(--red) 30%,var(--border));
|
|
border-radius:6px;font-size:0.84rem;max-width:720px;">
|
|
<span style="color:var(--red);flex-shrink:0;">✕</span>
|
|
<span><strong style="color:var(--red);">Failed to load</strong>
|
|
<span style="color:var(--text-muted);margin-left:0.3rem;">— {{ fail_reason }}</span>
|
|
</span>
|
|
</div>
|
|
{% endif %}
|
|
|
|
{% if plugin.get('description') %}
|
|
<p style="color:var(--text-muted);font-size:0.88rem;margin-bottom:1.25rem;max-width:620px;">{{ plugin.description }}</p>
|
|
{% endif %}
|
|
|
|
<form method="post" action="/settings/plugins/{{ plugin._dir }}/" style="max-width:720px;">{{ csrf_field() }}
|
|
|
|
{# ── Enable toggle ────────────────────────────────────────────────────────── #}
|
|
<div class="card" style="padding:1rem 1.25rem;margin-bottom:1rem;">
|
|
<div style="display:flex;align-items:center;gap:0.75rem;">
|
|
<input type="checkbox"
|
|
name="plugin.{{ plugin._dir }}.enabled"
|
|
id="plugin-{{ plugin._dir }}-enabled"
|
|
{% if plugin._enabled %}checked{% endif %}>
|
|
<label for="plugin-{{ plugin._dir }}-enabled" style="margin:0;font-weight:500;cursor:pointer;">
|
|
Enable this plugin
|
|
</label>
|
|
</div>
|
|
<div style="font-size:0.8rem;color:var(--text-muted);margin-top:0.4rem;margin-left:1.6rem;">
|
|
Enabling loads the plugin straight away. Disabling takes effect after a restart.
|
|
</div>
|
|
</div>
|
|
|
|
{# ── Config fields ─────────────────────────────────────────────────────────── #}
|
|
{% if plugin.get('config') %}
|
|
<div class="card" style="padding:1.25rem;margin-bottom:1rem;">
|
|
<div class="section-title" style="margin-bottom:1rem;">Configuration</div>
|
|
<div style="display:grid;gap:0.75rem;">
|
|
|
|
{% for cfg_key, cfg_default in plugin.config.items() %}
|
|
|
|
{% if cfg_default is mapping %}
|
|
<div style="padding:0.75rem;background:var(--bg);border-radius:5px;border:1px solid var(--border);">
|
|
<div style="font-size:0.74rem;color:var(--text-muted);text-transform:uppercase;
|
|
letter-spacing:0.05em;margin-bottom:0.6rem;">{{ field_label(cfg_key) }}</div>
|
|
{% set sub_cfg = plugin._config.get(cfg_key, cfg_default) if plugin._config.get(cfg_key, cfg_default) is mapping else cfg_default %}
|
|
<div style="display:grid;gap:0.5rem;">
|
|
{% for sub_key, sub_default in cfg_default.items() %}
|
|
{% if sub_default is sameas false or sub_default is sameas true %}
|
|
<div style="display:flex;align-items:center;gap:0.5rem;">
|
|
<input type="checkbox"
|
|
name="plugin.{{ plugin._dir }}.{{ cfg_key }}.{{ sub_key }}"
|
|
id="plugin-{{ plugin._dir }}-{{ cfg_key }}-{{ sub_key }}"
|
|
{% if sub_cfg.get(sub_key, sub_default) %}checked{% endif %}>
|
|
<label for="plugin-{{ plugin._dir }}-{{ cfg_key }}-{{ sub_key }}"
|
|
style="margin:0;font-size:0.85rem;color:var(--text);">{{ field_label(sub_key) }}</label>
|
|
</div>
|
|
{% else %}
|
|
<div class="form-group" style="margin:0;">
|
|
<label style="font-size:0.82rem;">{{ field_label(sub_key) }}</label>
|
|
<input type="text"
|
|
name="plugin.{{ plugin._dir }}.{{ cfg_key }}.{{ sub_key }}"
|
|
value="{{ sub_cfg.get(sub_key, sub_default) }}">
|
|
</div>
|
|
{% endif %}
|
|
{% endfor %}
|
|
</div>
|
|
</div>
|
|
|
|
{% elif cfg_default is sameas false or cfg_default is sameas true %}
|
|
<div style="display:flex;align-items:center;gap:0.5rem;">
|
|
<input type="checkbox"
|
|
name="plugin.{{ plugin._dir }}.{{ cfg_key }}"
|
|
id="plugin-{{ plugin._dir }}-{{ cfg_key }}"
|
|
{% if plugin._config.get(cfg_key, cfg_default) %}checked{% endif %}>
|
|
<label for="plugin-{{ plugin._dir }}-{{ cfg_key }}"
|
|
style="margin:0;font-size:0.85rem;color:var(--text);">{{ field_label(cfg_key) }}</label>
|
|
</div>
|
|
|
|
{% else %}
|
|
<div class="form-group" style="margin:0;">
|
|
<label style="font-size:0.82rem;">{{ field_label(cfg_key) }}</label>
|
|
{% set secret = is_plugin_secret(cfg_key) %}
|
|
<input type="{% if secret %}password{% else %}text{% endif %}"
|
|
name="plugin.{{ plugin._dir }}.{{ cfg_key }}"
|
|
value="{% if secret %}{% else %}{{ plugin._config.get(cfg_key, cfg_default) }}{% endif %}"
|
|
{% if secret %}autocomplete="new-password" placeholder="{{ 'kept; type to change' if plugin._config.get(cfg_key) else 'none saved' }}"{% endif %}>
|
|
</div>
|
|
{% endif %}
|
|
|
|
{% endfor %}
|
|
</div>
|
|
</div>
|
|
{% endif %}
|
|
|
|
<button type="submit" class="btn">Save</button>
|
|
|
|
</form>
|
|
{% endblock %}
|