bvandeusenandClaude Opus 5.5
49607a2441
Notifications and alert actions now start only once the evaluating
transaction commits, and never for one that rolls back. record_metrics
queues them on the session (_after_commit), and after_commit/after_rollback
listeners on the sync session spawn or drop them. Spawned tasks are held in a
module set so they cannot be garbage-collected before they run.
A maintenance window no longer skips evaluation. Alerts in its scope still
change state, but their notifications and actions are held, and each event
says so ("notification muted: maintenance window <name>"; also on no-data
and resume events). notify_after_maintenance, run every minute with the
silence check as the new core task alert_reconcile, sends one notification
for an alert still firing after its window ends and runs its action. The
event's note records the release.
Alert actions go through runner.trigger_run like every other run path, so
the playbook and the inventory must be ones the source lists (#5034 guards).
The firing event links to the run, or its note says why the action did not
start. The maintenance page and form wording now say what a window does.
Tests:
- integration: a rolled-back evaluation notifies nobody, and dispatch waits
for the commit; maintenance mutes while the state moves and notifies once
when the window ends; an action whose playbook is outside its source is
refused, with the note set;
- the alert-action test uses a listed inventory name and waits, with a
deadline, for the run the action starts;
- unit: _muted_by.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
79 lines
3.0 KiB
HTML
79 lines
3.0 KiB
HTML
{% extends "base.html" %}
|
|
{% from "_macros.html" import crumbs %}
|
|
{% block title %}Maintenance Windows — Steward{% endblock %}
|
|
{% block breadcrumb %}{{ crumbs([("Alerts", "/alerts/"), ("Maintenance", "")]) }}{% endblock %}
|
|
{% block content %}
|
|
<div style="display:flex;align-items:center;justify-content:space-between;margin-bottom:1.5rem;">
|
|
<h1 class="page-title" style="margin-bottom:0;">Maintenance Windows</h1>
|
|
<div style="display:flex;gap:0.5rem;">
|
|
<a class="btn" href="/alerts/maintenance/new">New Window</a>
|
|
</div>
|
|
</div>
|
|
|
|
<p style="color:var(--text-muted);font-size:0.88rem;margin-bottom:1.5rem;">
|
|
During an active window, alerts in its scope still change state and show on the Alerts page,
|
|
but send no notifications and run no Ansible actions. Each event a window mutes says so in
|
|
the alert's history. An alert that is still firing when the window ends notifies then, and runs its action.
|
|
</p>
|
|
|
|
{% if windows %}
|
|
<div class="card-flush">
|
|
<table class="table">
|
|
<thead>
|
|
<tr>
|
|
<th>Name</th>
|
|
<th>Scope</th>
|
|
<th>Start</th>
|
|
<th>End</th>
|
|
<th style="text-align:center;">Status</th>
|
|
<th></th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{% for w in windows %}
|
|
{% set is_active = w.start_at <= now and w.end_at >= now %}
|
|
{% set is_upcoming = w.start_at > now %}
|
|
<tr>
|
|
<td style="font-weight:500;">{{ w.name }}</td>
|
|
<td style="font-size:0.85rem;color:var(--text-muted);">
|
|
{% if w.scope_source is none %}
|
|
<span title="All alert rules">All alerts</span>
|
|
{% elif w.scope_resource is none %}
|
|
<span>{{ w.scope_source }}/*</span>
|
|
{% else %}
|
|
<span>{{ w.scope_source }}/{{ w.scope_resource }}</span>
|
|
{% endif %}
|
|
</td>
|
|
<td style="font-size:0.85rem;font-family:ui-monospace,monospace;">
|
|
{{ w.start_at.strftime("%Y-%m-%d %H:%M") }} UTC
|
|
</td>
|
|
<td style="font-size:0.85rem;font-family:ui-monospace,monospace;">
|
|
{{ w.end_at.strftime("%Y-%m-%d %H:%M") }} UTC
|
|
</td>
|
|
<td style="text-align:center;">
|
|
{% if is_active %}
|
|
<span class="badge badge-yellow">active</span>
|
|
{% elif is_upcoming %}
|
|
<span class="badge badge-dim">upcoming</span>
|
|
{% else %}
|
|
<span style="color:var(--text-dim);font-size:0.8rem;">expired</span>
|
|
{% endif %}
|
|
</td>
|
|
<td class="td-actions">
|
|
<form method="post" action="/alerts/maintenance/{{ w.id }}/delete" style="display:inline;">{{ csrf_field() }}
|
|
<button type="submit" class="btn btn-sm btn-danger"
|
|
onclick="return confirm('Delete window "{{ w.name }}"?')">Delete</button>
|
|
</form>
|
|
</td>
|
|
</tr>
|
|
{% endfor %}
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
{% else %}
|
|
<div class="card" style="text-align:center;padding:3rem;">
|
|
<p style="color:var(--text-muted);">No maintenance windows configured.</p>
|
|
</div>
|
|
{% endif %}
|
|
{% endblock %}
|