bvandeusenandClaude Opus 5.5
bfe3618e88
Hosts list: - CPU and Memory are their own labelled columns (#5279); a silent agent's last readings are greyed, and Status says "agent silent for 7m". - One uptime figure, 30 days, with 24h and 7d on hover. The SLA tab (/hosts/uptime) repeated it and is removed (#5280; one home per fact). - Status is a word with how long ("Down for 12m"); host_status now carries down_since. Edit and Delete live on the host's page only (#5281). - Figures are right-aligned with tabular digits (.table .num), not a monospace face. Agent fleet (#5282): its add-host form is gone, so hosts are added only on Hosts -> Add host. That form was also the only way to get a token for a manual curl install, so that moves to the host's Agent card as "Install manually" (POST /fleet/<host_id>/register), shown on the fleet page as before. "Delete" there reads "Unregister". Add host (#5283): laid out like the add-monitor form; a name clash comes back inline with what was typed instead of a bare text 400; the address is optional, as the host page already allowed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
47 lines
2.3 KiB
Python
47 lines
2.3 KiB
Python
"""Lists put what needs looking at first (#5210): hosts by their worst
|
|
signal, schedules failing first, maintenance windows active then upcoming."""
|
|
from types import SimpleNamespace as NS
|
|
|
|
from steward.ansible.routes import _schedule_order
|
|
from steward.hosts.service import host_rank
|
|
|
|
|
|
def test_hosts_sort_down_then_quiet_agent_then_pending_then_healthy():
|
|
down, up, pending = {"state": "down"}, {"state": "up"}, {"state": "pending"}
|
|
fresh, quiet = {"fresh": True}, {"fresh": False}
|
|
assert host_rank(down, fresh) == 0
|
|
assert host_rank(up, quiet) == 1 # monitors fine, but the agent went silent
|
|
assert host_rank(None, quiet) == 1
|
|
assert host_rank(pending, fresh) == 2
|
|
assert host_rank(up, fresh) == 3 and host_rank(None, fresh) == 3
|
|
assert host_rank(None, None) == 4 # nothing watches it
|
|
|
|
|
|
def _sched(name, *, enabled=True, last_error=None, status=None):
|
|
run = NS(status=NS(value=status)) if status else None
|
|
return {"s": NS(name=name, enabled=enabled, last_error=last_error), "last_run": run}
|
|
|
|
|
|
def test_schedules_sort_failing_first_and_paused_last():
|
|
rows = [_sched("nightly", status="success"), _sched("paused", enabled=False, status="failed"),
|
|
_sched("backup", status="failed"), _sched("deploy", status="running"),
|
|
_sched("broken", last_error="source not found"), _sched("cut", status="interrupted"),
|
|
_sched("busy", last_error="the last run is still going", status="success")]
|
|
assert [r["s"].name for r in sorted(rows, key=_schedule_order)] == [
|
|
"backup", "broken", "cut", "deploy", "busy", "nightly", "paused"]
|
|
|
|
|
|
def test_a_host_page_shows_only_the_alerts_on_that_host():
|
|
from steward.alerts.service import watches_host
|
|
|
|
def rule(source, resource):
|
|
return NS(source_module=source, resource_name=resource)
|
|
mine = {("http", "nas web")}
|
|
assert watches_host(rule("host_agent", "nas"), "nas", mine)
|
|
assert watches_host(rule("host_agent", "nas:/"), "nas", mine)
|
|
assert not watches_host(rule("host_agent", "nas2"), "nas", mine) # a name that merely starts alike
|
|
assert watches_host(rule("docker", "nas/plex"), "nas", mine)
|
|
assert not watches_host(rule("docker", "nas2/plex"), "nas", mine)
|
|
assert watches_host(rule("http", "nas web"), "nas", mine)
|
|
assert not watches_host(rule("http", "other web"), "nas", mine)
|