bvandeusenandClaude Opus 5.5
8e890c6914
#5210 "Problems first, with since-time, across every list" (milestone 477), second batch. - Host page: an "Alerts on this host" strip first (rules on its agent series, its containers or its monitors: alert_svc.watches_host); its monitors problems first with "Down 12m · reason"; Docker above Ansible. - Uptime page and widget: worst 24h uptime first, then 7d and 30d; hosts with no uptime yet last. - Agent panel and fleet widget: last seen as "3m ago", not a clock time. - SNMP: a device is "Reachable" only while it answered within the last 3 polls; older readings say "No answer" with their age, and every device says when it was last read (was: reachable whenever any reading existed). - Traefik: a router missing from 3 scrapes in a row is listed apart as no longer reported, by when it was last seen, instead of keeping its last state (a removed router stayed Failing). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
40 lines
2.3 KiB
Python
40 lines
2.3 KiB
Python
"""The SNMP list says each device's state with the shared badge and shows its
|
|
readings as stat tiles (#5126)."""
|
|
from datetime import datetime, timedelta, timezone
|
|
|
|
from plugins.snmp.routes import _device_state
|
|
from tests._templates import render_plugin_template
|
|
from tests.test_style_tokens import hex_colours
|
|
|
|
|
|
async def test_devices_wear_a_status_badge_and_readings_are_tiles(app):
|
|
devices = [
|
|
{"name": "ups", "host": "10.0.0.9", "oids": [{"oid": "1.3.6", "label": "battery_charge_pct"},
|
|
{"oid": "1.3.7", "label": "in_octets"}],
|
|
"readings": {"battery_charge_pct": 97.0, "in_octets": 2_500_000.0}, "reach": "up",
|
|
"at": datetime.now(timezone.utc) - timedelta(seconds=30)},
|
|
{"name": "switch", "host": "10.0.0.11", "oids": [], "readings": {"x": 1.0}, "reach": "stale",
|
|
"at": datetime.now(timezone.utc) - timedelta(hours=3)},
|
|
{"name": "printer", "host": "10.0.0.10", "oids": [], "readings": {}, "reach": "pending", "at": None},
|
|
]
|
|
async with app.test_request_context("/plugins/snmp/"):
|
|
page = await render_plugin_template(app, "snmp", "snmp/index.html", devices=devices, poll_interval=60)
|
|
|
|
assert '<span class="badge badge-ok">Reachable</span>' in page
|
|
assert '<span class="badge badge-warn">No data yet</span>' in page
|
|
# Old readings are not "reachable": they say how old they are (#5210).
|
|
assert 'badge badge-warn" title="The last reading is from' in page and ">No answer</span>" in page
|
|
assert ">3h ago</time>" in page
|
|
assert '<span class="stat-tile-value">97</span>' in page and '<span class="stat-tile-value">2.50M</span>' in page
|
|
assert 'href="/plugins/snmp/device/ups"' in page
|
|
main = page[page.index("<main"):]
|
|
assert "font-weight:600" not in main and not hex_colours(main), hex_colours(main)
|
|
|
|
|
|
def test_a_device_is_reachable_only_while_its_readings_are_recent():
|
|
now = datetime.now(timezone.utc)
|
|
entry = {"readings": {"x": 1.0}, "at": now - timedelta(seconds=150)}
|
|
assert _device_state(entry, 60, now)["reach"] == "up" # within 3 polls
|
|
assert _device_state(entry, 30, now)["reach"] == "stale" # 5 polls without an answer
|
|
assert _device_state(None, 60, now) == {"readings": {}, "at": None, "reach": "pending"}
|