feat(ansible): ship ansible in image + allow system-triggered runs (task 545)
CI / lint (push) Successful in 4s
CI / unit (push) Successful in 9s
CI / integration (push) Failing after 2m22s

Foundation for the Ansible automation milestone (#37) — makes the existing
manual playbook runner actually executable and the schema automation-ready.

- pyproject: [ansible] extra (full ansible package, batteries-included, pinned)
- Dockerfile: pip install .[ansible]; add openssh-client for remote runs
- models/ansible.py + migration 0012: AnsibleRun.triggered_by now nullable so
  automated (alert/schedule) runs need no human actor
- ansible/routes.py + run_detail.html: show 'Triggered by' (username or 'system')
- CI: integration lane installs .[dev,ansible]; new tests/integration/
  test_ansible_foundation.py runs a real connection:local playbook end-to-end,
  asserts success+output, and round-trips a NULL-triggered run

No extra-vars/limit/credentials/scheduling here — those are their own #37 tasks.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-06-02 11:31:43 -04:00
parent ccc7601182
commit fb579bcf97
8 changed files with 159 additions and 9 deletions
@@ -0,0 +1,101 @@
"""Integration: the Ansible foundation (task 545).
Proves the two foundation pieces against a live Postgres + a real ansible install:
1. ansible-playbook is on PATH (ships in the image / [ansible] extra).
2. executor.start_run actually runs a trivial connection:local playbook end to
end and records success + output on the AnsibleRun row.
3. An AnsibleRun with triggered_by=NULL inserts and round-trips (migration 0012).
Requires STEWARD_DATABASE_URL (the integration CI lane provides it). A fresh app
is built per test so each test's async work runs on its own event loop with its
own engine (create_app's internal asyncio.run can't be nested under a running
loop, so these tests are sync and drive async work via asyncio.run).
"""
from __future__ import annotations
import asyncio
import os
import shutil
import textwrap
import uuid
import pytest
pytestmark = pytest.mark.integration
_NEEDS_DB = pytest.mark.skipif(
not os.environ.get("STEWARD_DATABASE_URL"),
reason="integration test needs a live Postgres (STEWARD_DATABASE_URL)",
)
@pytest.fixture
def app():
if not os.environ.get("STEWARD_DATABASE_URL"):
pytest.skip("needs Postgres")
from steward.app import create_app
# testing=False → runs all migrations (incl. 0012) and gives a real engine.
return create_app(testing=False)
def test_ansible_playbook_on_path():
assert shutil.which("ansible-playbook") is not None
@_NEEDS_DB
def test_null_triggered_run_inserts(app):
from sqlalchemy import select
from steward.models.ansible import AnsibleRun, AnsibleRunStatus
run_id = str(uuid.uuid4())
async def _go():
async with app.db_sessionmaker() as s:
async with s.begin():
s.add(AnsibleRun(
id=run_id, playbook_path="p.yml", inventory_path="i.ini",
source_name="t", triggered_by=None,
status=AnsibleRunStatus.success,
))
async with app.db_sessionmaker() as s:
row = (await s.execute(
select(AnsibleRun).where(AnsibleRun.id == run_id))).scalar_one()
return row.triggered_by
assert asyncio.run(_go()) is None
@_NEEDS_DB
def test_executor_runs_local_playbook(app, tmp_path):
from sqlalchemy import select
from steward.ansible import executor
from steward.models.ansible import AnsibleRun, AnsibleRunStatus
(tmp_path / "test.yml").write_text(textwrap.dedent("""\
- hosts: localhost
connection: local
gather_facts: false
tasks:
- debug:
msg: STEWARD_ANSIBLE_OK
"""))
(tmp_path / "inv.ini").write_text("localhost ansible_connection=local\n")
run_id = str(uuid.uuid4())
async def _go():
async with app.db_sessionmaker() as s:
async with s.begin():
s.add(AnsibleRun(
id=run_id, playbook_path="test.yml", inventory_path="inv.ini",
source_name="t", triggered_by=None,
status=AnsibleRunStatus.running,
))
await executor.start_run(app, run_id, "test.yml", "inv.ini", str(tmp_path))
async with app.db_sessionmaker() as s:
return (await s.execute(
select(AnsibleRun).where(AnsibleRun.id == run_id))).scalar_one()
run = asyncio.run(_go())
assert run.status == AnsibleRunStatus.success, run.output
assert "STEWARD_ANSIBLE_OK" in (run.output or "")