feat(docker): a swarm service's metrics stay under one key across its tasks (#6718)
#6718 "A swarm container's metrics, normal and anomalies are keyed by its task name, so they start over whenever the task moves". The operator: "the metrics should be keys to the service name not the task name... as that's what's consistent between updates." CPU, memory, restart count and health now go under "swarm/<service>", so a normal, its anomalies and an alert rule carry across a redeploy or a move between nodes. Network rates stay "<host>/<service>", the task id gone, as they answer who on a host is sending. Tasks of a multi-task service share the key, so its level reads as an average across them (of 51 live services, only authentik-worker and portainer_agent run more than one task). History under task names moves in a background task, 5000 raw samples every 15 s, not a migration: the raw table holds about 2M such rows and the app would wait on it at boot. Hourly rows combine where two tasks share an hour, and rows still to review merge to one per metric. A service's anomalies no longer reach a host's page, as it has no one host; get_anomaly reads what happened around one from the service's own events. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -73,12 +73,12 @@ _MONITOR_SOURCES = ("icmp", "tcp", "dns", "http")
|
||||
async def hosts_of_rule(session, source: str, resource: str) -> list[str]:
|
||||
"""The host an alert rule's resource is on, by name, when it has one: an
|
||||
agent series ("<host>" or "<host>:<part>"), a container ("<host>/<name>")
|
||||
or a monitor tied to a host."""
|
||||
or a monitor tied to a host. A swarm service ("swarm/<service>") has none."""
|
||||
from steward.core.alerts import host_of_resource
|
||||
if source == "host_agent":
|
||||
return [host_of_resource(source, resource) or resource.split(":", 1)[0]]
|
||||
if source == "docker":
|
||||
return [resource.split("/", 1)[0]]
|
||||
return [] if resource.startswith("swarm/") else [resource.split("/", 1)[0]]
|
||||
if source in _MONITOR_SOURCES:
|
||||
from steward.models.hosts import Host
|
||||
from steward.models.monitors import Monitor
|
||||
|
||||
Reference in New Issue
Block a user