fix(plugins): complete steward rename across bundled plugins; clear lint debt

The fabledscryer->steward rename had only ever reached host_agent. The other
five bundled plugins (http, snmp, traefik, unifi, docker) still imported
`from fabledscryer.*` (package no longer exists) and read FABLEDSCRYER_* env
vars — so every one of them was broken at import since the original rebrand.
CI stayed green only because none are enabled by default and migrations don't
import plugin modules. Now that they version in-tree, complete the rename:
- fabledscryer.* -> steward.* imports across all five plugins
- FABLEDSCRYER_* -> STEWARD_* in plugin migration env.py files
- author/repository/homepage + user-facing 'Fabled Scryer' strings -> Steward
- snmp/scheduler.py: also drop dead `now`/datetime; record_metric from steward

Adds tests/test_no_legacy_names.py — fails if 'scryer'/'roundtable' ever
reappear in shipped code (the drift bit twice; this stops a third time).

Also clears pre-existing ruff lint debt (unused imports, semicolon statements,
mid-file import) surfaced by the new lint lane.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

steward/ansible/routes.py

@@ -3,13 +3,12 @@ from __future__ import annotations
 import asyncio
 import uuid
 from datetime import datetime, timezone
-from pathlib import Path
 
 from quart import (
-    Blueprint, Response, current_app, redirect, render_template,
-    request, session, url_for,
+    Blueprint, Response, current_app, render_template,
+    request, session,
 )
-from sqlalchemy import select, update
+from sqlalchemy import select
 
 from steward.ansible import executor, sources as src_module
 from steward.auth.middleware import require_role

steward/auth/oidc.py

@@ -8,7 +8,6 @@ we trust the HTTPS connection to the discovery-documented token/userinfo endpoin
 """
 from __future__ import annotations
 import base64
-import hashlib
 import json
 import logging
 import os

steward/core/plugin_manager.py

@@ -1,7 +1,6 @@
 # steward/core/plugin_manager.py
 from __future__ import annotations
 import hashlib
-import importlib
 import logging
 import os
 import sys

steward/core/reports.py

@@ -6,8 +6,6 @@ Called by the scheduler (hourly check) or triggered manually from Settings.
 from __future__ import annotations
 import asyncio
 import logging
-import smtplib
-import ssl
 from datetime import datetime, timedelta, timezone
 from email.message import EmailMessage
 

steward/migrations/env.py

@@ -15,7 +15,8 @@ target_metadata = Base.metadata
 
 
 def get_url() -> str:
-    import os, yaml
+    import os
+    import yaml
 
     def _env(suffix: str) -> str | None:
         return os.environ.get(f"STEWARD_{suffix}")

steward/settings/routes.py

@@ -1,6 +1,5 @@
 # steward/settings/routes.py
 from __future__ import annotations
-import json
 import logging
 from pathlib import Path
 from quart import Blueprint, current_app, render_template, request, redirect, url_for, session
@@ -9,7 +8,7 @@ from steward.auth.middleware import require_role
 from steward.core.audit import log_audit
 from steward.models.users import UserRole
 from steward.core.settings import (
-    DEFAULTS, get_all_settings, set_setting,
+    get_all_settings, set_setting,
     to_smtp_cfg, to_webhook_cfg, to_ansible_cfg, to_plugins_cfg,
     to_oidc_cfg, to_ldap_cfg,
 )

steward/templates/settings/auth.html

@@ -144,12 +144,12 @@
       <div class="form-group">
         <label>Admin group DN</label>
         <input type="text" name="ldap.admin_group_dn" value="{{ settings['ldap.admin_group_dn'] }}"
-               placeholder="cn=scryer-admins,ou=groups,dc=example,dc=com">
+               placeholder="cn=steward-admins,ou=groups,dc=example,dc=com">
       </div>
       <div class="form-group">
         <label>Operator group DN</label>
         <input type="text" name="ldap.operator_group_dn" value="{{ settings['ldap.operator_group_dn'] }}"
-               placeholder="cn=scryer-operators,ou=groups,dc=example,dc=com">
+               placeholder="cn=steward-operators,ou=groups,dc=example,dc=com">
       </div>
     </div>
 

steward/templates/settings/plugins.html

@@ -81,7 +81,7 @@
 <div style="margin-bottom:2rem;max-width:720px;">
   <div class="section-title" style="margin-bottom:0.75rem;">Plugin Repositories</div>
   <p style="color:var(--text-muted);font-size:0.84rem;margin-bottom:0.75rem;">
-    Repositories are remote <code>index.yaml</code> files that Scryer checks for available
+    Repositories are remote <code>index.yaml</code> files that Steward checks for available
     and updated plugins. Add repos from other developers to expand the plugin catalog.
   </p>
   {% include "settings/_plugin_repos.html" %}