fix(plugins): complete steward rename across bundled plugins; clear lint debt

The fabledscryer->steward rename had only ever reached host_agent. The other
five bundled plugins (http, snmp, traefik, unifi, docker) still imported
`from fabledscryer.*` (package no longer exists) and read FABLEDSCRYER_* env
vars — so every one of them was broken at import since the original rebrand.
CI stayed green only because none are enabled by default and migrations don't
import plugin modules. Now that they version in-tree, complete the rename:
- fabledscryer.* -> steward.* imports across all five plugins
- FABLEDSCRYER_* -> STEWARD_* in plugin migration env.py files
- author/repository/homepage + user-facing 'Fabled Scryer' strings -> Steward
- snmp/scheduler.py: also drop dead `now`/datetime; record_metric from steward

Adds tests/test_no_legacy_names.py — fails if 'scryer'/'roundtable' ever
reappear in shipped code (the drift bit twice; this stops a third time).

Also clears pre-existing ruff lint debt (unused imports, semicolon statements,
mid-file import) surfaced by the new lint lane.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

plugins/snmp/plugin.yaml

@@ -2,11 +2,11 @@
 name: snmp
 version: "1.0.0"
 description: "SNMP polling for network devices — switches, routers, printers, UPSes, etc."
-author: "FabledScryer"
+author: "Steward"
 license: "MIT"
 min_app_version: "0.1.0"
-repository_url: "https://git.fabledsword.com/bvandeusen/FabledScryer-plugins"
-homepage: "https://git.fabledsword.com/bvandeusen/FabledScryer-plugins/src/branch/main/snmp"
+repository_url: "https://git.fabledsword.com/bvandeusen/Steward-plugins"
+homepage: "https://git.fabledsword.com/bvandeusen/Steward-plugins/src/branch/main/snmp"
 tags:
   - snmp
   - network

plugins/snmp/poller.py

@@ -3,7 +3,7 @@
 Synchronous SNMP GET helper, run via executor.
 
 Requires pysnmp-lextudio (maintained pysnmp fork):
-    pip install 'fabledscryer[snmp]'
+    pip install 'steward[snmp]'
 
 If pysnmp is not installed, poll_device() returns an empty dict and logs a warning.
 """
@@ -40,7 +40,7 @@ def poll_device_sync(
     """
     if not _pysnmp_available():
         logger.warning("pysnmp not installed — SNMP polling disabled. "
-                       "Install with: pip install 'fabledscryer[snmp]'")
+                       "Install with: pip install 'steward[snmp]'")
         return {}
 
     from pysnmp.hlapi import (

plugins/snmp/routes.py

@@ -5,9 +5,9 @@ from datetime import datetime, timedelta, timezone
 from quart import Blueprint, current_app, render_template, request
 from sqlalchemy import func, select
 
-from fabledscryer.auth.middleware import require_role
-from fabledscryer.models.users import UserRole
-from fabledscryer.models.metrics import PluginMetric
+from steward.auth.middleware import require_role
+from steward.models.users import UserRole
+from steward.models.metrics import PluginMetric
 
 snmp_bp = Blueprint("snmp", __name__, template_folder="templates")
 

plugins/snmp/scheduler.py

@@ -7,7 +7,7 @@ from typing import TYPE_CHECKING
 if TYPE_CHECKING:
     from quart import Quart
 
-from fabledscryer.core.scheduler import ScheduledTask
+from steward.core.scheduler import ScheduledTask
 
 logger = logging.getLogger(__name__)
 
@@ -27,16 +27,14 @@ def make_poll_task(app: "Quart") -> ScheduledTask:
 
 
 async def _do_poll(app: "Quart") -> None:
-    from datetime import datetime, timezone
     from .poller import poll_device_sync
-    from fabledscryer.core.alerts import record_metric
+    from steward.core.alerts import record_metric
 
     devices: list[dict] = app.config["PLUGINS"]["snmp"].get("devices", [])
     if not devices:
         return
 
     loop = asyncio.get_event_loop()
-    now = datetime.now(timezone.utc)
 
     async with app.db_sessionmaker() as session:
         async with session.begin():

plugins/snmp/templates/snmp/device.html

@@ -1,6 +1,6 @@
 {# plugins/snmp/templates/snmp/device.html #}
 {% extends "base.html" %}
-{% block title %}SNMP — {{ device_name }} — Fabled Scryer{% endblock %}
+{% block title %}SNMP — {{ device_name }} — Steward{% endblock %}
 {% block content %}
 <div style="display:flex;align-items:center;gap:1rem;margin-bottom:1.5rem;flex-wrap:wrap;">
   <a href="/plugins/snmp/" style="color:var(--text-muted);font-size:0.85rem;">&#8592; SNMP</a>

plugins/snmp/templates/snmp/index.html

@@ -1,6 +1,6 @@
 {# plugins/snmp/templates/snmp/index.html #}
 {% extends "base.html" %}
-{% block title %}SNMP — Fabled Scryer{% endblock %}
+{% block title %}SNMP — Steward{% endblock %}
 {% block content %}
 <div style="display:flex;align-items:center;gap:1rem;margin-bottom:1.5rem;">
   <h1 class="page-title" style="margin:0;">SNMP Devices</h1>