fix(plugins): complete steward rename across bundled plugins; clear lint debt

The fabledscryer->steward rename had only ever reached host_agent. The other
five bundled plugins (http, snmp, traefik, unifi, docker) still imported
`from fabledscryer.*` (package no longer exists) and read FABLEDSCRYER_* env
vars — so every one of them was broken at import since the original rebrand.
CI stayed green only because none are enabled by default and migrations don't
import plugin modules. Now that they version in-tree, complete the rename:
- fabledscryer.* -> steward.* imports across all five plugins
- FABLEDSCRYER_* -> STEWARD_* in plugin migration env.py files
- author/repository/homepage + user-facing 'Fabled Scryer' strings -> Steward
- snmp/scheduler.py: also drop dead `now`/datetime; record_metric from steward

Adds tests/test_no_legacy_names.py — fails if 'scryer'/'roundtable' ever
reappear in shipped code (the drift bit twice; this stops a third time).

Also clears pre-existing ruff lint debt (unused imports, semicolon statements,
mid-file import) surfaced by the new lint lane.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

plugins/docker/migrations/env.py

@@ -13,8 +13,8 @@ from alembic import context
 
 sys.path.insert(0, str(Path(__file__).parent.parent.parent.parent))
 
-from fabledscryer.models.base import Base
-import fabledscryer.models  # noqa: F401
+from steward.models.base import Base
+import steward.models  # noqa: F401
 from plugins.docker.models import DockerContainer, DockerMetric  # noqa: F401
 
 config = context.config
@@ -26,14 +26,14 @@ target_metadata = Base.metadata
 
 def _get_url() -> str:
     import yaml
-    cfg_path = os.environ.get("FABLEDSCRYER_CONFIG", "config.yaml")
+    cfg_path = os.environ.get("STEWARD_CONFIG", "config.yaml")
     try:
         with open(cfg_path) as f:
             cfg = yaml.safe_load(f) or {}
         url = cfg.get("database", {}).get("url", "")
     except FileNotFoundError:
         url = ""
-    return os.environ.get("FABLEDSCRYER_DATABASE__URL", url)
+    return os.environ.get("STEWARD_DATABASE__URL", url)
 
 
 def run_migrations_offline() -> None:

plugins/docker/models.py

@@ -4,7 +4,7 @@ import uuid
 from datetime import datetime, timezone
 from sqlalchemy import DateTime, Float, Integer, String, Text
 from sqlalchemy.orm import Mapped, mapped_column
-from fabledscryer.models.base import Base
+from steward.models.base import Base
 
 
 class DockerContainer(Base):

plugins/docker/plugin.yaml

@@ -1,11 +1,11 @@
 name: docker
 version: "1.0.0"
 description: "Docker container status, resource usage, restart tracking via Docker socket"
-author: "FabledScryer"
+author: "Steward"
 license: "MIT"
 min_app_version: "0.1.0"
-repository_url: "https://git.fabledsword.com/bvandeusen/FabledScryer-plugins"
-homepage: "https://git.fabledsword.com/bvandeusen/FabledScryer-plugins/src/branch/main/docker"
+repository_url: "https://git.fabledsword.com/bvandeusen/Steward-plugins"
+homepage: "https://git.fabledsword.com/bvandeusen/Steward-plugins/src/branch/main/docker"
 tags:
   - containers
   - docker

plugins/docker/routes.py

@@ -1,13 +1,12 @@
 # plugins/docker/routes.py
 from __future__ import annotations
 import json
-from datetime import datetime, timezone
 from quart import Blueprint, current_app, render_template, request
 from sqlalchemy import Integer, cast, func, select
 
-from fabledscryer.auth.middleware import require_role
-from fabledscryer.models.users import UserRole
-from fabledscryer.core.time_range import parse_range, DEFAULT_RANGE, bucket_seconds
+from steward.auth.middleware import require_role
+from steward.models.users import UserRole
+from steward.core.time_range import parse_range, DEFAULT_RANGE, bucket_seconds
 from .models import DockerContainer, DockerMetric
 
 docker_bp = Blueprint("docker", __name__, template_folder="templates")

plugins/docker/scheduler.py

@@ -4,8 +4,8 @@ import json
 import logging
 from datetime import datetime, timezone
 
-from fabledscryer.core.scheduler import ScheduledTask
-from fabledscryer.core.alerts import record_metric
+from steward.core.scheduler import ScheduledTask
+from steward.core.alerts import record_metric
 
 logger = logging.getLogger(__name__)
 

plugins/docker/scraper.py

@@ -106,7 +106,6 @@ async def scrape_docker(socket_path: str, include_stopped: bool) -> list[dict]:
         ) from exc
 
     results = []
-    now = datetime.now(timezone.utc)
     for container, stats in pairs:
         names = container.get("Names") or []
         name = names[0].lstrip("/") if names else _short_id(container.get("Id", ""))

plugins/docker/templates/docker/index.html

@@ -1,5 +1,5 @@
 {% extends "base.html" %}
-{% block title %}Docker — Fabled Scryer{% endblock %}
+{% block title %}Docker — Steward{% endblock %}
 {% block content %}
 <div style="display:flex;align-items:center;justify-content:space-between;margin-bottom:1.5rem;gap:1rem;flex-wrap:wrap;">
   <h1 class="page-title" style="margin-bottom:0;">Docker</h1>