From a775882bd4778db36877a09237e32ed4c14770f3 Mon Sep 17 00:00:00 2001
From: Bryan Van Deusen <bryan.vandeusen@fabledsword.com>
Date: Wed, 7 Oct 2026 20:11:46 -0400
Subject: [PATCH] test(docker): a plugin template can take its own name; the
 overview's assertions follow its new tables (#5299, #5302)

render_plugin_template's first three arguments are positional-only, so the
service page's own `name` reaches the template. The overview names a service
rather than its replica containers, and a stack chip keeps the search it was
clicked under.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 tests/_templates.py                           | 2 +-
 tests/integration/test_docker_service_page.py | 3 ++-
 tests/integration/test_mcp_plugin_tools.py    | 7 +++++--
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/tests/_templates.py b/tests/_templates.py
index ef1e173..035f8b8 100644
--- a/tests/_templates.py
+++ b/tests/_templates.py
@@ -16,7 +16,7 @@ def template_files() -> list[pathlib.Path]:
     return sorted(p for root in roots for p in root.rglob("*.html"))
 
 
-async def render_plugin_template(app, plugin: str, name: str, **ctx) -> str:
+async def render_plugin_template(app, plugin: str, name: str, /, **ctx) -> str:
     """Render plugins/<plugin>/templates/<name> with quart.render_template,
     whether or not the plugin is enabled in this app: the plugin's template
     folder goes ahead of the app's loader for the one render. Call inside
diff --git a/tests/integration/test_docker_service_page.py b/tests/integration/test_docker_service_page.py
index 079c59c..e3814a1 100644
--- a/tests/integration/test_docker_service_page.py
+++ b/tests/integration/test_docker_service_page.py
@@ -136,6 +136,7 @@ def test_a_service_page_reads_every_task(app):
 
     rows = got["rows"][1]
     assert f'href="/plugins/docker/service/{name}"' in rows
-    assert f'<a class="chip" href="/plugins/docker/?stack=it{tag}"' in rows
+    # A stack chip keeps the search it was clicked under.
+    assert f'<a class="chip" href="/plugins/docker/?q=it{tag}&amp;stack=it{tag}"' in rows
     assert f'/plugins/docker/service/{name}?task={dead_task}#logs' in rows   # the failure's logs
     assert f'href="/plugins/docker/service/{name}"' not in got["other"][1]
diff --git a/tests/integration/test_mcp_plugin_tools.py b/tests/integration/test_mcp_plugin_tools.py
index 4dc3b68..723a26d 100644
--- a/tests/integration/test_mcp_plugin_tools.py
+++ b/tests/integration/test_mcp_plugin_tools.py
@@ -265,11 +265,14 @@ def test_docker_and_agent_tools_over_seeded_rows(app):
             sess["user_id"], sess["user_role"], sess["username"] = viewer_id, "viewer", "viewer"
             sess["login_at"] = time.time()
         topo = await (await client.get("/plugins/docker/swarm")).get_data(as_text=True)
-        assert svc in topo and "1 task failed in the last 24h" in topo
+        assert f'href="/plugins/docker/service/{svc}"' in topo       # short of replicas: named first
         assert "task: non-zero exit (1)" in topo
         cards = await (await client.get("/plugins/docker/rows")).get_data(as_text=True)
-        assert f"{svc}.1.abc" in cards and replaced not in cards
+        assert f'href="/plugins/docker/service/{svc}"' in cards and replaced not in cards
         assert "task: non-zero exit (1)" in cards
+        # The overview names the service; its own page names its live replica.
+        page = await (await client.get(f"/plugins/docker/service/{svc}")).get_data(as_text=True)
+        assert f"{svc}.1.abc" in page and replaced not in page
         assert (await client.get("/plugins/docker/widget")).status_code == 200
 
         # ── host agents ────────────────────────────────────────────────────