fix(scheduler): a task marked not to run on startup waits an interval after boot (#5431)
CI / lint (push) Successful in 3s
CI / integration (push) Successful in 1m57s
CI / unit (push) Successful in 2m8s
CI / publish (push) Successful in 1m33s

_DueTracker counted a task that had never run from 0 on the loop clock,
which is host uptime, so every run_on_startup=False task (hourly data
cleanup with the Docker log prune, the weekly report check, alert
reconcile, agent age, Ansible schedules) fired on the first tick after
each deploy, while agents were flushing their backlog. Agent ingest was
slow or dropped for a few minutes after every deploy.

start_scheduler now calls tracker.begin(): such a task is first due one
interval after the loop starts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-08 21:52:08 -04:00
co-authored by Claude Opus 5.5
parent 5a3f8083f9
commit 401bfb5251
2 changed files with 30 additions and 1 deletions
+17
View File
@@ -56,3 +56,20 @@ def test_independent_tasks_do_not_block_each_other():
tr = _DueTracker()
tr.mark_started(a, now=0) # a hangs
assert tr.due([a, b], now=10) == [b] # b still fires
def test_a_task_not_run_on_startup_waits_one_interval_after_boot():
"""#5431: the loop's clock is host uptime, far past every interval. A task
marked not to run on startup used to count from 0 and fire on the first
tick anyway; it now waits a whole interval from when the loop began."""
boot = 1_000_000.0
hourly = _task("cleanup", 3600)
eager = ScheduledTask(name="poll", coro_factory=lambda: None, interval_seconds=60,
run_on_startup=True)
tr = _DueTracker()
tr.begin([hourly, eager], now=boot)
assert tr.due([hourly], now=boot + 1) == []
assert tr.due([hourly], now=boot + 3599) == []
assert tr.due([hourly], now=boot + 3600) == [hourly]
assert "poll" not in tr.last_run # started by start_scheduler itself