bvandeusenandClaude Opus 5 0ab15d7d80 feat(lessons): the lesson kind, and one join for every trigger title (#3729) ...

Milestone 385 step 2, implementing decision #4157 from the step-1 spike.

The kind: `note_type='lesson'`, a note findable by WHEN IT APPLIES rather
than by what it is about. The trigger lives in `notes.data.when_to_apply`,
mirrored into the title and the head of the body — the shape snippets
already use, and the reason nothing re-embeds: chunk_document is untouched,
so CHUNKER_VERSION does not move.

NO MIGRATION, and the step assumed there would be one. `note_type` carries
no CHECK — only `task_kind` does (0056, 0065). Migration 0036 added it as
plain Text with a server default and nothing has gated it since, so rule 36
has no whitelist to expand and #3128's failure mode (a value the database
refuses) cannot arise for this column. The vocabulary that actually decides
what a reader can reach is services.knowledge._FACETS, which since #3161 is
one table feeding the door's validation, the counts and both dialects of
the type filter — so the kind lands there in a single edit.

ONE JOIN, not a fourth copy. `{subject} — {trigger}` had three
implementations: rule_document, snippets.compose_title, and this step
needed another. #3207 records what that costs, so the join moves to
embeddings.trigger_title beside embedding_text and all three delegate.
Behaviour is unchanged for rules and snippets; the guard calls each through
its own public name, so a re-implementation fails it.

The #3163 bill is stated in the service docstring rather than left to be
inferred: versions, supersession, trash, the share ACL, tags, project and
System tagging, chunked embeddings and the duplicate gate are all
inherited; status/task_kind/milestone_id and recurrence are not, and
verify_with/expires_when are available but outside the kind's contract.
The status cell is the one that matters — `is_task` IS `status is not
None`, so a lesson that acquired one would become a task.

The integration guard asserts the WRITE rather than the constraint: it
holds whether or not note_type is ever gated, and goes red only if it is
gated without this value.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01821k5B3Ysecp9fNYs92Kuy

2026-09-18 15:30:49 -04:00

..

__init__.py

fix(tests): two readers moved, and the settings guard now checks the registry (#4102)

2026-09-17 11:20:47 -04:00

api_key.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

app_log.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

base.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

canonical_system.py

feat(systems): the area vocabulary becomes a global table so a rule can point at one (#3027, milestone 307 step 1)

2026-08-26 12:31:18 -04:00

code_shape.py

feat(ledger): the CSS consumer map — code_shape_consumers edges (shape → file whose markup names the class, count), migration 0086, resolve_consumers (own-file row when the template defines the class, else every other definition), sync_repo_consumers rebuilt from the archive on every refresh, consumers_of; derived, so not backed up (milestone 302 step 2, #2935)

2026-08-23 13:59:55 -04:00

design_system.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

embedding.py

feat(search): milestones are searchable by meaning — "is there already a plan for this?" (#4078)

2026-09-15 13:34:03 -04:00

forge_connection.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

group.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

invitation.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

milestone.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

note_draft.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

note_supersession.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

note_usage.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

note_version.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

note.py

feat(lessons): the lesson kind, and one join for every trigger title (#3729)

2026-09-18 15:30:49 -04:00

notification.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

password_reset.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

project.py

feat(rules)!: retire rulebook subscriptions and per-project suppressions (#4052)

2026-09-15 12:20:57 -04:00

repo_binding.py

feat(ledger): a repo binding names the branch its ledger follows — bind_repo(ref=) (#2873, milestone 294)

2026-08-21 15:10:54 -04:00

retrieval_log.py

feat(telemetry): record WHAT the bar turned away, not only how close it came (#3807)

2026-09-09 21:24:32 -04:00

retrieval_tuning.py

feat(retrieval): a tuned number carries the space it was measured in (#4104)

2026-09-17 12:45:48 -04:00

rule_usage.py

feat(telemetry): rule_usage_events — the table, the service, and a restore that maps rule ids through the rule map (#3315)

2026-09-02 16:55:22 -04:00

rule_version.py

wip(394): steps 6+7 — backend path and instruction surfaces

2026-09-11 15:15:33 -04:00

rulebook.py

feat(rules)!: retire rulebook subscriptions and per-project suppressions (#4052)

2026-09-15 12:20:57 -04:00

setting.py

refactor: rename package fabledassistant -> scribe (code-only)

2026-06-03 15:48:35 -04:00

share.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

system.py

feat(systems): the area vocabulary becomes a global table so a rule can point at one (#3027, milestone 307 step 1)

2026-08-26 12:31:18 -04:00

task_log.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00

user_profile.py

refactor: rename package fabledassistant -> scribe (code-only)

2026-06-03 15:48:35 -04:00

user.py

refactor(models): one iso() for every to_dict timestamp; mixins replace hand-rolled created_at/updated_at (#2827, milestone 296 area 3)

2026-08-21 11:17:42 -04:00