bvandeusenandClaude Fable 5
bbee0d0db1
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 8s
CI & Build / integration (push) Successful in 24s
CI & Build / TypeScript typecheck (push) Successful in 32s
CI & Build / Python tests (push) Successful in 54s
CI & Build / Build & push image (push) Successful in 18s
The shape ledger showed the same test scaffolding defined over and over: _bind_user x12 (byte-identical), _dispose_engine x10 in three wordings, _no_supersession x3, _make_mock_session x7 in three subsets, a get-or-create User helper x2 (+3 inlined), and fifteen hand-rolled MagicMock note factories each re-explaining the same "an auto-MagicMock attribute is truthy" hazard (note 2109). Now: conftest.py carries _bind_user / _dispose_engine / _no_supersession as opt-in fixtures (pytestmark = usefixtures(...) per module, so unit tests pay nothing), and tests/helpers.py carries make_mock_session(), ensure_user() and fake_note(**attrs) — the hazard documented once, real values on every attribute the product reads. Call sites were rewritten by AST so titles with dashes and commas survived; the three SimpleNamespace _note stand-ins that only feed a single function stay local. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
61 lines
1.9 KiB
Python
61 lines
1.9 KiB
Python
"""Tests for the trash MCP tools — patch the trash service."""
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
|
|
|
|
pytestmark = pytest.mark.usefixtures("_bind_user")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_trash_wraps_batches():
|
|
with patch("scribe.mcp.tools.trash.trash_svc.list_trash",
|
|
AsyncMock(return_value=[{"batch_id": "b1", "count": 2}])):
|
|
from scribe.mcp.tools.trash import list_trash
|
|
out = await list_trash()
|
|
assert out["batches"][0]["batch_id"] == "b1"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_restore_delegates():
|
|
with patch("scribe.mcp.tools.trash.trash_svc.restore",
|
|
AsyncMock(return_value=3)) as mock:
|
|
from scribe.mcp.tools.trash import restore
|
|
out = await restore("b1")
|
|
assert out == {"restored": 3, "batch_id": "b1"}
|
|
assert mock.call_args.args == (7, "b1")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_purge_trash_requires_confirmed():
|
|
with patch("scribe.mcp.tools.trash.trash_svc.purge", AsyncMock()) as mock:
|
|
from scribe.mcp.tools.trash import purge_trash
|
|
out = await purge_trash("b1", confirmed=False)
|
|
assert out.get("confirmed_required") is True
|
|
assert not mock.called
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_purge_trash_when_confirmed():
|
|
with patch("scribe.mcp.tools.trash.trash_svc.purge",
|
|
AsyncMock(return_value=5)) as mock:
|
|
from scribe.mcp.tools.trash import purge_trash
|
|
out = await purge_trash("b1", confirmed=True)
|
|
assert out == {"purged": 5, "batch_id": "b1"}
|
|
assert mock.called
|
|
|
|
|
|
def test_register_attaches_three_tools():
|
|
from scribe.mcp.tools.trash import register
|
|
names: list[str] = []
|
|
|
|
class FakeMCP:
|
|
def tool(self, name=None):
|
|
def deco(fn):
|
|
names.append(name)
|
|
return fn
|
|
return deco
|
|
|
|
register(FakeMCP())
|
|
assert set(names) == {"list_trash", "restore", "purge_trash"}
|