bvandeusen
b7d6fc7e5d
CI & Build / Python lint (push) Successful in 3s
CI & Build / integration (push) Successful in 28s
CI & Build / TypeScript typecheck (push) Successful in 38s
CI & Build / Python tests (push) Successful in 54s
CI & Build / Build & push image (push) Successful in 1m7s
Option A of the #2079 fork, per the operator's call: widen the scope in query_knowledge for every caller rather than special-casing the snippet path. Until now the list/search queries filtered on Note.user_id alone, while get_note_permission resolved shares properly. The result: a record shared with you could be OPENED by id but never FOUND — invisible in Knowledge browse, in snippet and process lists, and in the facet counts beside them. - services/access.py gains readable_notes_clause(user_id): the same resolution get_note_permission does per row (ownership, direct share, group share, inherited project share), expressed as set membership so a list query can use it in one statement instead of O(n) permission round-trips. - services/knowledge.py routes every query through it — query_knowledge, the keyword half of the hybrid search, query_knowledge_ids, get_knowledge_by_ids, get_knowledge_tags and get_knowledge_counts. The facets follow the list, or a tag visible in the list would filter it down to nothing. - list items now carry user_id, since these lists can be mixed-ownership and the client has no other way to mark what isn't yours. Reaches four surfaces: the Snippets list (the original report), Knowledge browse, list_processes, and the plugin's process manifest — so a Process shared with you now also syncs as a local skill stub, which is the point of sharing one. NOT widened: semantic_search_notes, which scopes by NoteEmbedding.user_id and also backs auto-inject and the search MCP tool. Widening it would put another user's content into your agent context automatically — a product decision, not a bug fix. Consequence until that call is made, marked at the call site: a shared record is findable by wording but not by meaning. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLwAaV4DQEmVyn496HnEvt
51 lines
1.5 KiB
Python
51 lines
1.5 KiB
Python
"""get_knowledge_counts includes the 'process' type and counts it in total."""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
|
|
def _make_mock_session():
|
|
s = AsyncMock()
|
|
s.__aenter__ = AsyncMock(return_value=s)
|
|
s.__aexit__ = AsyncMock(return_value=False)
|
|
return s
|
|
|
|
|
|
def _grouped(rows):
|
|
r = MagicMock()
|
|
r.all.return_value = rows
|
|
return r
|
|
|
|
|
|
def _scalar(n):
|
|
r = MagicMock()
|
|
r.scalar_one.return_value = n
|
|
return r
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_counts_include_process_in_facet_and_total():
|
|
session = _make_mock_session()
|
|
# 1) grouped non-task counts, 2) task count, 3) plan count
|
|
session.execute = AsyncMock(side_effect=[
|
|
_grouped([("note", 3), ("process", 2)]),
|
|
_scalar(1), # tasks
|
|
_scalar(0), # plans
|
|
])
|
|
from scribe.models.note import Note
|
|
# The ACL predicate opens its own session; stub it so this test stays about
|
|
# the count facets.
|
|
with patch("scribe.services.knowledge.async_session") as cls, \
|
|
patch("scribe.services.knowledge.readable_notes_clause",
|
|
AsyncMock(return_value=Note.user_id == 1)):
|
|
cls.return_value = session
|
|
from scribe.services.knowledge import get_knowledge_counts
|
|
counts = await get_knowledge_counts(user_id=1)
|
|
|
|
assert counts["process"] == 2
|
|
# facet keys all present (setdefault)
|
|
for key in ("note", "task", "plan", "process"):
|
|
assert key in counts
|
|
# total = note(3) + task(1) + process(2)
|
|
assert counts["total"] == 6
|