bvandeusen
4d6bae77b4
Seven tools matching existing fable-mcp contracts: - fable_list/get/create/update_project (no delete; archive via status) - fable_list/create/update_milestone (no get; no delete) LLM-era similarity-check / 'confirmed' guard for create_project is NOT replicated — Claude doesn't need it. The service's auto-summary regeneration side effect (services.projects.update_project) stays for now; gets removed in Phase 7 along with all other LLM code. Notable sentinels: - update_milestone: order_index=-1 means "leave unchanged" (0 is valid) - create_milestone: description="" becomes None at the service layer Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
99 lines
3.5 KiB
Python
99 lines
3.5 KiB
Python
"""Tests for fable_*_milestone tools."""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from fabledassistant.mcp._context import _user_id_ctx
|
|
from fabledassistant.mcp.tools.milestones import (
|
|
fable_list_milestones, fable_create_milestone, fable_update_milestone,
|
|
)
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _bind_user():
|
|
token = _user_id_ctx.set(7)
|
|
yield
|
|
_user_id_ctx.reset(token)
|
|
|
|
|
|
def _fake_ms(**overrides) -> MagicMock:
|
|
m = MagicMock()
|
|
base = {"id": 1, "project_id": 1, "title": "MS", "description": None,
|
|
"status": "active", "order_index": 0}
|
|
base.update(overrides)
|
|
m.to_dict.return_value = base
|
|
return m
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_milestones_returns_dict_with_progress():
|
|
rows = [{"id": 1, "title": "MS1", "status": "active", "task_count": 2}]
|
|
with patch(
|
|
"fabledassistant.mcp.tools.milestones.milestones_svc.get_project_milestone_summary",
|
|
AsyncMock(return_value=rows),
|
|
):
|
|
out = await fable_list_milestones(project_id=1)
|
|
assert out["milestones"] == rows
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_milestone_passes_through():
|
|
m = _fake_ms(id=5)
|
|
mock = AsyncMock(return_value=m)
|
|
with patch("fabledassistant.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
|
out = await fable_create_milestone(project_id=1, title="new", description="d")
|
|
assert out["id"] == 5
|
|
assert mock.call_args.kwargs["project_id"] == 1
|
|
assert mock.call_args.kwargs["title"] == "new"
|
|
assert mock.call_args.kwargs["description"] == "d"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_milestone_empty_description_becomes_none():
|
|
m = _fake_ms()
|
|
mock = AsyncMock(return_value=m)
|
|
with patch("fabledassistant.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
|
await fable_create_milestone(project_id=1, title="t", description="")
|
|
assert mock.call_args.kwargs["description"] is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_milestone_only_sends_non_default_fields():
|
|
m = _fake_ms()
|
|
mock = AsyncMock(return_value=m)
|
|
with patch("fabledassistant.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
|
await fable_update_milestone(project_id=1, milestone_id=5, status="done")
|
|
args, kwargs = mock.call_args
|
|
assert args == (7, 5)
|
|
assert kwargs == {"status": "done"}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_milestone_order_index_negative_is_omitted():
|
|
"""order_index=-1 sentinel means leave unchanged."""
|
|
m = _fake_ms()
|
|
mock = AsyncMock(return_value=m)
|
|
with patch("fabledassistant.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
|
await fable_update_milestone(project_id=1, milestone_id=5, order_index=-1)
|
|
assert "order_index" not in mock.call_args.kwargs
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_milestone_order_index_zero_is_explicit():
|
|
"""order_index=0 is a real value (top of list), not a sentinel."""
|
|
m = _fake_ms()
|
|
mock = AsyncMock(return_value=m)
|
|
with patch("fabledassistant.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
|
await fable_update_milestone(project_id=1, milestone_id=5, order_index=0)
|
|
assert mock.call_args.kwargs["order_index"] == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_milestone_raises_when_not_found():
|
|
with patch(
|
|
"fabledassistant.mcp.tools.milestones.milestones_svc.update_milestone",
|
|
AsyncMock(return_value=None),
|
|
):
|
|
with pytest.raises(ValueError, match="milestone 999 not found"):
|
|
await fable_update_milestone(project_id=1, milestone_id=999, title="x")
|