bvandeusenandClaude Opus 5.5
914f31359c
CI & Build / Python lint (push) Successful in 5s
CI & Build / Plugin hooks (push) Successful in 17s
CI & Build / TypeScript typecheck (push) Successful in 57s
CI & Build / integration (push) Successful in 1m19s
CI & Build / Python tests (push) Successful in 2m2s
CI & Build / Build & push image (push) Successful in 15s
Docstrings, section headers and assertion messages drop the record number, milestone or step that introduced the behaviour, and incident accounts are restated as the present-tense failure shape. A dead pointer to a design doc that is not in the repo is removed. Renamed to the property they check: test_the_old_shape_would_be_caught -> test_a_rank_then_scope_query_is_caught test_a_ledger_repeat_no_longer_produces_that_case_at_all -> test_a_ledger_repeat_is_counted_not_withheld test_the_header_no_longer_promises_once_per_session -> test_the_header_explains_the_seen_marker test_the_portal_case_no_longer_stamps_one_canon_onto_a_whole_file -> test_one_canon_is_not_stamped_onto_a_whole_file test_the_repos_own_prose_no_longer_defines_with -> test_the_repos_own_prose_does_not_define_with test_the_original_regression_create_note_with_content -> test_the_real_server_refuses_content_on_create_note Fixture and example ids stay: "note 5" in a supersession chain, "rule 156" in an illustrative question, `#2275` as the hex-versus-citation case, `#3244` as the example of a bare number, fixed dates in date-filter tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
79 lines
2.8 KiB
Python
79 lines
2.8 KiB
Python
"""Tests for the prune logic — both rolling (pin_kind IS NULL) and the
|
|
auto-pin bucket (pin_kind='auto').
|
|
"""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
from tests.helpers import make_mock_session
|
|
|
|
|
|
async def test_create_version_prune_sql_filters_to_unpinned():
|
|
"""The DELETE statement issued by create_version's prune step must
|
|
include `pin_kind IS NULL` in the inner SELECT so pinned versions
|
|
aren't counted toward MAX_VERSIONS and can't be pruned by it."""
|
|
mock_session = make_mock_session()
|
|
select_result = MagicMock()
|
|
# No prior version → skips the throttle/dedupe early-return paths and
|
|
# proceeds straight to insert + prune.
|
|
select_result.scalars.return_value.first.return_value = None
|
|
mock_session.add = MagicMock()
|
|
mock_session.commit = AsyncMock()
|
|
mock_session.refresh = AsyncMock()
|
|
|
|
captured_sql: list[str] = []
|
|
|
|
async def execute_capture(stmt, *args, **kwargs):
|
|
captured_sql.append(str(stmt))
|
|
if len(captured_sql) == 1:
|
|
return select_result
|
|
return MagicMock()
|
|
|
|
mock_session.execute = AsyncMock(side_effect=execute_capture)
|
|
|
|
with patch(
|
|
"scribe.services.note_versions.async_session",
|
|
return_value=mock_session,
|
|
):
|
|
from scribe.services.note_versions import create_version
|
|
await create_version(
|
|
user_id=1, note_id=42, body="content", title="t", tags=["a"],
|
|
)
|
|
|
|
assert any("pin_kind IS NULL" in s for s in captured_sql), (
|
|
f"Expected prune SQL to filter pin_kind IS NULL; got: {captured_sql!r}"
|
|
)
|
|
|
|
|
|
async def test_prune_auto_pins_filters_to_auto_kind():
|
|
"""prune_auto_pins must filter to pin_kind='auto' so manual pins and
|
|
rolling rows aren't touched, and must bind MAX_AUTO_PINS as the OFFSET."""
|
|
mock_session = make_mock_session()
|
|
mock_session.commit = AsyncMock()
|
|
|
|
captured_sql: list[str] = []
|
|
captured_params: list[dict] = []
|
|
|
|
async def execute_capture(stmt, *args, **kwargs):
|
|
captured_sql.append(str(stmt))
|
|
try:
|
|
captured_params.append(dict(stmt.compile().params))
|
|
except Exception:
|
|
captured_params.append({})
|
|
return MagicMock()
|
|
|
|
mock_session.execute = AsyncMock(side_effect=execute_capture)
|
|
|
|
with patch(
|
|
"scribe.services.version_pinning.async_session",
|
|
return_value=mock_session,
|
|
):
|
|
from scribe.services.version_pinning import (
|
|
prune_auto_pins, MAX_AUTO_PINS,
|
|
)
|
|
await prune_auto_pins(user_id=1, note_id=42)
|
|
|
|
assert any("pin_kind = 'auto'" in s for s in captured_sql), (
|
|
f"expected auto-bucket filter in SQL; got: {captured_sql!r}"
|
|
)
|
|
assert any(
|
|
p.get("max_auto_pins") == MAX_AUTO_PINS for p in captured_params
|
|
), f"bound params: {captured_params!r}"
|