bvandeusenandClaude Opus 5.5
914f31359c
CI & Build / Python lint (push) Successful in 5s
CI & Build / Plugin hooks (push) Successful in 17s
CI & Build / TypeScript typecheck (push) Successful in 57s
CI & Build / integration (push) Successful in 1m19s
CI & Build / Python tests (push) Successful in 2m2s
CI & Build / Build & push image (push) Successful in 15s
Docstrings, section headers and assertion messages drop the record number, milestone or step that introduced the behaviour, and incident accounts are restated as the present-tense failure shape. A dead pointer to a design doc that is not in the repo is removed. Renamed to the property they check: test_the_old_shape_would_be_caught -> test_a_rank_then_scope_query_is_caught test_a_ledger_repeat_no_longer_produces_that_case_at_all -> test_a_ledger_repeat_is_counted_not_withheld test_the_header_no_longer_promises_once_per_session -> test_the_header_explains_the_seen_marker test_the_portal_case_no_longer_stamps_one_canon_onto_a_whole_file -> test_one_canon_is_not_stamped_onto_a_whole_file test_the_repos_own_prose_no_longer_defines_with -> test_the_repos_own_prose_does_not_define_with test_the_original_regression_create_note_with_content -> test_the_real_server_refuses_content_on_create_note Fixture and example ids stay: "note 5" in a supersession chain, "rule 156" in an illustrative question, `#2275` as the hex-versus-citation case, `#3244` as the example of a bare number, fixed dates in date-filter tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
90 lines
3.8 KiB
Python
90 lines
3.8 KiB
Python
"""The server half of the end-of-turn shape check: what the
|
|
agent is asked, what the hook's ledger may say, and the outcome record."""
|
|
import json
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from tests.helpers import make_mock_session
|
|
|
|
|
|
def test_the_ledger_lines_parse_and_garbage_is_dropped():
|
|
from scribe.services.shape_check import parse_written
|
|
|
|
raw = ("a.py\tsym\thelper\n"
|
|
"a.py\tsym\thelper\n" # duplicate
|
|
"web/A.svelte\tfile\tA\n"
|
|
"x.py\tbogus\tthing\n" # unknown kind
|
|
"only-two\tsym\n" # malformed
|
|
"\tsym\tnameless-path\n")
|
|
assert parse_written(raw) == [("a.py", "sym", "helper"), ("web/A.svelte", "file", "A")]
|
|
assert len(parse_written("".join(f"p\tsym\tn{i}\n" for i in range(500)), cap=7)) == 7
|
|
|
|
|
|
def test_a_first_stop_blocks_or_passes_and_the_next_never_blocks():
|
|
from scribe.services.shape_check import outcome_for
|
|
|
|
one = [{"path": "a", "kind": "sym", "symbol": "b"}]
|
|
assert outcome_for("check", one) == "blocked"
|
|
assert outcome_for("check", []) == "passed"
|
|
assert outcome_for("after", one) == "left_after_block"
|
|
assert outcome_for("after", []) == "judged_after_block"
|
|
|
|
|
|
def test_the_reason_names_each_shape_its_evidence_and_the_one_call():
|
|
from scribe.services.shape_check import block_reason
|
|
|
|
unjudged = [
|
|
{"path": "web/A.svelte", "kind": "file", "symbol": "A", "status": "new", "evidence": {}},
|
|
{"path": "src/x.py", "kind": "sym", "symbol": "load", "status": "unclassified",
|
|
"evidence": {"looks_like": {"snippet_id": 12, "basis": "semantic", "score": 0.84},
|
|
"diverges_from": 9}},
|
|
]
|
|
reason = block_reason(unjudged, project_id=3, repo="git.example.com/a/w")
|
|
assert "2 definitions" in reason
|
|
assert "web/A.svelte · A (file) — new" in reason
|
|
assert "looks like #12 0.84" in reason and "#9 is canon in this directory" in reason
|
|
assert 'classify_shapes(project_id=3, repo="git.example.com/a/w"' in reason
|
|
for verdict in ("create_snippet", "`instance`", "`variant`", "`exempt`"):
|
|
assert verdict in reason, verdict
|
|
|
|
|
|
def test_a_long_turn_is_listed_with_a_tail_not_dropped():
|
|
from scribe.services.shape_check import _LISTED, block_reason
|
|
|
|
many = [{"path": "p.py", "kind": "sym", "symbol": f"f{i}", "status": "new", "evidence": {}}
|
|
for i in range(_LISTED + 3)]
|
|
reason = block_reason(many, project_id=1, repo="")
|
|
assert "… and 3 more" in reason
|
|
assert "repo=" not in reason
|
|
|
|
|
|
async def test_the_outcome_is_recorded_as_a_plugin_event():
|
|
from scribe.services.shape_check import record_shape_check
|
|
|
|
session = make_mock_session()
|
|
with patch("scribe.services.shape_check.async_session", return_value=session):
|
|
await record_shape_check(7, "blocked", written=5, unjudged=2, project_id=2)
|
|
row = session.add.call_args.args[0]
|
|
assert (row.category, row.action, row.user_id) == ("plugin", "shape_check", 7)
|
|
assert json.loads(row.details) == {"outcome": "blocked", "written": 5,
|
|
"unjudged": 2, "project_id": 2}
|
|
|
|
|
|
async def test_an_unknown_outcome_is_refused_before_anything_is_written():
|
|
from scribe.services.shape_check import record_shape_check
|
|
|
|
session = make_mock_session()
|
|
with patch("scribe.services.shape_check.async_session", return_value=session), \
|
|
pytest.raises(ValueError):
|
|
await record_shape_check(7, "skipped", written=1, unjudged=1)
|
|
session.add.assert_not_called()
|
|
|
|
|
|
def test_the_window_counts_turns_asks_and_asks_walked_past():
|
|
from scribe.services.shape_check import summarise
|
|
|
|
assert summarise([]) == {"checked": 0, "asked": 0, "left": 0}
|
|
got = summarise(["passed", "blocked", "judged_after_block", "blocked", "left_after_block"])
|
|
assert got == {"checked": 3, "asked": 2, "left": 1}
|