bvandeusenandClaude Opus 5.5
914f31359c
CI & Build / Python lint (push) Successful in 5s
CI & Build / Plugin hooks (push) Successful in 17s
CI & Build / TypeScript typecheck (push) Successful in 57s
CI & Build / integration (push) Successful in 1m19s
CI & Build / Python tests (push) Successful in 2m2s
CI & Build / Build & push image (push) Successful in 15s
Docstrings, section headers and assertion messages drop the record number, milestone or step that introduced the behaviour, and incident accounts are restated as the present-tense failure shape. A dead pointer to a design doc that is not in the repo is removed. Renamed to the property they check: test_the_old_shape_would_be_caught -> test_a_rank_then_scope_query_is_caught test_a_ledger_repeat_no_longer_produces_that_case_at_all -> test_a_ledger_repeat_is_counted_not_withheld test_the_header_no_longer_promises_once_per_session -> test_the_header_explains_the_seen_marker test_the_portal_case_no_longer_stamps_one_canon_onto_a_whole_file -> test_one_canon_is_not_stamped_onto_a_whole_file test_the_repos_own_prose_no_longer_defines_with -> test_the_repos_own_prose_does_not_define_with test_the_original_regression_create_note_with_content -> test_the_real_server_refuses_content_on_create_note Fixture and example ids stay: "note 5" in a supersession chain, "rule 156" in an illustrative question, `#2275` as the hex-versus-citation case, `#3244` as the example of a bare number, fixed dates in date-filter tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
51 lines
2.2 KiB
Python
51 lines
2.2 KiB
Python
"""/api/search — the kind filter it offers, and what it does with a bad one.
|
|
|
|
The route reads its kinds from the one table the vocabulary lives in, rather
|
|
than keeping a map of its own (`note`/`task`/everything else is `all`). Both
|
|
halves are pinned here: every declared kind is
|
|
reachable, and a kind that does not exist is refused rather than widened.
|
|
"""
|
|
import pytest
|
|
|
|
from scribe.services.knowledge import FACET_TYPES, content_type_filters
|
|
|
|
|
|
def test_the_three_historical_values_still_mean_what_they_meant():
|
|
assert content_type_filters("all") == {"is_task": None}
|
|
assert content_type_filters("task")["is_task"] is True
|
|
# BROAD on purpose: any non-task, so snippets and lessons stay in scope.
|
|
assert content_type_filters("note") == {"is_task": False}
|
|
|
|
|
|
@pytest.mark.parametrize("facet", sorted(FACET_TYPES))
|
|
def test_every_declared_kind_is_reachable_through_this_door(facet):
|
|
"""The engine took `note_type` and `task_kind` all along — the route was
|
|
simply unable to say them."""
|
|
filters = content_type_filters(facet)
|
|
assert "is_task" in filters
|
|
if facet not in ("all", "note", "task"):
|
|
assert filters.get("note_type") == facet or filters.get("task_kind") == facet
|
|
|
|
|
|
def test_an_unknown_kind_is_refused_instead_of_silently_widening():
|
|
"""The old map read anything unrecognised as "no filter", so
|
|
`?content_type=snippets` returned the whole corpus while looking like a
|
|
narrowed search — the failure mode that answers a question nobody asked."""
|
|
with pytest.raises(ValueError) as err:
|
|
content_type_filters("snippets")
|
|
assert "snippets" in str(err.value)
|
|
assert "snippet" in str(err.value) # names the real ones
|
|
|
|
|
|
def test_a_doors_refusal_lists_only_what_that_door_accepts():
|
|
"""`rule` and `milestone` are the MCP tool's own searches. This route has
|
|
neither, so offering them in its error would send a caller at a parameter
|
|
that does not work here."""
|
|
with pytest.raises(ValueError) as plain:
|
|
content_type_filters("nonsense")
|
|
assert "rule" not in str(plain.value)
|
|
|
|
with pytest.raises(ValueError) as extra:
|
|
content_type_filters("nonsense", extra=("rule", "milestone"))
|
|
assert "rule" in str(extra.value) and "milestone" in str(extra.value)
|