bvandeusenandClaude Opus 5
188e78bbcd
CI & Build / Python lint (push) Successful in 4s
CI & Build / Plugin hooks (push) Successful in 9s
CI & Build / TypeScript typecheck (push) Successful in 54s
CI & Build / integration (push) Successful in 59s
CI & Build / Python tests (push) Successful in 1m37s
CI & Build / Build & push image (push) Successful in 31s
semantic_search_rules searched every rule the user owned, and every hook arm called it without a project, so each project's rules were injected into every other project's sessions and a project rule meant nothing a session could feel. The search now takes a scope: global rules by default (an unbound session, or a caller that forgets to say), global plus project N when given project_id (N's rules only if the caller can read that project, through access.can_read_project), and every owned rule with everywhere=True. The four hook arms and the report preference lookup pass the session's project; an explicit search(content_type="rule") scopes to its project_id, or asks the whole rulebook without one. Milestone 414 step 1. Guarded by an AST walk that every hook call site passes project_id, and an integration test on real Postgres that a rule is reached only from its home. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01821k5B3Ysecp9fNYs92Kuy
109 lines
3.7 KiB
Python
109 lines
3.7 KiB
Python
"""search tool — proves the tool pattern (context + service call + dict shape).
|
|
|
|
Service call is mocked; no DB needed."""
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
|
|
from scribe.mcp._context import _user_id_ctx
|
|
from scribe.mcp.tools.search import search
|
|
from tests.helpers import fake_note
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_user_ctx():
|
|
"""Each test starts with no MCP context. Tests set it explicitly."""
|
|
token = _user_id_ctx.set(None)
|
|
yield
|
|
_user_id_ctx.reset(token)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_fable_search_raises_without_context():
|
|
with pytest.raises(RuntimeError, match="no MCP user context"):
|
|
await search(q="anything")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_fable_search_returns_repackaged_results():
|
|
_user_id_ctx.set(7)
|
|
fake = fake_note(id=1, title="kafka rebalance", is_task=False, body="HPA details", tags=["ops"])
|
|
with patch(
|
|
"scribe.mcp.tools.search.semantic_search_notes",
|
|
AsyncMock(return_value=[(0.93, fake)]),
|
|
):
|
|
out = await search(q="kafka")
|
|
|
|
assert out["total"] == 1
|
|
assert len(out["results"]) == 1
|
|
r = out["results"][0]
|
|
assert r["id"] == 1
|
|
assert r["title"] == "kafka rebalance"
|
|
assert r["body"] == "HPA details"
|
|
assert r["is_task"] is False
|
|
assert r["tags"] == ["ops"]
|
|
assert r["similarity"] == pytest.approx(0.93)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_fable_search_body_is_truncated_to_240_chars():
|
|
_user_id_ctx.set(7)
|
|
long_body = "x" * 500
|
|
fake = fake_note(id=1, title="t", body=long_body)
|
|
with patch(
|
|
"scribe.mcp.tools.search.semantic_search_notes",
|
|
AsyncMock(return_value=[(0.5, fake)]),
|
|
):
|
|
out = await search(q="x")
|
|
assert len(out["results"][0]["body"]) == 240
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_fable_search_content_type_filters_at_service_layer():
|
|
"""content_type maps to the is_task kwarg passed to the service."""
|
|
_user_id_ctx.set(7)
|
|
mock_search = AsyncMock(return_value=[])
|
|
with patch("scribe.mcp.tools.search.semantic_search_notes", mock_search):
|
|
await search(q="x", content_type="task")
|
|
assert mock_search.call_args.kwargs["is_task"] is True
|
|
|
|
mock_search.reset_mock()
|
|
await search(q="x", content_type="note")
|
|
assert mock_search.call_args.kwargs["is_task"] is False
|
|
|
|
mock_search.reset_mock()
|
|
await search(q="x", content_type="all")
|
|
assert mock_search.call_args.kwargs["is_task"] is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_fable_search_limit_is_clamped():
|
|
_user_id_ctx.set(7)
|
|
mock_search = AsyncMock(return_value=[])
|
|
with patch("scribe.mcp.tools.search.semantic_search_notes", mock_search):
|
|
await search(q="x", limit=999)
|
|
assert mock_search.call_args.kwargs["limit"] == 50
|
|
|
|
mock_search.reset_mock()
|
|
await search(q="x", limit=0)
|
|
assert mock_search.call_args.kwargs["limit"] == 1
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
@pytest.mark.parametrize("project_id, scope", [
|
|
(5, {"project_id": 5}),
|
|
# No project: the explicit question is asked of the whole rulebook.
|
|
(0, {"everywhere": True}),
|
|
])
|
|
async def test_rule_search_scopes_to_the_project_it_is_given(project_id, scope):
|
|
"""With a project: global rules plus that project's (milestone 414).
|
|
Without one: every rule, because an unscoped "is there a rule about this"
|
|
is asking the whole rulebook — unlike a hook, which speaks unasked."""
|
|
_user_id_ctx.set(7)
|
|
found = AsyncMock(return_value=[])
|
|
with patch("scribe.mcp.tools.search.semantic_search_rules", found):
|
|
await search(q="release tagging", content_type="rule", project_id=project_id)
|
|
kwargs = found.await_args.kwargs
|
|
assert {k: kwargs[k] for k in scope} == scope
|
|
assert set(kwargs) & {"project_id", "everywhere"} == set(scope)
|