bvandeusenandClaude Opus 5.5
f68b73f922
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 14s
CI & Build / TypeScript typecheck (push) Successful in 53s
CI & Build / integration (push) Successful in 1m10s
CI & Build / Python tests (push) Successful in 1m54s
CI & Build / Build & push image (push) Successful in 31s
report_preference searched one constant string when a task closed and handed matches back as update_task's reply_preferences. Milestone 500 step 3 delivers the reply shapes and the preferences mounted beside them on the moments, so the arm goes, whole (rule 22): - services/reply_preferences.py, the REPORT_PREFERENCE RuleArm, its re-scorer and corpus entries, and the REPORTPREF constants - update_task's reply_preferences block and its cue; the docstring now points at moment_rules - the fixed_query field and the fixed_query_never_clears warning: this arm was the only one that set it, so the concept and the cannot_decline exemption go with it - the two Settings fields for its floor and budget - migration 0121 deletes its rows (logs, judgments, rule-usage events, tuning history, settings keys), operator-approved 2026-10-09. Without it the readout would call the source unregistered and its surfacings would count as ambient. The unindexed rule_usage delete is bounded by created_at. #5496 (step 4 of milestone 500). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
70 lines
2.9 KiB
Python
70 lines
2.9 KiB
Python
"""update_task closes a task with a one-line reminder of what the report needs.
|
|
|
|
The in-band half of milestone 409 step 3: the skill and static context only
|
|
exist in the Claude Code plugin, and a tool response reaches every MCP client
|
|
at the moment a piece of work closes. Pinned on the response, not the wording.
|
|
|
|
The operator's own completion-report preferences used to ride here too, from
|
|
a fixed-question search (409 step 4). Milestone 500 retired that: they are
|
|
mounted on finishing work and arrive in `moment_rules` beside the delivered
|
|
reply shape, so this response carries no key of its own for them.
|
|
"""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
pytestmark = pytest.mark.usefixtures("_bind_user")
|
|
|
|
|
|
async def _update(owed=None, **kwargs):
|
|
from scribe.mcp.tools.tasks import update_task
|
|
|
|
note = MagicMock(id=5, user_id=7, project_id=3, started_at="2026-10-06T09:00:00+00:00")
|
|
note.to_dict.return_value = {"id": 5}
|
|
with patch("scribe.mcp.tools.tasks.notes_svc.update_note", AsyncMock(return_value=note)), \
|
|
patch("scribe.mcp.tools.tasks.systems_tools.attach_systems", AsyncMock()), \
|
|
patch("scribe.mcp.tools.tasks.placement_svc.attach_placement", AsyncMock()), \
|
|
patch("scribe.mcp.tools.tasks.family_adoption_svc.owed_since",
|
|
AsyncMock(return_value=list(owed or []))):
|
|
return await update_task(task_id=5, **kwargs)
|
|
|
|
|
|
@pytest.mark.parametrize("status", ["done", "cancelled"])
|
|
async def test_closing_a_task_carries_the_cue(status):
|
|
out = await _update(status=status)
|
|
assert "placement" in out["report_back"] and "needs them" in out["report_back"]
|
|
|
|
|
|
@pytest.mark.parametrize("kwargs", [{"status": "in_progress"}, {"status": "todo"}, {"body": "more notes"}])
|
|
async def test_other_updates_do_not(kwargs):
|
|
out = await _update(**kwargs)
|
|
assert "report_back" not in out
|
|
|
|
|
|
async def test_closing_carries_the_plain_cue_and_no_preference_key_of_its_own():
|
|
"""The retired key does not come back beside the moment delivery."""
|
|
from scribe.mcp.tools.tasks import REPORT_BACK_CUE
|
|
|
|
out = await _update(status="done")
|
|
assert "reply_preferences" not in out
|
|
assert out["report_back"] == REPORT_BACK_CUE
|
|
|
|
|
|
_OWED = {"idea_id": 9, "idea_title": "Signed APK lane", "project_id": 4,
|
|
"project_title": "android two", "owed_task_id": 77}
|
|
|
|
|
|
async def test_closing_names_the_owed_adoptions_filed_while_the_task_was_open():
|
|
"""The finishing moment of milestone 463 step 6: owed family work filed
|
|
into a project during this task comes back for the report to name."""
|
|
from scribe.services.family_adoption import OWED_CUE
|
|
|
|
out = await _update(owed=[_OWED], status="done")
|
|
assert out["family_owed"] == [_OWED]
|
|
assert out["report_back"].endswith(OWED_CUE) and "family_owed" in out["report_back"]
|
|
|
|
|
|
async def test_no_owed_adoptions_means_no_key():
|
|
out = await _update(owed=[], status="done")
|
|
assert "family_owed" not in out
|