bvandeusenandClaude Opus 5
a97547fbc6
CI & Build / Plugin hooks (push) Successful in 10s
CI & Build / TypeScript typecheck (push) Successful in 39s
CI & Build / Python lint (push) Successful in 4s
CI & Build / integration (push) Successful in 30s
CI & Build / Python tests (push) Failing after 56s
CI & Build / Build & push image (push) Skipped
The eight standard area names already existed — as STANDARD_SYSTEMS, a tuple in
services/systems.py that milestone 297 seeds at inception. A constant cannot be
a foreign key, so nothing outside a project could reference an area: systems.
project_id is NOT NULL, and a rule that spans projects would have to chain
itself to one project's row. And because the list only ever applied on the
inception-seed path, three spellings of one area reached this instance anyway
(CI & runners / CI and Release / CI & release).
- canonical_systems: global, no user_id — a shared project inherits the
vocabulary instead of re-earning it. Migration 0087 seeds the same eight.
- systems.canonical_id: nullable, SET NULL. Association only — no System is
renamed and record_systems is untouched, so no record's tags move.
- canonical_slug folds &/and, case and punctuation, so spelling variants map
mechanically and a real difference ("CI & runners") becomes a proposal a
human confirms. propose_mappings reports; set_system_canonical is the only
writer.
- seed_standard_systems now reads the catalog and maps as it mints, so a
project born standard never needs a reconciliation pass.
- Catalog writes are admin-only; reads are open — a global list anyone can
extend stops being shared.
- backup: carried by SLUG, not id (ids are per-install). Restore reuses the
target's own rows and only creates entries an admin added on the source; an
unknown slug restores unmapped rather than failing.
Rule 22: STANDARD_SYSTEMS is removed, not deprecated. Rule 115: nothing seeded
names an app, repo or house convention. Design in note 3026.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
59 lines
2.5 KiB
Python
59 lines
2.5 KiB
Python
from sqlalchemy import Index, Integer, Text, text
|
|
from sqlalchemy.orm import Mapped, mapped_column
|
|
|
|
from scribe.models import Base
|
|
from scribe.models.base import SoftDeleteMixin, TimestampMixin, iso
|
|
|
|
|
|
class CanonicalSystem(Base, TimestampMixin, SoftDeleteMixin):
|
|
"""A GLOBAL area name — the shared vocabulary every project's Systems
|
|
can point at (milestone 307, decision note 3026).
|
|
|
|
A `System` is per-project and NOT NULL on project_id, so nothing outside a
|
|
project can reference one: a rule that applies across projects has no way
|
|
to say "this is about CI" without chaining itself to one project's row.
|
|
This table is that join key. It carries no `user_id` on purpose — a shared
|
|
project must INHERIT the vocabulary rather than re-earn it, so the catalog
|
|
is global and the same word means the same thing in every install.
|
|
|
|
It is a convergence aid, never a gate: `systems.canonical_id` is nullable,
|
|
an unmapped System stays fully usable, and `record_systems` never sees this
|
|
table at all — the local name is a legitimate local label and is never
|
|
rewritten to match.
|
|
|
|
`slug` is the match key, not a display value. It folds the spelling
|
|
differences that produced four names for one area on the author's own
|
|
instance ("CI & Release" / "CI and Release" / "CI & release"): an exact slug
|
|
hit maps automatically, and anything short of that becomes a proposal for a
|
|
human to confirm. See services/canonical_systems.canonical_slug.
|
|
"""
|
|
|
|
__tablename__ = "canonical_systems"
|
|
|
|
id: Mapped[int] = mapped_column(primary_key=True)
|
|
name: Mapped[str] = mapped_column(Text, nullable=False)
|
|
# Normalized match key — unique among LIVE rows, so a soft-deleted entry
|
|
# doesn't block recreating the same area (the partial-unique convention
|
|
# rules/topics already use).
|
|
slug: Mapped[str] = mapped_column(Text, nullable=False)
|
|
description: Mapped[str | None] = mapped_column(Text, nullable=True)
|
|
order_index: Mapped[int] = mapped_column(Integer, default=0, server_default="0")
|
|
|
|
__table_args__ = (
|
|
Index(
|
|
"uq_canonical_systems_slug", "slug",
|
|
unique=True, postgresql_where=text("deleted_at IS NULL"),
|
|
),
|
|
)
|
|
|
|
def to_dict(self) -> dict:
|
|
return {
|
|
"id": self.id,
|
|
"name": self.name,
|
|
"slug": self.slug,
|
|
"description": self.description,
|
|
"order_index": self.order_index,
|
|
"created_at": iso(self.created_at),
|
|
"updated_at": iso(self.updated_at),
|
|
}
|