bvandeusenandClaude Fable 5
bbee0d0db1
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 8s
CI & Build / integration (push) Successful in 24s
CI & Build / TypeScript typecheck (push) Successful in 32s
CI & Build / Python tests (push) Successful in 54s
CI & Build / Build & push image (push) Successful in 18s
The shape ledger showed the same test scaffolding defined over and over: _bind_user x12 (byte-identical), _dispose_engine x10 in three wordings, _no_supersession x3, _make_mock_session x7 in three subsets, a get-or-create User helper x2 (+3 inlined), and fifteen hand-rolled MagicMock note factories each re-explaining the same "an auto-MagicMock attribute is truthy" hazard (note 2109). Now: conftest.py carries _bind_user / _dispose_engine / _no_supersession as opt-in fixtures (pytestmark = usefixtures(...) per module, so unit tests pay nothing), and tests/helpers.py carries make_mock_session(), ensure_user() and fake_note(**attrs) — the hazard documented once, real values on every attribute the product reads. Call sites were rewritten by AST so titles with dashes and commas survived; the three SimpleNamespace _note stand-ins that only feed a single function stay local. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
40 lines
1.1 KiB
Python
40 lines
1.1 KiB
Python
"""get_knowledge_counts includes the 'process' type and counts it in total."""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
from tests.helpers import make_mock_session
|
|
|
|
|
|
def _grouped(rows):
|
|
r = MagicMock()
|
|
r.all.return_value = rows
|
|
return r
|
|
|
|
|
|
def _scalar(n):
|
|
r = MagicMock()
|
|
r.scalar_one.return_value = n
|
|
return r
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_counts_include_process_in_facet_and_total():
|
|
session = make_mock_session()
|
|
# 1) grouped non-task counts, 2) task count, 3) plan count
|
|
session.execute = AsyncMock(side_effect=[
|
|
_grouped([("note", 3), ("process", 2)]),
|
|
_scalar(1), # tasks
|
|
_scalar(0), # plans
|
|
])
|
|
with patch("scribe.services.knowledge.async_session") as cls:
|
|
cls.return_value = session
|
|
from scribe.services.knowledge import get_knowledge_counts
|
|
counts = await get_knowledge_counts(user_id=1)
|
|
|
|
assert counts["process"] == 2
|
|
# facet keys all present (setdefault)
|
|
for key in ("note", "task", "plan", "process"):
|
|
assert key in counts
|
|
# total = note(3) + task(1) + process(2)
|
|
assert counts["total"] == 6
|