bvandeusenandClaude Opus 5
0e10f6bb8a
CI & Build / Python lint (push) Failing after 3s
CI & Build / Plugin hooks (push) Failing after 12s
CI & Build / integration (push) Failing after 27s
CI & Build / TypeScript typecheck (push) Failing after 35s
CI & Build / Python tests (push) Failing after 37s
CI & Build / Build & push image (push) Skipped
Milestone 394, steps 5-8. Operator: "remove the always on rule functionality as the goal was to not have it at all since it didn't seem to work as expected." Unconditional preload had three failures the retrieval arms do not. It could not be MEASURED — a resident rule is in the context whether or not it mattered, so nothing distinguished "this governed the act" from "this was scenery", and it was the one surface structurally exempt from the scoreboard judging every other. It was SUMMARISED AWAY by compaction while the session went on believing it held the rules. And it CROWDED OUT the few rules that applied with the thirty that did not. WHAT GOES Schema (0100): rules.tier + ck_rules_tier, rule_versions.tier, rulebooks.always_on, and project_rulebook_exclusions — a table recording a project's opt-out of something that no longer binds it unasked. Tools: list_always_on_rules, exclude_always_on_rulebook, include_always_on_rulebook. Service: the same three plus rules_etag_for, _valid_tier and the whole etag family. The SessionStart preload and the write-path staleness arm go with them: nothing is resident, so nothing can have drifted since a session loaded it. THREE CALLS WORTH REVIEWING enter_project got NARROWER, not wider. Its filter was `always_on OR area-tagged`; dropping the tier arm leaves the deterministic half, so a project with no canonical-tagged Systems gets no bulk rules and reaches them by retrieval instead. Dropping the whole clause would have made that payload bigger than the preload this milestone deletes. Backups import tolerantly. A pre-394 archive carries tier, always_on and the retired inception choice; none is read, and the exclusion key is DROPPED rather than remapped, because restoring it would write data that validate_inception now rejects as unknown. The migration is irreversible in the way that matters and says so: downgrade recreates the columns at their defaults and cannot restore which rules were always-on. A value invented to fill a hole is not a measurement. THE INSTRUCTION SURFACES SAY THE HARDER THING Deleting "call list_always_on_rules()" is easy; replacing it is not, because the new model asks a session to trust something it cannot see. All three surfaces now say a session holds nothing, that rules arrive when work matches them, and — the half that got dangerous — that "no rule arrived" means "nothing matched", never "there is no rule". Under residency an empty session was rare and suspicious; it is now the ordinary state of most turns, so reading it as permission is wrong on nearly every turn rather than occasionally. That is #3720's defect at session scale. test_instruction_surfaces_agree is repointed rather than retired: its two halves collapsed into one instruction, and it gains a guard that every surface states what absence means. _INSTRUCTIONS is back at 1999/2000 — the inception clause paid for the longer HOW line. UI (rule 27, and the opportunity step 8 named) The tier selector is gone, and what replaces it is the point: `when_to_apply` is now the field that decides whether a rule is ever seen, so the editor marks it required, warns while it is empty, and both rule lists badge a trigger-less rule "never surfaces". A rule without one is not quiet, it is unreachable. TESTS Two files deleted outright — test_rules_etag.py and test_inception_rules.py tested subsystems that no longer exist. Elsewhere obsolete cases were removed and the rest repointed. One deserves naming: the wiring test asserted the act arms pass no `tier`, which had become an assertion that could not fail. It is repointed onto `kind`, which does still exist and where the same claim is live — a preference must reach a write exactly as a rule does. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011cPyzNnegXHr5iRMzzy5KJ
82 lines
4.1 KiB
Python
82 lines
4.1 KiB
Python
"""Project inception (milestone 297) — step 1: the record's shape.
|
|
|
|
The WHY a project inherits what it does lives on projects.inception; the
|
|
opt-out of an always-on rulebook is its own association table. Pure
|
|
validation is pinned here; the effects are step 3's integration tests.
|
|
"""
|
|
from scribe.models import Base
|
|
from scribe.models.project import Project
|
|
from scribe.models.rulebook import project_rulebook_exclusions
|
|
from scribe.services.inception import (
|
|
CHOICE_KEYS, INCEPTION_VIAS, is_decided, normalize_choices, validate_inception,
|
|
)
|
|
|
|
|
|
def test_project_carries_an_inception_record_and_to_dict_shows_it():
|
|
assert "inception" in Project.__table__.c
|
|
assert Project.__table__.c.inception.nullable # NULL = undecided
|
|
p = Project(user_id=1, title="x", inception=None)
|
|
assert p.to_dict()["inception"] is None and not is_decided(p)
|
|
p.inception = {"via": "mcp", "decided_at": "2026-08-22T00:00:00+00:00", "decided_by": 1,
|
|
"choices": normalize_choices({"seed_systems": True})}
|
|
assert is_decided(p) and p.to_dict()["inception"]["via"] == "mcp"
|
|
assert INCEPTION_VIAS == ("mcp", "ui", "legacy")
|
|
|
|
|
|
def test_exclusions_table_is_the_suppressions_sibling():
|
|
t = Base.metadata.tables["project_rulebook_exclusions"]
|
|
assert project_rulebook_exclusions is t
|
|
assert {c.name for c in t.primary_key.columns} == {"project_id", "rulebook_id"}
|
|
fks = {fk.column.table.name: fk.ondelete for c in t.columns for fk in c.foreign_keys}
|
|
assert fks == {"projects": "CASCADE", "rulebooks": "CASCADE"}
|
|
|
|
|
|
def test_validate_inception_pins_the_choice_vocabulary():
|
|
assert CHOICE_KEYS == ("subscribe_rulebooks", "design_system_id", "seed_systems")
|
|
assert validate_inception({}) is None
|
|
assert validate_inception({"subscribe_rulebooks": [2],
|
|
"design_system_id": 3, "seed_systems": True}) is None
|
|
assert validate_inception({"design_system_id": None}) is None
|
|
assert "must be an object" in validate_inception([])
|
|
assert "unknown inception choice" in validate_inception({"repo": "x"})
|
|
# The retired exclusion key is now an UNKNOWN key rather than a typed one,
|
|
# which is the right error: a caller still passing it is asking for a
|
|
# choice that no longer exists, and silently ignoring it would let them
|
|
# believe a rulebook had been declined.
|
|
assert "unknown inception choice" in validate_inception(
|
|
{"exclude_always_on_rulebooks": [1]})
|
|
assert "list of rulebook ids" in validate_inception({"subscribe_rulebooks": [0]})
|
|
assert "list of rulebook ids" in validate_inception({"subscribe_rulebooks": [True]})
|
|
assert "positive id or null" in validate_inception({"design_system_id": 0})
|
|
assert "positive id or null" in validate_inception({"design_system_id": True})
|
|
assert "true or false" in validate_inception({"seed_systems": "yes"})
|
|
|
|
|
|
def test_normalize_choices_is_canonical_and_complete():
|
|
out = normalize_choices({"subscribe_rulebooks": [3, 1, 3]})
|
|
assert out == {"subscribe_rulebooks": [1, 3],
|
|
"design_system_id": None, "seed_systems": False}
|
|
assert normalize_choices(None) == {"subscribe_rulebooks": [],
|
|
"design_system_id": None, "seed_systems": False}
|
|
|
|
|
|
def test_standard_systems_vocabulary_reads_the_catalog_not_a_constant():
|
|
"""The vocabulary moved from a module constant to the global catalog table
|
|
(milestone 307): a constant cannot be a foreign key, so nothing outside a
|
|
project could reference an area. The seed and the bootstrap ask must both
|
|
read the table, or the list they show and the list they mint diverge."""
|
|
import inspect
|
|
|
|
from scribe.services import systems as systems_svc
|
|
|
|
assert not hasattr(systems_svc, "STANDARD_SYSTEMS"), (
|
|
"the constant is gone — the catalog table is the single source"
|
|
)
|
|
source = inspect.getsource(systems_svc.seed_standard_systems)
|
|
assert "list_canonical_systems" in source
|
|
assert "canonical_id=entry.id" in source, (
|
|
"a seeded System must be mapped as it is created, or a project born "
|
|
"from the standard set still needs a reconciliation pass"
|
|
)
|
|
|