bvandeusen
8b069cc93f
CI & Build / Python lint (push) Successful in 3s
CI & Build / integration (push) Successful in 21s
CI & Build / TypeScript typecheck (push) Successful in 49s
CI & Build / Python tests (push) Successful in 57s
CI & Build / Build & push image (push) Successful in 1m5s
Run 2888 failed with 7 tests down, both causes mine. The real problem was a design flaw, not the tests: readable_notes_clause and browsable_notes_clause each opened their own DB session to fetch the caller's group ids. That made them unmockable at the call site, so every unrelated service test suddenly had to know they existed and stub them — four modules broke the moment a service started calling one, and one of my own stubs patched the wrong name (readable_* where the code had moved to browsable_*). Fixed at the root: group membership is now a SUBQUERY rather than a fetched list, so both clauses are synchronous pure functions with no session. One fewer round-trip per query, membership folded into the statement the caller was already running, and nothing for callers' tests to mock. The "no groups means no group arm" special case disappears too — an empty subquery simply matches nothing. Also: _fake_note in the process tool tests had no real user_id, so its auto-MagicMock attribute reached session.get(User, ...) through the new provenance check and SQLAlchemy rejected it. The fixture now takes a real user_id defaulting to the bound caller, which makes "is this shared?" meaningful, and gains a case asserting another user's process comes back flagged. Test assertions on compiled SQL are deliberately loose about formatting: the local env has no SQLAlchemy (rule #10), so they check that the arms exist rather than guessing at exact rendering. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLwAaV4DQEmVyn496HnEvt
46 lines
1.2 KiB
Python
46 lines
1.2 KiB
Python
"""get_knowledge_counts includes the 'process' type and counts it in total."""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
|
|
def _make_mock_session():
|
|
s = AsyncMock()
|
|
s.__aenter__ = AsyncMock(return_value=s)
|
|
s.__aexit__ = AsyncMock(return_value=False)
|
|
return s
|
|
|
|
|
|
def _grouped(rows):
|
|
r = MagicMock()
|
|
r.all.return_value = rows
|
|
return r
|
|
|
|
|
|
def _scalar(n):
|
|
r = MagicMock()
|
|
r.scalar_one.return_value = n
|
|
return r
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_counts_include_process_in_facet_and_total():
|
|
session = _make_mock_session()
|
|
# 1) grouped non-task counts, 2) task count, 3) plan count
|
|
session.execute = AsyncMock(side_effect=[
|
|
_grouped([("note", 3), ("process", 2)]),
|
|
_scalar(1), # tasks
|
|
_scalar(0), # plans
|
|
])
|
|
with patch("scribe.services.knowledge.async_session") as cls:
|
|
cls.return_value = session
|
|
from scribe.services.knowledge import get_knowledge_counts
|
|
counts = await get_knowledge_counts(user_id=1)
|
|
|
|
assert counts["process"] == 2
|
|
# facet keys all present (setdefault)
|
|
for key in ("note", "task", "plan", "process"):
|
|
assert key in counts
|
|
# total = note(3) + task(1) + process(2)
|
|
assert counts["total"] == 6
|