bvandeusenandClaude Fable 5
bbee0d0db1
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 8s
CI & Build / integration (push) Successful in 24s
CI & Build / TypeScript typecheck (push) Successful in 32s
CI & Build / Python tests (push) Successful in 54s
CI & Build / Build & push image (push) Successful in 18s
The shape ledger showed the same test scaffolding defined over and over: _bind_user x12 (byte-identical), _dispose_engine x10 in three wordings, _no_supersession x3, _make_mock_session x7 in three subsets, a get-or-create User helper x2 (+3 inlined), and fifteen hand-rolled MagicMock note factories each re-explaining the same "an auto-MagicMock attribute is truthy" hazard (note 2109). Now: conftest.py carries _bind_user / _dispose_engine / _no_supersession as opt-in fixtures (pytestmark = usefixtures(...) per module, so unit tests pay nothing), and tests/helpers.py carries make_mock_session(), ensure_user() and fake_note(**attrs) — the hazard documented once, real values on every attribute the product reads. Call sites were rewritten by AST so titles with dashes and commas survived; the three SimpleNamespace _note stand-ins that only feed a single function stay local. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
75 lines
2.9 KiB
Python
75 lines
2.9 KiB
Python
"""resolve_process precedence (id → exact title → substring) in services/notes.py.
|
|
|
|
Mocks async_session — no real DB, matching the other notes-service tests.
|
|
"""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
from tests.helpers import fake_note, make_mock_session
|
|
|
|
|
|
def _result(first=None, all_=None):
|
|
"""A SQLAlchemy-result mock exposing .scalars().first()/.all()."""
|
|
r = MagicMock()
|
|
r.scalars.return_value.first.return_value = first
|
|
r.scalars.return_value.all.return_value = all_ or []
|
|
return r
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resolve_process_by_numeric_id():
|
|
note = fake_note(id=5, title="Drift Audit")
|
|
session = make_mock_session()
|
|
# numeric id → first execute (id lookup) hits
|
|
session.execute = AsyncMock(side_effect=[_result(first=note)])
|
|
with patch("scribe.services.notes.async_session") as cls:
|
|
cls.return_value = session
|
|
from scribe.services.notes import resolve_process
|
|
found, candidates = await resolve_process(1, "5")
|
|
assert found is note
|
|
assert candidates == []
|
|
assert session.execute.await_count == 1
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resolve_process_exact_title_beats_substring():
|
|
note = fake_note(id=7, title="Drift Audit")
|
|
session = make_mock_session()
|
|
# non-digit → exact-title query (first execute) hits; substring never runs
|
|
session.execute = AsyncMock(side_effect=[_result(first=note)])
|
|
with patch("scribe.services.notes.async_session") as cls:
|
|
cls.return_value = session
|
|
from scribe.services.notes import resolve_process
|
|
found, candidates = await resolve_process(1, "Drift Audit")
|
|
assert found is note
|
|
assert candidates == []
|
|
assert session.execute.await_count == 1
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resolve_process_substring_returns_candidates():
|
|
n1 = fake_note(id=7, title="Drift Audit Remediation")
|
|
n2 = fake_note(id=9, title="Drift Audit Notes")
|
|
session = make_mock_session()
|
|
# exact miss, then substring returns two (most-recent first)
|
|
session.execute = AsyncMock(side_effect=[_result(first=None), _result(all_=[n1, n2])])
|
|
with patch("scribe.services.notes.async_session") as cls:
|
|
cls.return_value = session
|
|
from scribe.services.notes import resolve_process
|
|
found, candidates = await resolve_process(1, "drift")
|
|
assert found is n1
|
|
assert candidates == [{"id": 9, "title": "Drift Audit Notes"}]
|
|
assert session.execute.await_count == 2
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resolve_process_no_match():
|
|
session = make_mock_session()
|
|
session.execute = AsyncMock(side_effect=[_result(first=None), _result(all_=[])])
|
|
with patch("scribe.services.notes.async_session") as cls:
|
|
cls.return_value = session
|
|
from scribe.services.notes import resolve_process
|
|
found, candidates = await resolve_process(1, "nope")
|
|
assert found is None
|
|
assert candidates == []
|