bvandeusenandClaude Opus 5 441a1ac31d fix(#4016): records that cite each other are created together, and a guessed id is refused ...

Sessions predicted the ids their next creates would get and wrote them into
plan bodies and reference notes before the records existed. The database
never collides; the sequence is shared by every session and user, so any
concurrent create took the guessed numbers and the references pointed at
someone else's records.

- create_records (new MCP tool) and start_planning(body=, steps=) create
  their records in ONE transaction: insert, flush for the real ids, rewrite
  {{ref:N}} / {{ref:milestone}} placeholders as #id "title", commit. No
  prediction, no waiting, no stub records left behind when a batch fails.
  Ids need not be consecutive and nothing depends on it.
- Every MCP create/update of a note, task or milestone refuses a #N sitting
  just above the highest assigned id (within 50): that can only be a guess.
  Refusal, not warning. Numbers far above the max (PRs, forge issues) pass.
- notes.build_note splits validation out of create_note so the batch
  validates records exactly as a single create does.
- writing-plans and using-scribe say to pass steps up front and never write
  an unassigned id; plugin version minted.

Integration test runs six concurrent batches and checks each resolves its
placeholders to its own records, and that a failing batch writes nothing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

2026-09-14 08:33:56 -04:00

..

fixtures/fabledrulebook_sample

feat(rulebook): port script — parse FabledRulebook .md → Scribe DB

2026-05-27 22:39:50 -04:00

__init__.py

Add Forgejo Actions CI/CD, ruff linting, and test foundation

2026-03-08 18:46:54 -04:00

conftest.py

feat(rules): the write path can notice a standing rule it was never given (#3031, milestone 307 step 5, hook arm)

2026-08-26 16:35:36 -04:00

helpers.py

feat(rules)!: retire the always-on tier — every rule arrives by retrieval (#394)

2026-09-11 16:22:17 -04:00

test_after_write_hook.py

test(hooks): the two tests that read a refused connection as "nothing recorded" now answer through a sink, and the silence case removes the shape it had left behind (#2932)

2026-08-23 11:05:42 -04:00

test_api_keys.py

refactor(services): one periodic-task shape, one APScheduler job shape, one token hash, one summary rule — the services pass of the shape audit (#2830, milestone 296)

2026-08-21 12:34:28 -04:00

test_check_design_tokens.py

feat(ci): check the app's own components against the tokens, not just snippets

2026-07-31 14:52:06 -04:00

test_chunking.py

feat(embeddings): best-chunk-per-note on every retrieval surface (#280 step 4)

2026-08-08 23:51:01 -04:00

test_create_tools_disambiguate.py

fix(#4016): records that cite each other are created together, and a guessed id is refused

2026-09-14 08:33:56 -04:00

test_design_cascade.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_design_starter_roles.py

feat(design): offer starter token ROLES at creation, never values

2026-08-03 11:37:20 -04:00

test_design_stylesheet.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_embedding_text.py

refactor(embeddings): one definition of the document a record is embedded as

2026-08-07 13:01:45 -04:00

test_embedding_yields_to_a_delete.py

fix(embeddings): the index refresh loses the race it used to deadlock (#3262)

2026-08-31 08:09:09 -04:00

test_embeddings.py

chore: remove pre-pivot dead code + finish Scribe rebrand (#599 t1-3)

2026-06-03 16:16:44 -04:00

test_forge_webhook.py

refactor(tests): one definition each for the copied fixtures and fakes (#2825, milestone 296 area 1)

2026-08-21 11:03:48 -04:00

test_frontend_request_deadlines.py

fix(frontend): every request carries a deadline, and expiry arrives as an error callers already handle (#3412)

2026-09-02 14:59:41 -04:00

test_import_fabledrulebook.py

feat(rulebook): port script — parse FabledRulebook .md → Scribe DB

2026-05-27 22:39:50 -04:00

test_inception.py

fix(394): unbreak collection, the TS typecheck and the plugin version

2026-09-11 16:26:56 -04:00

test_instruction_surfaces_agree.py

feat(rules)!: retire the always-on tier — every rule arrives by retrieval (#394)

2026-09-11 16:22:17 -04:00

test_integration_backup_note_roundtrip.py

fix(backup): a restore stops flattening the record vocabulary, and a column guard stops the next one (#3182)

2026-08-28 15:22:50 -04:00

test_integration_backup_rule_usage_roundtrip.py

feat(telemetry): rule_usage_events — the table, the service, and a restore that maps rule ids through the rule map (#3315)

2026-09-02 16:55:22 -04:00

test_integration_backup_rule_version_roundtrip.py

feat(rules)!: retire the always-on tier — every rule arrives by retrieval (#394)

2026-09-11 16:22:17 -04:00

test_integration_db_maintenance.py

refactor(tests): one definition each for the copied fixtures and fakes (#2825, milestone 296 area 1)

2026-08-21 11:03:48 -04:00

test_integration_embedding_yields_to_delete.py

fix(embeddings): the index refresh loses the race it used to deadlock (#3262)

2026-08-31 08:09:09 -04:00

test_integration_forge_keyring.py

refactor(tests): one definition each for the copied fixtures and fakes (#2825, milestone 296 area 1)

2026-08-21 11:03:48 -04:00

test_integration_inception.py

feat(rules)!: retire the always-on tier — every rule arrives by retrieval (#394)

2026-09-11 16:22:17 -04:00

test_integration_pgvector_search.py

refactor(tests): one definition each for the copied fixtures and fakes (#2825, milestone 296 area 1)

2026-08-21 11:03:48 -04:00

test_integration_record_batch.py

fix(#4016): records that cite each other are created together, and a guessed id is refused

2026-09-14 08:33:56 -04:00

test_integration_rule_kind.py

feat(rules): a preference is a rule that does not bind (#3849 step 1)

2026-09-10 21:14:29 -04:00

test_integration_rule_surfacing.py

fix(394): the co_surfaces test could no longer fail, so it was repaired not relaxed

2026-09-11 16:38:14 -04:00

test_integration_rule_verification.py

feat(rules)!: retire the always-on tier — every rule arrives by retrieval (#394)

2026-09-11 16:22:17 -04:00

test_integration_rule_versions.py

feat(rules): the history is readable — service, REST and MCP (#3242, milestone 323 step 3)

2026-08-29 23:46:15 -04:00

test_integration_shape_classify.py

test(ledger): the transition/prefix references clear the flag end to end; plugin 0.1.45 (#2970)

2026-08-23 21:30:21 -04:00

test_integration_snippet_locations.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_integration_task_kind_spike.py

fix(tasks): a task's kind is correctable — the Kind select stops lying (#3129)

2026-08-27 15:55:04 -04:00

test_knowledge_facets.py

fix(knowledge): the browse vocabulary catches up three kinds, and a snippet's mirror survives the generic door (#3128 recs 2-6)

2026-08-28 12:06:43 -04:00

test_mcp_auth.py

refactor(mcp): one rules_payload() for every surface that hands rules to an agent; drop the dead bearer resolver (#2828, milestone 296 area 4)

2026-08-21 11:20:36 -04:00

test_mcp_context.py

refactor: rename package fabledassistant -> scribe (code-only)

2026-06-03 15:48:35 -04:00

test_mcp_endpoint.py

refactor: rename package fabledassistant -> scribe (code-only)

2026-06-03 15:48:35 -04:00

test_mcp_list_family.py

refactor(plugin+tests): the last two parallel-family gaps — pageable list tools, one config preamble (#2278)

2026-08-24 01:28:07 -04:00

test_mcp_strict_args.py

fix(mcp): reject undeclared tool arguments instead of silently dropping them (#2709)

2026-08-17 12:54:58 -04:00

test_mcp_tool_create_records.py

fix(#4016): records that cite each other are created together, and a guessed id is refused

2026-09-14 08:33:56 -04:00

test_mcp_tool_design_systems.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_mcp_tool_milestones.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_mcp_tool_notes.py

fix(scribe): a delete must not depend on the lookup that names it (#3273)

2026-08-30 13:17:52 -04:00

test_mcp_tool_planning.py

fix(#4016): records that cite each other are created together, and a guessed id is refused

2026-09-14 08:33:56 -04:00

test_mcp_tool_processes.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_mcp_tool_projects.py

feat(rules)!: retire the always-on tier — every rule arrives by retrieval (#394)

2026-09-11 16:22:17 -04:00

test_mcp_tool_rulebooks.py

feat(rules)!: retire the always-on tier — every rule arrives by retrieval (#394)

2026-09-11 16:22:17 -04:00

test_mcp_tool_search.py

refactor(tests): one definition each for the copied fixtures and fakes (#2825, milestone 296 area 1)

2026-08-21 11:03:48 -04:00

test_mcp_tool_snippets.py

fix(scribe): a delete must not depend on the lookup that names it (#3273)

2026-08-30 13:17:52 -04:00

test_mcp_tool_systems.py

test(systems): move the name-gate cases to the service the gate moved into (#3028)

2026-08-26 13:02:09 -04:00

test_mcp_tool_tags.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_mcp_tool_tasks_kind.py

fix(tasks): a task's kind is correctable — the Kind select stops lying (#3129)

2026-08-27 15:55:04 -04:00

test_mcp_tool_tasks.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_mcp_tool_trash.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_note_usage.py

feat(retrieval): the standing-rule arm gets its own bar, and asks for one rule not two (#3318)

2026-09-02 18:05:00 -04:00

test_notes_description_field.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_pattern_coverage.py

feat(ledger): the consumer map reads transition names and concatenated prefixes (#2970)

2026-08-23 21:27:27 -04:00

test_plugin_shipped_set.py

refactor(plugin): retire what the hand-bump scheme left behind — the README that taught it, the floor test, the stale rationale (#3328)

2026-09-02 00:38:50 -04:00

test_plugin_version_mint.py

fix(plugin): mint() rendered whatever offset it was handed, not UTC (#3327)

2026-09-02 00:15:45 -04:00

test_preference_write_path.py

feat(rules): a preference updates without asking, and says what taught it (#3849 step 2)

2026-09-10 21:59:23 -04:00

test_pull_telemetry.py

fix(telemetry): the human half of the pull ledger recorded one kind in three

2026-08-06 08:51:21 -04:00

test_records_are_named_not_numbered.py

fix(rules): the staleness signal must not wait for prior art to match (#3244)

2026-08-30 13:10:04 -04:00

test_recurrence.py

fix(tests): the recurrence stand-ins come from fake_note, not a bare MagicMock (#3164)

2026-08-28 16:01:28 -04:00

test_retrieval_query_scrubbing.py

fix(telemetry): migration 0099 matched inside words and mangled rows (#3925)

2026-09-11 20:11:43 -04:00

test_retrieval_scopes.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_routes_dashboard.py

refactor: rename package fabledassistant -> scribe (code-only)

2026-06-03 15:48:35 -04:00

test_routes_db_maintenance.py

feat(db): table-health readout — per-table bloat metrics in admin card

2026-06-14 17:53:24 -04:00

test_routes_design_systems.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_routes_planning.py

refactor: rename package fabledassistant -> scribe (code-only)

2026-06-03 15:48:35 -04:00

test_routes_rulebooks.py

feat(rules)!: retire the always-on tier — every rule arrives by retrieval (#394)

2026-09-11 16:22:17 -04:00

test_routes_snippets.py

feat(snippets): un-merge — reverse one source out of a merged survivor

2026-07-28 18:42:29 -04:00

test_routes_systems.py

feat(issues): S3 REST routes — systems CRUD + project open-issues

2026-06-13 23:14:54 -04:00

test_routes_tasks_kind.py

refactor: rename package fabledassistant -> scribe (code-only)

2026-06-03 15:48:35 -04:00

test_routes_trash.py

refactor: rename package fabledassistant -> scribe (code-only)

2026-06-03 15:48:35 -04:00

test_rule_creation_asks_first.py

feat(rules): the rule gate becomes a practice with a question, not a prohibition (#3557)

2026-09-04 20:11:42 -04:00

test_rule_hint_band.py

fix(rules): a shortened rule line must not decide what it says about holding (#3851)

2026-09-11 14:07:32 -04:00

test_rule_ledger_ageing.py

feat(rules)!: retire the always-on tier — every rule arrives by retrieval (#394)

2026-09-11 16:22:17 -04:00

test_rule_usage_wiring.py

fix(394): subscription is the scope — areas narrow only where an author asked

2026-09-11 16:33:16 -04:00

test_search_route.py

refactor: rename package fabledassistant -> scribe (code-only)

2026-06-03 15:48:35 -04:00

test_services_access_visibility.py

fix(knowledge): the browse vocabulary catches up three kinds, and a snippet's mirror survives the generic door (#3128 recs 2-6)

2026-08-28 12:06:43 -04:00

test_services_backup.py

fix(394): subscription is the scope — areas narrow only where an author asked

2026-09-11 16:33:16 -04:00

test_services_canonical_systems.py

feat(systems): the area vocabulary becomes a global table so a rule can point at one (#3027, milestone 307 step 1)

2026-08-26 12:31:18 -04:00

test_services_dashboard.py

feat(ui): task rows show their kind — a badge for issue and spike (#3124)

2026-08-27 18:43:45 -04:00

test_services_db_maintenance.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_services_dedup.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_services_design_systems.py

refactor(tests): one definition each for the copied fixtures and fakes (#2825, milestone 296 area 1)

2026-08-21 11:03:48 -04:00

test_services_forge.py

feat(forge): per-user forge connections — keyring, host-keyed resolution, project pin (#2778)

2026-08-19 11:23:22 -04:00

test_services_knowledge_counts.py

fix(knowledge): the browse vocabulary catches up three kinds, and a snippet's mirror survives the generic door (#3128 recs 2-6)

2026-08-28 12:06:43 -04:00

test_services_notes_process.py

refactor(tests): one definition each for the copied fixtures and fakes (#2825, milestone 296 area 1)

2026-08-21 11:03:48 -04:00

test_services_notes_sweep.py

fix(tests): the sweep assertions read the WHERE clause, not the SELECT list (#3166)

2026-08-28 16:59:41 -04:00

test_services_notes_task_kind.py

refactor(tests): one definition each for the copied fixtures and fakes (#2825, milestone 296 area 1)

2026-08-21 11:03:48 -04:00

test_services_notes_verification.py

feat(notes): a note's check is writable through both doors, and empty means empty (#3164, milestone 317 step 2)

2026-08-28 15:42:12 -04:00

test_services_notes.py

feat(embeddings): per-chunk rows — schema, write path, version-aware backfill (#280 steps 2+3)

2026-08-08 23:47:34 -04:00

test_services_planning.py

feat(plans): milestone-as-plan-container; retire kind=plan (T3)

2026-06-14 12:22:22 -04:00

test_services_plugin_context.py

feat(rules)!: retire the always-on tier — every rule arrives by retrieval (#394)

2026-09-11 16:22:17 -04:00

test_services_project_summaries.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_services_record_refs.py

fix(#4016): records that cite each other are created together, and a guessed id is refused

2026-09-14 08:33:56 -04:00

test_services_repo_bindings.py

feat(plugin): resolve session project from git remote, not a pinned project_id

2026-06-10 01:33:58 -04:00

test_services_retrieval_telemetry.py

feat(telemetry): record WHAT the bar turned away, not only how close it came (#3807)

2026-09-09 21:24:32 -04:00

test_services_rule_embeddings.py

feat(rules): rules become findable by meaning (#3030, milestone 307 step 4)

2026-08-26 15:00:49 -04:00

test_services_rule_usage.py

feat(telemetry): the preload emits, and the always-on set stops being unfalsifiable (#3473)

2026-09-02 23:06:40 -04:00

test_services_rulebooks.py

feat(rules)!: retire the always-on tier — every rule arrives by retrieval (#394)

2026-09-11 16:22:17 -04:00

test_services_snippets.py

feat(snippets): un-merge — reverse one source out of a merged survivor

2026-07-28 18:42:29 -04:00

test_services_supersession.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_services_systems.py

test(systems): move the name-gate cases to the service the gate moved into (#3028)

2026-08-26 13:02:09 -04:00

test_services_trash.py

refactor(tests): one definition each for the copied fixtures and fakes (#2825, milestone 296 area 1)

2026-08-21 11:03:48 -04:00

test_session_context_ledger.py

fix(plugin): the rule ledger clears when the context it describes is destroyed (#3749)

2026-09-09 00:04:33 -04:00

test_settings_defaults_agree.py

feat(settings): the two new retrieval bars get their controls (#3927)

2026-09-11 20:30:06 -04:00

test_shape_ledger.py

feat(ledger): the consumer map reads transition names and concatenated prefixes (#2970)

2026-08-23 21:27:27 -04:00

test_shared_provenance.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_shared_write_access.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_snippet_drift_check.py

feat(forge): push webhook flags drift at the moment the repo moves (#2691)

2026-08-16 13:05:00 -04:00

test_snippet_duplicates.py

feat(dedup): per-kind duplicate-report floors — notes/tasks default 0.93

2026-08-09 10:33:11 -04:00

test_snippet_live_body.py

fix(snippets): an annotated record is not a diverged one — a standing verdict vouches at its commit (#2782)

2026-08-23 22:36:04 -04:00

test_snippet_location_filter.py

feat(ledger): reason codes, case-insensitive repo filter, next action on the coverage line (#2874, milestone 294)

2026-08-21 15:14:34 -04:00

test_snippet_merge_provenance.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_snippet_mirror_generic_door.py

feat(notes): a note's check is writable through both doors, and empty means empty (#3164, milestone 317 step 2)

2026-08-28 15:42:12 -04:00

test_snippet_provenance.py

refactor(tests): one definition each for the copied fixtures and fakes (#2825, milestone 296 area 1)

2026-08-21 11:03:48 -04:00

test_snippet_unmerge.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_supersession_ranking.py

refactor(tests): one definition each for the copied fixtures and fakes (#2825, milestone 296 area 1)

2026-08-21 11:03:48 -04:00

test_timestamp_filters.py

fix(db): bind datetimes, not strings, when filtering timestamptz columns

2026-07-30 12:53:57 -04:00

test_trash_filtering.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_trigger_shape_is_taught.py

feat(rules): the trigger contract is shown as a worked contrast, and pinned (#3855)

2026-09-11 11:48:14 -04:00

test_tz_helpers.py

refactor: rename package fabledassistant -> scribe (code-only)

2026-06-03 15:48:35 -04:00

test_utils.py

refactor: rename package fabledassistant -> scribe (code-only)

2026-06-03 15:48:35 -04:00

test_verification_guidance_survives.py

docs(notes): the surfaces say WHEN a note earns a check, and a guard keeps them saying it (#3168, milestone 317 step 5)

2026-08-29 00:10:43 -04:00

test_version_endpoint.py

fix(ci): /api/version reported the channel where the build belongs (rule 149)

2026-08-31 00:45:22 -04:00

test_version_pinning_pin_unpin.py

refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

2026-08-21 11:13:17 -04:00

test_version_pinning_prune.py

fix(tests): import make_mock_session in test_version_pinning_prune (batch-2 follow-up)

2026-08-21 11:14:44 -04:00

test_version_pinning_scan.py

refactor: rename package fabledassistant -> scribe (code-only)

2026-06-03 15:48:35 -04:00

test_version_readout.py

feat(frontend): the app says what it is running, and says so honestly when it cannot find out (#3329)

2026-09-02 11:23:43 -04:00

test_write_path_trigger.py

feat(rules): the command arm gets its own bar, measured (#3853)

2026-09-11 14:36:18 -04:00