bvandeusenandClaude Opus 5.5
41e4fbaba1
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 15s
CI & Build / TypeScript typecheck (push) Successful in 53s
CI & Build / integration (push) Successful in 54s
CI & Build / Python tests (push) Failing after 1m13s
CI & Build / Build & push image (push) Skipped
The link between a lesson (one concrete situation) and the rule that governs it, with the operator's soft-then-hard design built into its state: suggested while evidence accumulates, confirmed or rejected once judged. Only confirmed will carry a rule in retrieval (#4633); rejected is kept so the pair is never proposed again. - models/lesson_rule_link.py + migration 0111: one row per (lesson, rule), CASCADE on both ends, indexed both ways, CHECK on state (rule 36), evidence JSONB and judged_at. - services/lesson_rules.py: require_rules (validated before any write, so a bad id leaves nothing half-linked), set_lesson_rules (set-semantics; a dropped rule becomes rejected, not forgotten), judge_link, and the two reads. ACL: write on the lesson (share-aware), ownership of the rule; a reader sees only rules they own. Decorations are fail-open (#4286). - MCP: create_lesson / update_lesson take rule_ids; get/create/update return `rules`; new judge_lesson_link tool. REST: the same on /api/lessons plus PUT /api/lessons/<id>/rules/<rule_id>. Rules: rule_detail carries `lessons`. - Backup v18: export (full and user-scoped, both ends in scope), builder, importer; both column guards register the table. - Tests: integration (states, set-semantics, judge, ACL all-or-nothing, cascade both ways, CHECK, one row per pair); unit (door wiring, judge registered, migration/model state agreement, backup skip and unjudged stays unjudged). conftest stubs the decorations for unit tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
87 lines
4.5 KiB
Python
87 lines
4.5 KiB
Python
from sqlalchemy.ext.asyncio import AsyncSession, async_sessionmaker, create_async_engine
|
|
from sqlalchemy.orm import DeclarativeBase
|
|
|
|
from scribe.config import Config
|
|
|
|
# Named rather than inlined so the deadline below is READABLE. SQLAlchemy
|
|
# captures `connect_args` in a closure and merges it at connect time, so an
|
|
# inline dict cannot be recovered from the engine — and a guard that cannot
|
|
# read the value it guards is a guard that passes forever.
|
|
_CONNECT_ARGS: dict = {
|
|
# A DEADLINE ON ESTABLISHING A CONNECTION (#4181, rule 156).
|
|
#
|
|
# asyncpg's `timeout` bounds the CONNECT — the TCP handshake plus session
|
|
# setup — and nothing else. Against a host whose storage has wedged, that
|
|
# handshake does not fail, it waits, and without this the wait is
|
|
# asyncpg's own 60-second default: the entire lifespan budget spent before
|
|
# a single query is even sent. Ten seconds is far longer than a healthy
|
|
# local connect (single-digit milliseconds) and short enough to leave room
|
|
# to fail usefully rather than be killed.
|
|
#
|
|
# WHAT THIS DOES NOT COVER, said plainly so the next reader doesn't assume
|
|
# it does: a query on an already-open connection, which includes
|
|
# `pool_pre_ping`'s liveness check. Bounding those is `command_timeout`,
|
|
# and that is deliberately NOT set here — it would apply to every
|
|
# statement, and this app legitimately runs long ones (the embedding
|
|
# backfills, VACUUM ANALYZE). A blanket statement deadline would trade
|
|
# this failure mode for a worse one. Callers that must not hang — the
|
|
# lifespan hook above all — bound their own await instead; see
|
|
# `_STARTUP_READ_TIMEOUT` in services/db_maintenance_scheduler.py.
|
|
"timeout": 10,
|
|
}
|
|
|
|
engine = create_async_engine(
|
|
Config.DATABASE_URL,
|
|
echo=False,
|
|
pool_pre_ping=True,
|
|
pool_recycle=1800,
|
|
connect_args=_CONNECT_ARGS,
|
|
)
|
|
async_session = async_sessionmaker(engine, class_=AsyncSession, expire_on_commit=False)
|
|
|
|
|
|
class Base(DeclarativeBase):
|
|
pass
|
|
|
|
|
|
from scribe.models.base import CreatedAtMixin, TimestampMixin # noqa: E402, F401
|
|
|
|
|
|
from scribe.models.note import Note, TaskPriority, TaskStatus # noqa: E402, F401
|
|
from scribe.models.setting import Setting # noqa: E402, F401
|
|
from scribe.models.user import User # noqa: E402, F401
|
|
from scribe.models.app_log import AppLog # noqa: E402, F401
|
|
from scribe.models.password_reset import PasswordResetToken # noqa: E402, F401
|
|
from scribe.models.invitation import InvitationToken # noqa: E402, F401
|
|
from scribe.models.embedding import ( # noqa: E402, F401
|
|
MilestoneEmbedding, NoteEmbedding, RuleEmbedding, SystemEmbedding,
|
|
)
|
|
from scribe.models.retrieval_log import RetrievalLog # noqa: E402, F401
|
|
from scribe.models.retrieval_tuning import RetrievalTuningEvent # noqa: E402, F401
|
|
from scribe.models.note_usage import NoteUsageEvent # noqa: E402, F401
|
|
from scribe.models.rule_usage import RuleUsageEvent # noqa: E402, F401
|
|
from scribe.models.project import Project # noqa: E402, F401
|
|
from scribe.models.milestone import Milestone # noqa: E402, F401
|
|
from scribe.models.task_log import TaskLog # noqa: E402, F401
|
|
from scribe.models.note_draft import NoteDraft # noqa: E402, F401
|
|
from scribe.models.note_version import NoteVersion # noqa: E402, F401
|
|
from scribe.models.rule_version import RuleVersion # noqa: E402, F401
|
|
from scribe.models.note_supersession import NoteSupersession # noqa: E402, F401
|
|
from scribe.models.group import Group, GroupMembership # noqa: E402, F401
|
|
from scribe.models.share import NoteShare, ProjectShare # noqa: E402, F401
|
|
from scribe.models.notification import Notification # noqa: E402, F401
|
|
from scribe.models.api_key import ApiKey # noqa: E402, F401
|
|
from scribe.models.user_profile import UserProfile # noqa: E402, F401
|
|
# Imported before rulebook: rule_systems foreign-keys canonical_systems.
|
|
from scribe.models.canonical_system import CanonicalSystem # noqa: E402, F401
|
|
from scribe.models.rulebook import ( # noqa: E402, F401
|
|
Rulebook, RulebookTopic, Rule, RuleRelation, rule_systems,
|
|
)
|
|
# After notes and rules: it foreign-keys both (milestone 440).
|
|
from scribe.models.lesson_rule_link import LessonRuleLink # noqa: E402, F401
|
|
from scribe.models.repo_binding import RepoBinding # noqa: E402, F401
|
|
from scribe.models.forge_connection import ForgeConnection # noqa: E402, F401
|
|
from scribe.models.code_shape import CodeShape, CodeShapeConsumer, CodeShapeEvent, CodeShapeUse # noqa: E402, F401
|
|
from scribe.models.system import System, RecordSystem # noqa: E402, F401
|
|
from scribe.models.design_system import DesignSystem, DesignToken # noqa: E402, F401
|