bvandeusenandClaude Fable 5
bbee0d0db1
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 8s
CI & Build / integration (push) Successful in 24s
CI & Build / TypeScript typecheck (push) Successful in 32s
CI & Build / Python tests (push) Successful in 54s
CI & Build / Build & push image (push) Successful in 18s
The shape ledger showed the same test scaffolding defined over and over: _bind_user x12 (byte-identical), _dispose_engine x10 in three wordings, _no_supersession x3, _make_mock_session x7 in three subsets, a get-or-create User helper x2 (+3 inlined), and fifteen hand-rolled MagicMock note factories each re-explaining the same "an auto-MagicMock attribute is truthy" hazard (note 2109). Now: conftest.py carries _bind_user / _dispose_engine / _no_supersession as opt-in fixtures (pytestmark = usefixtures(...) per module, so unit tests pay nothing), and tests/helpers.py carries make_mock_session(), ensure_user() and fake_note(**attrs) — the hazard documented once, real values on every attribute the product reads. Call sites were rewritten by AST so titles with dashes and commas survived; the three SimpleNamespace _note stand-ins that only feed a single function stay local. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
62 lines
2.4 KiB
Python
62 lines
2.4 KiB
Python
"""ACL gating + field handling for services/systems.py (unit, mocked session)."""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
from tests.helpers import make_mock_session
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_system_denied_without_project_write():
|
|
with patch("scribe.services.systems.access") as acc:
|
|
acc.can_write_project = AsyncMock(return_value=False)
|
|
from scribe.services.systems import create_system
|
|
result = await create_system(user_id=1, project_id=5, name="Reader")
|
|
assert result is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_system_sets_fields_when_authorized():
|
|
mock_session = make_mock_session()
|
|
captured = {}
|
|
|
|
def _capture_add(obj):
|
|
captured["name"] = getattr(obj, "name", "MISSING")
|
|
captured["project_id"] = getattr(obj, "project_id", "MISSING")
|
|
|
|
mock_session.add = MagicMock(side_effect=_capture_add)
|
|
with patch("scribe.services.systems.async_session") as mock_cls, \
|
|
patch("scribe.services.systems.access") as acc:
|
|
acc.can_write_project = AsyncMock(return_value=True)
|
|
mock_cls.return_value = mock_session
|
|
from scribe.services.systems import create_system
|
|
await create_system(user_id=1, project_id=5, name=" Reader ")
|
|
assert captured["name"] == "Reader" # stripped
|
|
assert captured["project_id"] == 5
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_set_record_systems_denied_without_note_write():
|
|
with patch("scribe.services.systems.access") as acc:
|
|
acc.can_write_note = AsyncMock(return_value=False)
|
|
from scribe.services.systems import set_record_systems
|
|
result = await set_record_systems(user_id=1, note_id=9, system_ids=[1, 2])
|
|
assert result is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_systems_denied_returns_empty():
|
|
with patch("scribe.services.systems.access") as acc:
|
|
acc.can_read_project = AsyncMock(return_value=False)
|
|
from scribe.services.systems import list_systems
|
|
result = await list_systems(user_id=1, project_id=5)
|
|
assert result == []
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_count_open_issues_denied_returns_zero():
|
|
with patch("scribe.services.systems.access") as acc:
|
|
acc.can_read_project = AsyncMock(return_value=False)
|
|
from scribe.services.systems import count_open_issues
|
|
result = await count_open_issues(user_id=1, project_id=5)
|
|
assert result == 0
|