CI & Build / Python lint (push) Successful in 4s
CI & Build / Plugin hooks (push) Successful in 12s
CI & Build / integration (push) Successful in 27s
CI & Build / TypeScript typecheck (push) Successful in 33s
CI & Build / Python tests (push) Successful in 1m6s
CI & Build / Build & push image (push) Successful in 33s
Spike #3128 found the storage sound and the retrieval vocabulary frozen before `issue` shipped (0065). Five things, in the order they had to land. **The mirror (rec 5, the data-integrity one).** `notes.data` is DERIVED from a snippet's body, but only `update_snippet` knew that. `update_note` is a hasattr loop with no snippet awareness, and both doors reach it — so PATCH /api/notes/<snippet_id> {body} rewrote the body and left the mirror behind. `snippet_fields` PREFERS the mirror, so the row went on reporting its old repo/path/symbol to the location reverse lookup and to prior-art recall while displaying its new body: surfaced with full authority, and wrong. `snippets.recompose_data` rebuilds it from the body, carrying `verification` and `provenance` (neither is in the body to parse). An explicit `data` still wins, so every snippet-service write is untouched. **One facet table (rec 3), before adding any facet.** The type predicate was written three times — SQL, Python over semantic candidates, and a ternary computing the `is_task` pre-filter — and agreed only by luck. Adding `issue` to the SQL arm alone would have set the pre-filter to is_task=False, handed the Python arm a candidate set with no tasks in it, and returned an empty semantic half for the Issues facet forever with nothing red. `_FACETS` now generates all three. The Python arm also regains the `status IS NULL` half its SQL twin always had. **Issue and spike become facets (rec 2).** 435 issues — 17% of every task — were filterable nowhere on the human surface, while retired `plan` (90 rows) had a chip of its own. `_VALID_TYPES` was a hand-kept copy and is now derived. `plan` stays a valid facet for its legacy rows; it loses its chip. **Snippets stop being half-present in the feed (rec 4).** All 90 were in the All list, in no count, wearing an empty badge, and opening in the note editor. Counts now group by task_kind — every kind for the same two round-trips, which is why `issue` had no number — and total includes snippets, so the All chip matches the list it labels. Snippet cards route to /snippets/:id. **The prose that excused it (rec 6).** `snippet_fields` and the `data` column both still said pre-0070 rows were "never backfilled". True when 0070 landed, false since `backfill_snippet_data` shipped, and it read as licence for a stale mirror. Tests: the pre-filter can never exclude a row its own facet accepts (the regression, parameterised over every facet); both dialects select exactly their own rows; an unknown facet matches nothing; the mirror follows a body or title write, carries the verdict, and yields to an explicit `data`. `compiled_sql` moves to tests/helpers rather than becoming a third copy. Write-up: note #3161.
158 lines
6.0 KiB
Python
158 lines
6.0 KiB
Python
"""Unified Knowledge endpoint — every record kind in one queryable feed."""
|
|
import logging
|
|
|
|
from quart import Blueprint, jsonify, request
|
|
|
|
from scribe.auth import get_current_user_id, login_required
|
|
from scribe.routes.utils import parse_pagination
|
|
from scribe.services.access import label_shared_items
|
|
from scribe.services.knowledge import FACET_TYPES
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
knowledge_bp = Blueprint("knowledge", __name__, url_prefix="/api/knowledge")
|
|
|
|
# Derived from the service's facet table, never re-listed here. This set was a
|
|
# hand-kept copy and had drifted three kinds behind it: it admitted `plan`
|
|
# (retired in 0066) and rejected `issue` (shipped in 0065, 435 rows) and
|
|
# `snippet` — so the browse surface could not filter to the kinds it was
|
|
# already rendering badges for (#3128).
|
|
_VALID_TYPES = FACET_TYPES
|
|
_VALID_SORTS = {"modified", "created", "alpha", "type"}
|
|
|
|
|
|
@knowledge_bp.route("", methods=["GET"])
|
|
@login_required
|
|
async def list_knowledge():
|
|
"""Return paginated knowledge objects with optional filtering.
|
|
|
|
Query params:
|
|
type — a facet from services.knowledge._FACETS: a record type
|
|
(note|process|snippet) or a task kind (task for any,
|
|
else work|issue|spike|plan). Omit for all.
|
|
tags — comma-separated tag filter (AND logic)
|
|
sort — modified|created|alpha|type (default: modified)
|
|
q — search query (semantic when provided, keyword fallback)
|
|
page — 1-based page number (default 1)
|
|
per_page — items per page (default 24, max 100)
|
|
"""
|
|
uid = get_current_user_id()
|
|
note_type = request.args.get("type", "").strip().lower() or None
|
|
tags_raw = request.args.get("tags", "").strip()
|
|
tags = [t.strip() for t in tags_raw.split(",") if t.strip()] if tags_raw else []
|
|
sort = request.args.get("sort", "modified").strip().lower()
|
|
q = request.args.get("q", "").strip() or None
|
|
|
|
if note_type and note_type not in _VALID_TYPES:
|
|
return jsonify({"error": f"Invalid type. Must be one of: {', '.join(sorted(_VALID_TYPES))}"}), 400
|
|
if sort not in _VALID_SORTS:
|
|
sort = "modified"
|
|
|
|
limit, offset = parse_pagination(default_limit=24, max_limit=100)
|
|
page = max(1, int(request.args.get("page", 1)))
|
|
|
|
from scribe.services.knowledge import query_knowledge
|
|
items, total = await query_knowledge(
|
|
user_id=uid,
|
|
note_type=note_type,
|
|
tags=tags,
|
|
sort=sort,
|
|
q=q,
|
|
limit=limit,
|
|
offset=offset,
|
|
)
|
|
|
|
return jsonify({
|
|
# Mark rows another user owns: this feed can be mixed-ownership, and an
|
|
# unmarked card reads as one the viewer wrote.
|
|
"items": await label_shared_items(uid, items),
|
|
"total": total,
|
|
"page": page,
|
|
"per_page": limit,
|
|
"pages": max(1, (total + limit - 1) // limit),
|
|
})
|
|
|
|
|
|
@knowledge_bp.route("/ids", methods=["GET"])
|
|
@login_required
|
|
async def list_knowledge_ids():
|
|
"""Return note IDs only (cheap) for the two-tier pagination feed.
|
|
|
|
Same filter params as GET /api/knowledge.
|
|
Additional params: limit (default 100, max 200), offset (default 0).
|
|
Returns {ids, total, has_more}.
|
|
"""
|
|
uid = get_current_user_id()
|
|
note_type = request.args.get("type", "").strip().lower() or None
|
|
tags_raw = request.args.get("tags", "").strip()
|
|
tags = [t.strip() for t in tags_raw.split(",") if t.strip()] if tags_raw else []
|
|
sort = request.args.get("sort", "modified").strip().lower()
|
|
q = request.args.get("q", "").strip() or None
|
|
if sort not in _VALID_SORTS:
|
|
sort = "modified"
|
|
try:
|
|
limit = min(int(request.args.get("limit", 100)), 200)
|
|
offset = max(0, int(request.args.get("offset", 0)))
|
|
except ValueError:
|
|
return jsonify({"error": "Invalid limit or offset"}), 400
|
|
|
|
if note_type and note_type not in _VALID_TYPES:
|
|
return jsonify({"error": "Invalid type"}), 400
|
|
|
|
from scribe.services.knowledge import query_knowledge_ids
|
|
ids, total = await query_knowledge_ids(
|
|
user_id=uid, note_type=note_type, tags=tags,
|
|
sort=sort, q=q, limit=limit, offset=offset,
|
|
)
|
|
return jsonify({"ids": ids, "total": total, "has_more": (offset + len(ids)) < total})
|
|
|
|
|
|
@knowledge_bp.route("/batch", methods=["GET"])
|
|
@login_required
|
|
async def get_knowledge_batch():
|
|
"""Fetch full items for a comma-separated list of IDs (max 100).
|
|
|
|
Returns {items: [...]} in the order of the requested IDs.
|
|
"""
|
|
uid = get_current_user_id()
|
|
ids_raw = request.args.get("ids", "").strip()
|
|
if not ids_raw:
|
|
return jsonify({"items": []})
|
|
try:
|
|
ids = [int(x) for x in ids_raw.split(",") if x.strip()]
|
|
except ValueError:
|
|
return jsonify({"error": "Invalid IDs"}), 400
|
|
if len(ids) > 100:
|
|
return jsonify({"error": "Too many IDs (max 100)"}), 400
|
|
|
|
from scribe.services.knowledge import get_knowledge_by_ids
|
|
items = await get_knowledge_by_ids(uid, ids)
|
|
# The scrolling feed hydrates its cards here, not from the list route, so the
|
|
# ownership markers have to be applied on this path too.
|
|
return jsonify({"items": await label_shared_items(uid, items)})
|
|
|
|
|
|
@knowledge_bp.route("/tags", methods=["GET"])
|
|
@login_required
|
|
async def list_knowledge_tags():
|
|
"""Return all tags used across knowledge objects, narrowed to one facet."""
|
|
uid = get_current_user_id()
|
|
note_type = request.args.get("type", "").strip().lower() or None
|
|
|
|
from scribe.services.knowledge import get_knowledge_tags
|
|
tags = await get_knowledge_tags(uid, note_type=note_type)
|
|
return jsonify({"tags": tags})
|
|
|
|
|
|
@knowledge_bp.route("/counts", methods=["GET"])
|
|
@login_required
|
|
async def get_knowledge_counts():
|
|
"""Return per-type counts — used by the sidebar to show item counts."""
|
|
uid = get_current_user_id()
|
|
tags_raw = request.args.get("tags", "").strip()
|
|
tags = [t.strip() for t in tags_raw.split(",") if t.strip()] if tags_raw else None
|
|
|
|
from scribe.services.knowledge import get_knowledge_counts as _counts
|
|
counts = await _counts(uid, tags=tags)
|
|
return jsonify(counts)
|