bvandeusenandClaude Fable 5
77bb3729a3
CI & Build / Python lint (push) Successful in 4s
CI & Build / Plugin hooks (push) Successful in 8s
CI & Build / integration (push) Successful in 24s
CI & Build / TypeScript typecheck (push) Successful in 33s
CI & Build / Python tests (push) Failing after 36s
CI & Build / Build & push image (push) Skipped
Second pass over the tests/ ledger after bbee0d0. fake_record(**attrs) is the
one MagicMock-with-real-attributes builder (to_dict mirrors them; the
note-2109 hazard documented once); fake_note/fake_task/fake_snippet/
fake_project/fake_milestone/fake_system/fake_rulebook/fake_topic/fake_rule
carry each model's ordinary defaults on top of it, replacing 14 per-file
factories (two rulebook trios in tool-vs-service wordings, _fake_task, _fake_ms,
_fake_project, _plan_note, _fake_snippet, two _snippet adapters now one-liners
over fake_snippet). FakeMCP replaces the five closure-over-a-list registrar
fakes (+ _Recorder); loc() and design_token_stub() replace the paired _loc /
_token / _T stand-ins; every hand-built async_session mock (9 helper defs and
14 inline copies) now starts from make_mock_session(). Call sites rewritten by
AST with each file's former defaults made explicit, so behaviour is unchanged.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
126 lines
4.3 KiB
Python
126 lines
4.3 KiB
Python
"""Tests for manual pin / unpin on note versions."""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
from tests.helpers import make_mock_session
|
|
|
|
|
|
def _mock_session_for_version(mock_version):
|
|
mock_session = make_mock_session()
|
|
result = MagicMock()
|
|
result.scalars.return_value.first.return_value = mock_version
|
|
mock_session.execute = AsyncMock(return_value=result)
|
|
mock_session.commit = AsyncMock()
|
|
mock_session.refresh = AsyncMock()
|
|
return mock_session
|
|
|
|
|
|
async def test_pin_version_sets_manual_kind_and_label():
|
|
mock_version = MagicMock()
|
|
mock_version.pin_kind = None
|
|
mock_version.pin_label = None
|
|
|
|
with patch(
|
|
"scribe.services.version_pinning.async_session",
|
|
return_value=_mock_session_for_version(mock_version),
|
|
):
|
|
from scribe.services.version_pinning import pin_version
|
|
result = await pin_version(
|
|
user_id=1, note_id=42, version_id=7, label="the runbook circa Q2",
|
|
)
|
|
|
|
assert result is mock_version
|
|
assert mock_version.pin_kind == "manual"
|
|
assert mock_version.pin_label == "the runbook circa Q2"
|
|
|
|
|
|
async def test_pin_version_accepts_null_label():
|
|
"""label is optional — pinning with no label is allowed."""
|
|
mock_version = MagicMock()
|
|
mock_version.pin_kind = None
|
|
mock_version.pin_label = None
|
|
|
|
with patch(
|
|
"scribe.services.version_pinning.async_session",
|
|
return_value=_mock_session_for_version(mock_version),
|
|
):
|
|
from scribe.services.version_pinning import pin_version
|
|
await pin_version(user_id=1, note_id=42, version_id=7, label=None)
|
|
|
|
assert mock_version.pin_kind == "manual"
|
|
assert mock_version.pin_label is None
|
|
|
|
|
|
async def test_pin_version_promotes_auto_to_manual_with_label_update():
|
|
"""Pinning an already-auto-pinned version promotes it and updates label."""
|
|
mock_version = MagicMock()
|
|
mock_version.pin_kind = "auto"
|
|
mock_version.pin_label = "stable 2026-04-01 → 2026-04-05"
|
|
|
|
with patch(
|
|
"scribe.services.version_pinning.async_session",
|
|
return_value=_mock_session_for_version(mock_version),
|
|
):
|
|
from scribe.services.version_pinning import pin_version
|
|
await pin_version(
|
|
user_id=1, note_id=42, version_id=7, label="post-network-refresh",
|
|
)
|
|
|
|
assert mock_version.pin_kind == "manual"
|
|
assert mock_version.pin_label == "post-network-refresh"
|
|
|
|
|
|
async def test_pin_version_rejects_overlong_label():
|
|
"""Labels are capped at 500 chars to keep the UI sane."""
|
|
mock_version = MagicMock()
|
|
mock_version.pin_kind = None
|
|
|
|
# The cap is checked before any DB access, so the session shouldn't
|
|
# even be entered. We still patch it to avoid accidental DB lookups
|
|
# if the implementation order changes.
|
|
with patch(
|
|
"scribe.services.version_pinning.async_session",
|
|
return_value=_mock_session_for_version(mock_version),
|
|
):
|
|
from scribe.services.version_pinning import pin_version
|
|
try:
|
|
await pin_version(
|
|
user_id=1, note_id=42, version_id=7, label="x" * 501,
|
|
)
|
|
assert False, "expected ValueError"
|
|
except ValueError as e:
|
|
assert "500" in str(e) or "long" in str(e).lower()
|
|
|
|
|
|
async def test_pin_version_returns_none_when_not_found():
|
|
mock_session = make_mock_session()
|
|
result = MagicMock()
|
|
result.scalars.return_value.first.return_value = None
|
|
mock_session.execute = AsyncMock(return_value=result)
|
|
mock_session.commit = AsyncMock()
|
|
mock_session.refresh = AsyncMock()
|
|
|
|
with patch(
|
|
"scribe.services.version_pinning.async_session",
|
|
return_value=mock_session,
|
|
):
|
|
from scribe.services.version_pinning import pin_version
|
|
out = await pin_version(user_id=1, note_id=42, version_id=99, label=None)
|
|
|
|
assert out is None
|
|
|
|
|
|
async def test_unpin_version_clears_kind_and_label():
|
|
mock_version = MagicMock()
|
|
mock_version.pin_kind = "manual"
|
|
mock_version.pin_label = "previous label"
|
|
|
|
with patch(
|
|
"scribe.services.version_pinning.async_session",
|
|
return_value=_mock_session_for_version(mock_version),
|
|
):
|
|
from scribe.services.version_pinning import unpin_version
|
|
result = await unpin_version(user_id=1, note_id=42, version_id=7)
|
|
|
|
assert result is mock_version
|
|
assert mock_version.pin_kind is None
|
|
assert mock_version.pin_label is None
|