bvandeusenandClaude Opus 5
0bcd4b5540
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 13s
CI & Build / integration (push) Successful in 49s
CI & Build / TypeScript typecheck (push) Successful in 57s
CI & Build / Python tests (push) Failing after 1m3s
CI & Build / Build & push image (push) Skipped
A rule's home is its scope now: a rule in a rulebook topic is global, a rule on a project applies to that project, and retrieval reads that directly (#4074). A subscription had stopped changing anything a session received; a suppression muted rules from a subscription. Operator, 2026-09-15: "we have global and project scoped rules, we don't need the subscriptions now." What goes, whole (rule 22): - Migration 0101 drops project_rulebook_subscriptions, project_rule_suppressions and project_topic_suppressions, and strips subscribe_rulebooks (and 394's leftover exclude_always_on_rulebooks) from stored inception choices. - Service, MCP and REST: subscribe/unsubscribe and the four suppress/unsuppress operations. The Subscribers checklist, the subscribe chips, the skip buttons and the Suppressed section in the rules UI. - Inception asks two questions (design system, seed Systems). create_project and decide_project_inception lose subscribe_rulebooks. - Backup v15 stops exporting the three sections; older archives still restore, the keys simply unread. Trash no longer hard-deletes suppression rows. What changes meaning: - get_applicable_rules is a project's LISTING: its own rules, plus the global rules tagged to an area it works in. Untagged global rules apply everywhere and arrive by retrieval, so they are not listed. A co_surfaces partner on a different project is not dragged in. - list_rules(project_id) lists that project's own rules. - rules_payload drops subscribed_rulebooks and suppressed_*; the handshake's brief form is project_rules alone. - using-scribe's "Where a new rule goes" and inception sections, tool docstrings and docs say global vs project. Plugin 2026.09.15.1620. Milestone 414 step 2. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01821k5B3Ysecp9fNYs92Kuy
144 lines
5.7 KiB
Python
144 lines
5.7 KiB
Python
"""Tests for fable_*_milestone tools."""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from scribe.mcp.tools.milestones import (
|
|
list_milestones, get_milestone, create_milestone, update_milestone,
|
|
)
|
|
from tests.helpers import fake_milestone
|
|
|
|
|
|
pytestmark = pytest.mark.usefixtures("_bind_user")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_milestones_returns_dict_with_progress():
|
|
rows = [{"id": 1, "title": "MS1", "status": "active", "total": 2}]
|
|
with patch(
|
|
"scribe.mcp.tools.milestones.milestones_svc.get_project_milestone_summary",
|
|
AsyncMock(return_value=rows),
|
|
):
|
|
out = await list_milestones(project_id=1)
|
|
assert out["milestones"] == rows
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_milestone_passes_through():
|
|
m = fake_milestone(id=5)
|
|
mock = AsyncMock(return_value=m)
|
|
with patch("scribe.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
|
out = await create_milestone(project_id=1, title="new", description="d")
|
|
assert out["id"] == 5
|
|
assert mock.call_args.kwargs["project_id"] == 1
|
|
assert mock.call_args.kwargs["title"] == "new"
|
|
assert mock.call_args.kwargs["description"] == "d"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_milestone_empty_description_becomes_none():
|
|
m = fake_milestone()
|
|
mock = AsyncMock(return_value=m)
|
|
with patch("scribe.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
|
await create_milestone(project_id=1, title="t", description="")
|
|
assert mock.call_args.kwargs["description"] is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_milestone_passes_body_through():
|
|
"""The milestone-as-plan body is forwarded to the service."""
|
|
m = fake_milestone(id=5)
|
|
mock = AsyncMock(return_value=m)
|
|
with patch("scribe.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
|
await create_milestone(project_id=1, title="t", body="## Goal\n\nship")
|
|
assert mock.call_args.kwargs["body"] == "## Goal\n\nship"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_milestone_empty_body_becomes_none():
|
|
m = fake_milestone()
|
|
mock = AsyncMock(return_value=m)
|
|
with patch("scribe.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
|
await create_milestone(project_id=1, title="t", body="")
|
|
assert mock.call_args.kwargs["body"] is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_milestone_sends_body():
|
|
m = fake_milestone()
|
|
mock = AsyncMock(return_value=m)
|
|
with patch("scribe.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
|
await update_milestone(project_id=1, milestone_id=5, body="new plan")
|
|
assert mock.call_args.kwargs == {"body": "new plan"}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_milestone_returns_body_steps_and_rules():
|
|
m = fake_milestone(id=5, project_id=3, body="## Goal")
|
|
step = MagicMock()
|
|
step.to_dict.return_value = {"id": 9, "title": "step 1", "status": "todo"}
|
|
applicable = {"rules": [{"id": 1, "title": "r"}], "truncated": False,
|
|
"project_rules": [{"id": 3, "title": "own"}]}
|
|
with patch("scribe.mcp.tools.milestones.milestones_svc.get_milestone",
|
|
AsyncMock(return_value=m)), \
|
|
patch("scribe.mcp.tools.milestones.milestones_svc.get_milestone_progress",
|
|
AsyncMock(return_value={"total": 1, "completed": 0, "pct": 0.0})), \
|
|
patch("scribe.mcp.tools.milestones.notes_svc.list_notes",
|
|
AsyncMock(return_value=([step], 1))), \
|
|
patch("scribe.mcp.tools.milestones.rulebooks_svc.get_applicable_rules",
|
|
AsyncMock(return_value=applicable)):
|
|
out = await get_milestone(milestone_id=5)
|
|
assert out["milestone"]["body"] == "## Goal"
|
|
assert out["milestone"]["total"] == 1
|
|
assert out["steps"] == [{"id": 9, "title": "step 1", "status": "todo"}]
|
|
assert out["applicable_rules"] == [{"id": 1, "title": "r"}]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_milestone_raises_when_not_found():
|
|
with patch("scribe.mcp.tools.milestones.milestones_svc.get_milestone",
|
|
AsyncMock(return_value=None)):
|
|
with pytest.raises(ValueError, match="milestone 999 not found"):
|
|
await get_milestone(milestone_id=999)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_milestone_only_sends_non_default_fields():
|
|
m = fake_milestone()
|
|
mock = AsyncMock(return_value=m)
|
|
with patch("scribe.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
|
await update_milestone(project_id=1, milestone_id=5, status="done")
|
|
args, kwargs = mock.call_args
|
|
assert args == (7, 5)
|
|
assert kwargs == {"status": "done"}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_milestone_order_index_negative_is_omitted():
|
|
"""order_index=-1 sentinel means leave unchanged."""
|
|
m = fake_milestone()
|
|
mock = AsyncMock(return_value=m)
|
|
with patch("scribe.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
|
await update_milestone(project_id=1, milestone_id=5, order_index=-1)
|
|
assert "order_index" not in mock.call_args.kwargs
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_milestone_order_index_zero_is_explicit():
|
|
"""order_index=0 is a real value (top of list), not a sentinel."""
|
|
m = fake_milestone()
|
|
mock = AsyncMock(return_value=m)
|
|
with patch("scribe.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
|
await update_milestone(project_id=1, milestone_id=5, order_index=0)
|
|
assert mock.call_args.kwargs["order_index"] == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_milestone_raises_when_not_found():
|
|
with patch(
|
|
"scribe.mcp.tools.milestones.milestones_svc.update_milestone",
|
|
AsyncMock(return_value=None),
|
|
):
|
|
with pytest.raises(ValueError, match="milestone 999 not found"):
|
|
await update_milestone(project_id=1, milestone_id=999, title="x")
|