bvandeusenandClaude Fable 5
77bb3729a3
CI & Build / Python lint (push) Successful in 4s
CI & Build / Plugin hooks (push) Successful in 8s
CI & Build / integration (push) Successful in 24s
CI & Build / TypeScript typecheck (push) Successful in 33s
CI & Build / Python tests (push) Failing after 36s
CI & Build / Build & push image (push) Skipped
Second pass over the tests/ ledger after bbee0d0. fake_record(**attrs) is the
one MagicMock-with-real-attributes builder (to_dict mirrors them; the
note-2109 hazard documented once); fake_note/fake_task/fake_snippet/
fake_project/fake_milestone/fake_system/fake_rulebook/fake_topic/fake_rule
carry each model's ordinary defaults on top of it, replacing 14 per-file
factories (two rulebook trios in tool-vs-service wordings, _fake_task, _fake_ms,
_fake_project, _plan_note, _fake_snippet, two _snippet adapters now one-liners
over fake_snippet). FakeMCP replaces the five closure-over-a-list registrar
fakes (+ _Recorder); loc() and design_token_stub() replace the paired _loc /
_token / _T stand-ins; every hand-built async_session mock (9 helper defs and
14 inline copies) now starts from make_mock_session(). Call sites rewritten by
AST with each file's former defaults made explicit, so behaviour is unchanged.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
72 lines
2.5 KiB
Python
72 lines
2.5 KiB
Python
"""Tests for the description-field roundtrip through the notes service.
|
|
|
|
The description field is the user-stated goal/context on a task; distinct
|
|
from `body` which (post-Task-as-Durable-Record) becomes the LLM-maintained
|
|
consolidation summary.
|
|
"""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
from tests.helpers import make_mock_session
|
|
|
|
|
|
def _mock_session_for_update(mock_note):
|
|
mock_session = make_mock_session()
|
|
mock_result = MagicMock()
|
|
mock_result.scalars.return_value.first.return_value = mock_note
|
|
mock_session.execute = AsyncMock(return_value=mock_result)
|
|
mock_session.commit = AsyncMock()
|
|
mock_session.refresh = AsyncMock()
|
|
return mock_session
|
|
|
|
|
|
async def test_update_note_persists_description():
|
|
"""update_note(description=...) should assign to note.description.
|
|
|
|
update_note already accepts **fields and uses setattr, so this exercises
|
|
that the new model column is reachable through the existing dynamic-fields
|
|
path (no service-layer change required beyond the model column).
|
|
"""
|
|
mock_note = MagicMock()
|
|
# Pre-existing state — None description, no recurrence, status untouched.
|
|
mock_note.description = None
|
|
mock_note.status = None
|
|
mock_note.recurrence_rule = None
|
|
mock_note.project_id = None
|
|
|
|
with patch(
|
|
"scribe.services.notes.async_session",
|
|
return_value=_mock_session_for_update(mock_note),
|
|
):
|
|
from scribe.services.notes import update_note
|
|
await update_note(1, 1, description="the goal text")
|
|
|
|
assert mock_note.description == "the goal text"
|
|
|
|
|
|
async def test_create_note_forwards_description_to_model():
|
|
"""create_note(description=...) should pass description into the Note
|
|
constructor so it gets persisted alongside title/body/etc."""
|
|
captured: dict = {}
|
|
|
|
class FakeNote:
|
|
def __init__(self, **kw):
|
|
captured.update(kw)
|
|
self.id = 1
|
|
self.project_id = kw.get("project_id")
|
|
for k, v in kw.items():
|
|
setattr(self, k, v)
|
|
|
|
mock_session = make_mock_session()
|
|
mock_session.add = MagicMock()
|
|
mock_session.commit = AsyncMock()
|
|
mock_session.refresh = AsyncMock()
|
|
|
|
with patch(
|
|
"scribe.services.notes.async_session", return_value=mock_session
|
|
), patch("scribe.services.notes.Note", FakeNote):
|
|
from scribe.services.notes import create_note
|
|
await create_note(
|
|
user_id=1, title="renew cert", description="the goal text",
|
|
)
|
|
|
|
assert captured.get("description") == "the goal text"
|