bvandeusenandClaude Fable 5
a8f35e465e
CI & Build / Python lint (push) Successful in 4s
CI & Build / Plugin hooks (push) Successful in 27s
CI & Build / TypeScript typecheck (push) Successful in 36s
CI & Build / integration (push) Successful in 1m34s
CI & Build / Python tests (push) Successful in 2m21s
CI & Build / Build & push image (push) Successful in 25s
DRY pass 3's remainder. Both halves start from enumeration, because the task's
candidate list was hypotheses and the process requires counting before
proposing — and counting changed the answer twice.
## The list_* family: a limit with no offset
Enumerated all 19 `list_*` MCP tools first. They are genuinely heterogeneous —
8 take `project_id`, 6 take `limit`, six take no arguments at all — so a
common-parameter guard would invent a convention the API does not have, which
is the over-DRY trap (§5). One contract IS real: a `limit` without an `offset`
is a truncation with no continuation. The caller is told there are 250 results,
handed 50, and given no way to ask for the rest.
Two tools had it, and both were capped over a service that already accepted an
offset: `snippets_svc.list_snippets(offset=0)` was simply not exposed, and
`list_processes` passed a hardcoded `offset=0` into `query_knowledge`. The
capability existed one layer down in both; only the door was missing — the
missing-sibling shape exactly. Both now expose it.
`tests/test_mcp_list_family.py` guards it, with `list_tags` exempted for a
stated reason (a ranked top-N over a bounded vocabulary has no "rest" to page
into). Candidates derived, decision explicit, same design as test_mcp_auth —
plus the reverse checks: a stale exemption, and an offset with no limit, which
would page through an unbounded result set. Verified non-vacuous by running the
sweep against the pre-fix tree, where it fails naming both tools.
## The verb pairs: no finding, which is the finding
`preview`/`apply` and `dry_run`/`commit` do not exist anywhere in the 102
tools — those were guesses about a shape Scribe never adopted. `count_*` does
not exist either. Of the create/delete stems only `project_rule` lacks a
`delete_X`, and deliberately: a project rule IS a rule, `delete_rule` removes
it, and the docstring says so. `force` sits on 6 of 7 duplicate-gated creates;
the exception is `create_system`, whose gate is an exact normalized-NAME match
rather than a semantic near-match — forcing it would split one area's records
across two piles, which its own message explains. No guard added: it would
need a seven-entry exemption list to defend against a hypothetical. Recorded
on the leave-alone list instead, which the process asks for by name.
## The hook config preamble
Not 3 of 6 hooks as recorded — all FIVE carried their own copy, and of four
lines rather than two. The extra two are a guard treating an unexpanded
`${...}` placeholder as unset, so it is never sent as a garbage Bearer token:
precisely the correctness detail a sixth hook would omit with nothing failing
loudly. Now `scribe_config` in scribe_defs.sh, which also declares the two
names it owns. It sets globals rather than echoing, so a token never passes
through a subshell's output where xtrace or a log could catch it, and returns
a status so a caller can bail (`|| exit 0`) or continue degraded — the
session-context hook still owes its static floor when Scribe is unconfigured.
`check_plugin.py` now runs shellcheck with `-x`. Without it the shared helpers
were invisible: every variable they set read as unassigned and every bug inside
them went unlinted at the call site, which is the opposite of what sharing them
was for. All twelve fail-open scenarios still pass, and all five hooks were
probed live against the instance — prior_art and after_write both still name
canon, autoinject returns context, session_context serves 11k chars of rules,
sync_processes stays silent. Plugin 0.1.46 (#2209).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
83 lines
3.5 KiB
Bash
Executable File
83 lines
3.5 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Scribe plugin — sync stored Processes into auto-surfacing local skills.
|
|
#
|
|
# Fetches `GET /api/plugin/processes` and writes one
|
|
# ~/.claude/skills/scribe-proc-<slug>/SKILL.md
|
|
# per Process. The stub's frontmatter `description` is the auto-surface trigger;
|
|
# its body tells Claude to call get_process(<name>) and follow the LIVE procedure
|
|
# from Scribe (the DB stays the single source of truth — the stub is a pointer).
|
|
#
|
|
# WHY LOCAL ~/.claude/skills (not the plugin dir): the plugin is git-cloned and
|
|
# identical on every install, so instance-specific stubs can't live inside it.
|
|
# Personal skills in ~/.claude/skills are live-detected by Claude Code within the
|
|
# session, so a freshly written stub auto-surfaces without a restart.
|
|
#
|
|
# TRIGGERS: this runs at SessionStart (alongside the context hook) so stubs stay
|
|
# fresh each session, and on demand via the `/scribe:sync` command.
|
|
#
|
|
# FAIL-OPEN & SILENT: never blocks a session; emits NOTHING on stdout (so it's
|
|
# safe as a second SessionStart hook). On any fetch failure it exits without
|
|
# touching existing stubs — a transient outage must not wipe the user's skills.
|
|
# Config mirrors the context hook: CLAUDE_PLUGIN_OPTION_API_ENDPOINT /
|
|
# CLAUDE_PLUGIN_OPTION_API_TOKEN (userConfig key UPPERCASED by Claude Code — see
|
|
# #2198), with SCRIBE_URL / SCRIBE_TOKEN as the override.
|
|
set -uo pipefail
|
|
|
|
# shellcheck source=plugin/hooks/scribe_defs.sh
|
|
. "$(dirname "${BASH_SOURCE[0]}")/scribe_defs.sh"
|
|
|
|
command -v jq >/dev/null 2>&1 || exit 0
|
|
command -v curl >/dev/null 2>&1 || exit 0
|
|
|
|
scribe_config || exit 0
|
|
|
|
body=$(curl -fsS --max-time 8 \
|
|
-H "Authorization: Bearer ${token}" \
|
|
"${url%/}/api/plugin/processes" 2>/dev/null) || exit 0
|
|
[ -n "$body" ] || exit 0
|
|
|
|
count=$(printf '%s' "$body" | jq -r '.processes | length' 2>/dev/null) || exit 0
|
|
[ -n "$count" ] && [ "$count" != "null" ] || exit 0
|
|
|
|
skills_dir="${HOME}/.claude/skills"
|
|
mkdir -p "$skills_dir" 2>/dev/null || exit 0
|
|
|
|
# Slugs written this run — anything else under scribe-proc-* is pruned below.
|
|
managed=" "
|
|
|
|
i=0
|
|
while [ "$i" -lt "$count" ]; do
|
|
name=$(printf '%s' "$body" | jq -r ".processes[$i].name // empty" 2>/dev/null)
|
|
slug=$(printf '%s' "$body" | jq -r ".processes[$i].slug // empty" 2>/dev/null)
|
|
desc=$(printf '%s' "$body" | jq -r ".processes[$i].description // empty" 2>/dev/null)
|
|
i=$((i + 1))
|
|
[ -n "$slug" ] && [ -n "$name" ] || continue
|
|
|
|
dir="${skills_dir}/scribe-proc-${slug}"
|
|
mkdir -p "$dir" 2>/dev/null || continue
|
|
# description folded to one line — YAML scalar must not contain a newline.
|
|
desc=$(printf '%s' "$desc" | tr '\n' ' ')
|
|
{
|
|
printf -- '---\n'
|
|
printf 'name: scribe-proc-%s\n' "$slug"
|
|
printf 'description: %s\n' "$desc"
|
|
printf -- '---\n\n'
|
|
printf '<!-- GENERATED by the Scribe plugin (scribe_sync_processes.sh). Do not edit here; edit the Process in Scribe and re-sync with /scribe:sync. -->\n\n'
|
|
printf 'This is a saved **Scribe Process**: `%s`.\n\n' "$name"
|
|
printf 'Do not improvise it. Call `get_process("%s")` via the Scribe MCP server to fetch the live procedure, then follow the returned body verbatim — including any "clarify first" steps it contains.\n' "$name"
|
|
} > "${dir}/SKILL.md" 2>/dev/null || continue
|
|
managed="${managed}${slug} "
|
|
done
|
|
|
|
# Prune stubs whose Process no longer exists (scoped to our scribe-proc-* prefix).
|
|
for d in "${skills_dir}"/scribe-proc-*; do
|
|
[ -d "$d" ] || continue
|
|
slug=$(basename "$d"); slug=${slug#scribe-proc-}
|
|
case "$managed" in
|
|
*" $slug "*) : ;;
|
|
*) rm -rf "$d" 2>/dev/null ;;
|
|
esac
|
|
done
|
|
|
|
exit 0
|