bvandeusenandClaude Opus 5
a97547fbc6
CI & Build / Plugin hooks (push) Successful in 10s
CI & Build / TypeScript typecheck (push) Successful in 39s
CI & Build / Python lint (push) Successful in 4s
CI & Build / integration (push) Successful in 30s
CI & Build / Python tests (push) Failing after 56s
CI & Build / Build & push image (push) Skipped
The eight standard area names already existed — as STANDARD_SYSTEMS, a tuple in
services/systems.py that milestone 297 seeds at inception. A constant cannot be
a foreign key, so nothing outside a project could reference an area: systems.
project_id is NOT NULL, and a rule that spans projects would have to chain
itself to one project's row. And because the list only ever applied on the
inception-seed path, three spellings of one area reached this instance anyway
(CI & runners / CI and Release / CI & release).
- canonical_systems: global, no user_id — a shared project inherits the
vocabulary instead of re-earning it. Migration 0087 seeds the same eight.
- systems.canonical_id: nullable, SET NULL. Association only — no System is
renamed and record_systems is untouched, so no record's tags move.
- canonical_slug folds &/and, case and punctuation, so spelling variants map
mechanically and a real difference ("CI & runners") becomes a proposal a
human confirms. propose_mappings reports; set_system_canonical is the only
writer.
- seed_standard_systems now reads the catalog and maps as it mints, so a
project born standard never needs a reconciliation pass.
- Catalog writes are admin-only; reads are open — a global list anyone can
extend stops being shared.
- backup: carried by SLUG, not id (ids are per-install). Restore reuses the
target's own rows and only creates entries an admin added on the source; an
unknown slug restores unmapped rather than failing.
Rule 22: STANDARD_SYSTEMS is removed, not deprecated. Rule 115: nothing seeded
names an app, repo or house convention. Design in note 3026.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
84 lines
3.5 KiB
Python
84 lines
3.5 KiB
Python
from sqlalchemy import ForeignKey, Index, Integer, Text, UniqueConstraint
|
|
from sqlalchemy.orm import Mapped, mapped_column
|
|
|
|
from scribe.models import Base
|
|
from scribe.models.base import CreatedAtMixin, SoftDeleteMixin, TimestampMixin, iso
|
|
|
|
|
|
class System(Base, TimestampMixin, SoftDeleteMixin):
|
|
"""A per-project, reusable, self-describing subsystem/area.
|
|
|
|
Any record (note, task, or issue) can be associated with one or more
|
|
systems via record_systems, so research notes, build-tasks, and corrective
|
|
work line up under the same area — and recurring problem-areas become
|
|
filterable. Self-describing (name + description) because a bare name is
|
|
never enough to convey what a system is or how it's used.
|
|
"""
|
|
__tablename__ = "systems"
|
|
|
|
id: Mapped[int] = mapped_column(primary_key=True)
|
|
user_id: Mapped[int] = mapped_column(
|
|
Integer, ForeignKey("users.id", ondelete="CASCADE")
|
|
)
|
|
project_id: Mapped[int] = mapped_column(
|
|
Integer, ForeignKey("projects.id", ondelete="CASCADE")
|
|
)
|
|
name: Mapped[str] = mapped_column(Text, default="", server_default="")
|
|
# The GLOBAL area this local System is an instance of (milestone 307).
|
|
# Nullable and SET NULL on purpose: the catalog is a convergence aid, not a
|
|
# gate — an unmapped System is fully usable, and retiring a canonical entry
|
|
# must never take a project's System with it. The local `name` is NEVER
|
|
# rewritten to match the canonical one; this column is the join key, and
|
|
# the name stays whatever the project calls the area.
|
|
canonical_id: Mapped[int | None] = mapped_column(
|
|
Integer, ForeignKey("canonical_systems.id", ondelete="SET NULL"), nullable=True
|
|
)
|
|
description: Mapped[str | None] = mapped_column(Text, nullable=True)
|
|
color: Mapped[str | None] = mapped_column(Text, nullable=True)
|
|
# active | archived — systems accumulate; archive rather than delete.
|
|
status: Mapped[str] = mapped_column(Text, default="active", server_default="active")
|
|
order_index: Mapped[int] = mapped_column(Integer, default=0, server_default="0")
|
|
|
|
__table_args__ = (
|
|
Index("ix_systems_project_id", "project_id"),
|
|
)
|
|
|
|
def to_dict(self) -> dict:
|
|
return {
|
|
"id": self.id,
|
|
"user_id": self.user_id,
|
|
"project_id": self.project_id,
|
|
"name": self.name,
|
|
"canonical_id": self.canonical_id,
|
|
"description": self.description,
|
|
"color": self.color,
|
|
"status": self.status,
|
|
"order_index": self.order_index,
|
|
"created_at": iso(self.created_at),
|
|
"updated_at": iso(self.updated_at),
|
|
}
|
|
|
|
|
|
class RecordSystem(Base, CreatedAtMixin):
|
|
"""M2M association: a record (notes.id — any note/task/issue) <-> a System.
|
|
|
|
Mutable over time; uniqueness keeps a record from linking the same system
|
|
twice. Cascades on both sides, so deleting a record or a system clears its
|
|
associations.
|
|
"""
|
|
__tablename__ = "record_systems"
|
|
|
|
id: Mapped[int] = mapped_column(primary_key=True)
|
|
note_id: Mapped[int] = mapped_column(
|
|
Integer, ForeignKey("notes.id", ondelete="CASCADE")
|
|
)
|
|
system_id: Mapped[int] = mapped_column(
|
|
Integer, ForeignKey("systems.id", ondelete="CASCADE")
|
|
)
|
|
|
|
__table_args__ = (
|
|
UniqueConstraint("note_id", "system_id", name="uq_record_systems_note_system"),
|
|
Index("ix_record_systems_note_id", "note_id"),
|
|
Index("ix_record_systems_system_id", "system_id"),
|
|
)
|