bvandeusenandClaude Opus 5
0bcd4b5540
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 13s
CI & Build / integration (push) Successful in 49s
CI & Build / TypeScript typecheck (push) Successful in 57s
CI & Build / Python tests (push) Failing after 1m3s
CI & Build / Build & push image (push) Skipped
A rule's home is its scope now: a rule in a rulebook topic is global, a rule on a project applies to that project, and retrieval reads that directly (#4074). A subscription had stopped changing anything a session received; a suppression muted rules from a subscription. Operator, 2026-09-15: "we have global and project scoped rules, we don't need the subscriptions now." What goes, whole (rule 22): - Migration 0101 drops project_rulebook_subscriptions, project_rule_suppressions and project_topic_suppressions, and strips subscribe_rulebooks (and 394's leftover exclude_always_on_rulebooks) from stored inception choices. - Service, MCP and REST: subscribe/unsubscribe and the four suppress/unsuppress operations. The Subscribers checklist, the subscribe chips, the skip buttons and the Suppressed section in the rules UI. - Inception asks two questions (design system, seed Systems). create_project and decide_project_inception lose subscribe_rulebooks. - Backup v15 stops exporting the three sections; older archives still restore, the keys simply unread. Trash no longer hard-deletes suppression rows. What changes meaning: - get_applicable_rules is a project's LISTING: its own rules, plus the global rules tagged to an area it works in. Untagged global rules apply everywhere and arrive by retrieval, so they are not listed. A co_surfaces partner on a different project is not dragged in. - list_rules(project_id) lists that project's own rules. - rules_payload drops subscribed_rulebooks and suppressed_*; the handshake's brief form is project_rules alone. - using-scribe's "Where a new rule goes" and inception sections, tool docstrings and docs say global vs project. Plugin 2026.09.15.1620. Milestone 414 step 2. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01821k5B3Ysecp9fNYs92Kuy
83 lines
3.0 KiB
Python
83 lines
3.0 KiB
Python
"""drop rulebook subscriptions and per-project suppressions
|
|
|
|
Revision ID: 0101
|
|
Revises: 0100
|
|
Create Date: 2026-09-15
|
|
|
|
Milestone 414. A rule lives in a rulebook topic, where it is GLOBAL, or on one
|
|
project, and retrieval reads that home directly (step 1). Subscriptions were
|
|
the last thing that pretended a rulebook reached some projects and not others,
|
|
and after milestone 394 they changed nothing a session received — only what a
|
|
project's rule LISTING showed. Operator, 2026-09-15: "we have global and
|
|
project scoped rules, we don't need the subscriptions now."
|
|
|
|
WHAT GOES
|
|
|
|
- ``project_rulebook_subscriptions`` (migration 0058).
|
|
- ``project_rule_suppressions`` and ``project_topic_suppressions``. They let a
|
|
project mute rules from a rulebook it subscribed to. With no subscription
|
|
there is nothing to mute; a project that departs from a global rule writes
|
|
a project rule with an ``overrides`` relation, which says why.
|
|
- The ``subscribe_rulebooks`` key inside ``projects.inception.choices``, and
|
|
the ``exclude_always_on_rulebooks`` key milestone 394 left behind in the
|
|
same place. Both describe decisions that can no longer be made; a stored
|
|
record carrying them would be read back as a choice the product offers.
|
|
|
|
IRREVERSIBLE, AND THE DOWNGRADE SAYS SO
|
|
|
|
The downgrade recreates the three tables empty. Which projects subscribed to
|
|
which rulebooks, and what they muted, is in what this drops. Restore a backup
|
|
taken before this ran if the prior state matters.
|
|
"""
|
|
import sqlalchemy as sa
|
|
from alembic import op
|
|
|
|
revision = "0101"
|
|
down_revision = "0100"
|
|
branch_labels = None
|
|
depends_on = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.drop_table("project_topic_suppressions")
|
|
op.drop_table("project_rule_suppressions")
|
|
op.drop_table("project_rulebook_subscriptions")
|
|
op.execute(
|
|
"""
|
|
UPDATE projects
|
|
SET inception = jsonb_set(
|
|
inception, '{choices}',
|
|
(inception->'choices') - 'subscribe_rulebooks' - 'exclude_always_on_rulebooks'
|
|
)
|
|
WHERE inception IS NOT NULL
|
|
AND jsonb_typeof(inception->'choices') = 'object'
|
|
"""
|
|
)
|
|
|
|
|
|
def _join_table(name: str, other: str, other_table: str) -> None:
|
|
op.create_table(
|
|
name,
|
|
sa.Column(
|
|
"project_id", sa.BigInteger(),
|
|
sa.ForeignKey("projects.id", ondelete="CASCADE"),
|
|
primary_key=True, nullable=False,
|
|
),
|
|
sa.Column(
|
|
other, sa.BigInteger(),
|
|
sa.ForeignKey(f"{other_table}.id", ondelete="CASCADE"),
|
|
primary_key=True, nullable=False,
|
|
),
|
|
sa.Column(
|
|
"created_at", sa.DateTime(timezone=True),
|
|
server_default=sa.text("now()"), nullable=True,
|
|
),
|
|
)
|
|
|
|
|
|
def downgrade() -> None:
|
|
"""Structure only. See the module docstring — the rows are gone."""
|
|
_join_table("project_rulebook_subscriptions", "rulebook_id", "rulebooks")
|
|
_join_table("project_rule_suppressions", "rule_id", "rules")
|
|
_join_table("project_topic_suppressions", "topic_id", "rulebook_topics")
|