bvandeusenandClaude Opus 5.5
07e21c7ff9
CI & Build / Plugin hooks (push) Successful in 15s
CI & Build / Python lint (push) Successful in 2s
CI & Build / TypeScript typecheck (push) Successful in 54s
CI & Build / integration (push) Failing after 1m53s
CI & Build / Python tests (push) Successful in 2m39s
CI & Build / Build & push image (push) Skipped
- enter_project carries a `family` key, but only when the project has something to answer: counts of unassessed, owed and to-recheck answers, each with the list_family_adoptions call that lists it. It shows on every entry, never by platform touch: entry is when work is chosen, and an unanswered idea is otherwise invisible. - Retrieval: a widened project search (include_global_kinds) now also reaches the canon ideas on the project's platforms. It also reaches their references in the project's languages, or all of them when none matches. An off-platform project gets none, and the plain project filter (the duplicate gate) is unchanged. - Closing a task returns `family_owed`, the owed answers filed while it was open, and the report cue asks for them to be named. - New plugin skill family-canon (moment work.record) covers when to evaluate a promotion, answering in order, what counts as a reason, the precedent reflex and the conflict order. _INSTRUCTIONS, create_note, create_snippet, classify_shapes and reporting-back point at it. The plugin version is minted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
80 lines
3.4 KiB
Python
80 lines
3.4 KiB
Python
"""update_task closes a task with a one-line reminder of what the report needs.
|
|
|
|
The in-band half of milestone 409 step 3: the skill and static context only
|
|
exist in the Claude Code plugin, and a tool response reaches every MCP client
|
|
at the moment a piece of work closes. Pinned on the response, not the wording.
|
|
|
|
Step 4 adds the operator's own completion-report preferences beside the cue,
|
|
retrieved at that same moment — and only then, and only when there are any.
|
|
"""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
pytestmark = pytest.mark.usefixtures("_bind_user")
|
|
|
|
_PREF = {"id": 41, "title": "Say how it was checked", "statement": "…", "kind": "preference"}
|
|
|
|
|
|
async def _update(prefs=None, owed=None, **kwargs):
|
|
from scribe.mcp.tools.tasks import update_task
|
|
|
|
note = MagicMock(id=5, user_id=7, project_id=3, started_at="2026-10-06T09:00:00+00:00")
|
|
note.to_dict.return_value = {"id": 5}
|
|
lookup = AsyncMock(return_value=list(prefs or []))
|
|
with patch("scribe.mcp.tools.tasks.notes_svc.update_note", AsyncMock(return_value=note)), \
|
|
patch("scribe.mcp.tools.tasks.systems_tools.attach_systems", AsyncMock()), \
|
|
patch("scribe.mcp.tools.tasks.placement_svc.attach_placement", AsyncMock()), \
|
|
patch("scribe.mcp.tools.tasks.family_adoption_svc.owed_since",
|
|
AsyncMock(return_value=list(owed or []))), \
|
|
patch("scribe.mcp.tools.tasks.reply_prefs_svc.completion_preferences", lookup):
|
|
return await update_task(task_id=5, **kwargs), lookup
|
|
|
|
|
|
@pytest.mark.parametrize("status", ["done", "cancelled"])
|
|
async def test_closing_a_task_carries_the_cue(status):
|
|
out, _ = await _update(status=status)
|
|
assert "placement" in out["report_back"] and "needs them" in out["report_back"]
|
|
|
|
|
|
@pytest.mark.parametrize("kwargs", [{"status": "in_progress"}, {"status": "todo"}, {"body": "more notes"}])
|
|
async def test_other_updates_do_not(kwargs):
|
|
out, lookup = await _update(prefs=[_PREF], **kwargs)
|
|
assert "report_back" not in out and "reply_preferences" not in out
|
|
lookup.assert_not_awaited()
|
|
|
|
|
|
async def test_closing_hands_back_the_operators_report_preferences():
|
|
out, lookup = await _update(prefs=[_PREF], status="done")
|
|
assert out["reply_preferences"] == [_PREF]
|
|
# The cue says the key is there, so it never arrives unexplained.
|
|
assert "reply_preferences" in out["report_back"]
|
|
lookup.assert_awaited_once_with(7, project_id=3)
|
|
|
|
|
|
async def test_no_preferences_means_no_key_and_the_plain_cue():
|
|
from scribe.mcp.tools.tasks import REPORT_BACK_CUE
|
|
|
|
out, _ = await _update(prefs=[], status="done")
|
|
assert "reply_preferences" not in out
|
|
assert out["report_back"] == REPORT_BACK_CUE
|
|
|
|
|
|
_OWED = {"idea_id": 9, "idea_title": "Signed APK lane", "project_id": 4,
|
|
"project_title": "android two", "owed_task_id": 77}
|
|
|
|
|
|
async def test_closing_names_the_owed_adoptions_filed_while_the_task_was_open():
|
|
"""The finishing moment of milestone 463 step 6: owed family work filed
|
|
into a project during this task comes back for the report to name."""
|
|
from scribe.services.family_adoption import OWED_CUE
|
|
|
|
out, _ = await _update(owed=[_OWED], status="done")
|
|
assert out["family_owed"] == [_OWED]
|
|
assert out["report_back"].endswith(OWED_CUE) and "family_owed" in out["report_back"]
|
|
|
|
|
|
async def test_no_owed_adoptions_means_no_key():
|
|
out, _ = await _update(owed=[], status="done")
|
|
assert "family_owed" not in out
|