bvandeusenandClaude Opus 5.5
914f31359c
CI & Build / Python lint (push) Successful in 5s
CI & Build / Plugin hooks (push) Successful in 17s
CI & Build / TypeScript typecheck (push) Successful in 57s
CI & Build / integration (push) Successful in 1m19s
CI & Build / Python tests (push) Successful in 2m2s
CI & Build / Build & push image (push) Successful in 15s
Docstrings, section headers and assertion messages drop the record number, milestone or step that introduced the behaviour, and incident accounts are restated as the present-tense failure shape. A dead pointer to a design doc that is not in the repo is removed. Renamed to the property they check: test_the_old_shape_would_be_caught -> test_a_rank_then_scope_query_is_caught test_a_ledger_repeat_no_longer_produces_that_case_at_all -> test_a_ledger_repeat_is_counted_not_withheld test_the_header_no_longer_promises_once_per_session -> test_the_header_explains_the_seen_marker test_the_portal_case_no_longer_stamps_one_canon_onto_a_whole_file -> test_one_canon_is_not_stamped_onto_a_whole_file test_the_repos_own_prose_no_longer_defines_with -> test_the_repos_own_prose_does_not_define_with test_the_original_regression_create_note_with_content -> test_the_real_server_refuses_content_on_create_note Fixture and example ids stay: "note 5" in a supersession chain, "rule 156" in an illustrative question, `#2275` as the hex-versus-citation case, `#3244` as the example of a bare number, fixed dates in date-filter tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
64 lines
2.7 KiB
Python
64 lines
2.7 KiB
Python
"""The canonical-slug matcher — the line between what maps mechanically and
|
|
what a human is asked to confirm.
|
|
|
|
These cases are real-world drift: one area carrying three spellings, and two areas that LOOK alike and are not the same.
|
|
Getting the boundary wrong in either direction is a silent failure — a missed
|
|
mapping nobody thinks to make again, or a cross-project record surfacing in the
|
|
wrong project.
|
|
"""
|
|
import pytest
|
|
|
|
from scribe.services.canonical_systems import canonical_slug
|
|
|
|
|
|
@pytest.mark.parametrize("name", ["CI & Release", "CI and Release", "CI & release",
|
|
" ci and release "])
|
|
def test_spelling_variants_of_one_area_collapse_to_one_key(name):
|
|
"""Case, spacing, punctuation and "&" vs "and" are not real differences.
|
|
All three of the first spellings were live in different projects at once."""
|
|
assert canonical_slug(name) == "ci-and-release"
|
|
|
|
|
|
@pytest.mark.parametrize("name,expected", [
|
|
("Auth & Access", "auth-and-access"),
|
|
("Data Model & Storage", "data-model-and-storage"),
|
|
("UI & Design", "ui-and-design"),
|
|
("Background Jobs", "background-jobs"),
|
|
("Observability", "observability"),
|
|
])
|
|
def test_the_seeded_vocabulary_slugs_match_the_migration(name, expected):
|
|
"""Migration 0087 writes these slugs literally. If the function and the
|
|
migration disagree, every seeded entry becomes unreachable by exact match
|
|
and every mapping silently degrades to a proposal."""
|
|
assert canonical_slug(name) == expected
|
|
|
|
|
|
@pytest.mark.parametrize("a,b", [
|
|
("CI & Release", "CI & runners"),
|
|
("Auth & Access", "Auth & Accounts"),
|
|
("UI & Design", "Frontend (Vue app)"),
|
|
("UI & Design", "Web Shell and Theme"),
|
|
])
|
|
def test_genuinely_different_names_do_not_collapse(a, b):
|
|
"""These pairs may or may not be the same area — that is a judgment call,
|
|
so they must NOT map automatically. They reach the operator as proposals."""
|
|
assert canonical_slug(a) != canonical_slug(b)
|
|
|
|
|
|
def test_a_nameless_system_yields_no_key():
|
|
"""An empty slug is the one value callers must special-case: two unnameable
|
|
Systems must not map onto each other. Both propose_mappings and find_by_name
|
|
bail on a falsy slug for this reason."""
|
|
assert canonical_slug("") == ""
|
|
assert canonical_slug(" ") == ""
|
|
assert canonical_slug("---") == ""
|
|
|
|
|
|
def test_a_punctuation_separator_is_not_read_as_the_word_and():
|
|
""""CI/Release" is a real spelling and it does NOT collapse onto
|
|
"CI & Release" — only "&" carries that meaning. It still reaches the
|
|
operator through the overlap path, where both words match; what it must not
|
|
do is map itself silently."""
|
|
assert canonical_slug("CI/Release") == "ci-release"
|
|
assert canonical_slug("CI/Release") != canonical_slug("CI & Release")
|